Closed Bug 101747 Opened 24 years ago Closed 24 years ago

Composer should prompt for titles on pages without page titles

Categories

(SeaMonkey :: Composer, defect)

Product:
SeaMonkey
Component:
Composer
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.6

People

(Reporter: TucsonTester2, Assigned: Brade)

Details

(Whiteboard: EDITORBASE)

Attachments

(2 files)

HTML file to use in the steps to reproduce above
201 bytes, text/html
Details
always insert a <title>; cleanup some surrounding code
2.19 KB, patch
cmanske
: review+
kinmoz
: superreview+
Details | Diff | Splinter Review
Build ID: 20010924 In composer if you open up a page that does not have a <title> tag in it composer should prompt the user to enter one. Reproducible: Always Steps to Reproduce: 1.Open composer 2.Open the attached file provided below 3.Make a change and click on save Actual Results: It will not prompt the user to enter a title. Expected Results: I would expect that composer would prompt me to give the page a title. This is part of the W3C standards and is said to be requried. http://www.w3.org/TR/html401/struct/global.html#edef-TITLE
I am prompted for a title when I press save. What platform do you see this on? Can you reproduce it with a newer build? on a different platform or computer? -->brade
Assignee: syd → brade
I'm using Mac OSX but have seen this on Win 2k. What you will need to do is actually create an html file in a text editor. So the steps to reproduce are different. Steps to Reproduce: 1.Open a text editor and paste the html code below into the file 2.Close and save the file on the desktop and name it test.html 3.Open composer 4.Click file->Open and choose the test.html on your desktop 5.Make a change to the document and click save It will not prompt for a title even though the title tag is not present. Here is the HTML to paste into the text editor: <html> <head> <meta http-equiv="content-type" content="text/html; charset=ISO-8859-1"> </head> <body> <br> </body> </html>
Status: UNCONFIRMED → NEW
Ever confirmed: true
Confirmed on Mac OSX using build 20011003, Win 2k using build 20011002, and Win 98 using build 20010927.
I prefer this line be closer to where it is initialized (down a line or 2) PRInt32 currentMode; It looks like SetSizeMode has tabs in it, can we make them spaces instead? looks good to me; I'll let pink do the official r= ;-)
OK, I see this bug and we should fix it asap. I will need to rework the code in nsEditorShell.cpp to check for title when the file is already saved (in addition to when it hasn't yet been saved). Charley--do you think that we should always ask for title when it isn't present or only once per session or ?
Status: NEW → ASSIGNED
Whiteboard: EDITORBASE
Target Milestone: --- → mozilla0.9.6
I asked sfraser about this exact question when we did the Save and SaveAs code and we decided to not prompt user for Title if it didn't already exist. If user saves a file and doesn't want a title, they would be harrased each time they edit that file, so we decided it was best to only prompt for title when first saving. Simon?
Comment on attachment 52973 [details] [diff] [review] always insert a <title>; cleanup some surrounding code I think we should replace: if ( sz >= 1 ) with if (headnodelist.length >= 1) and drop the "sz" variable
Comment on attachment 52973 [details] [diff] [review] always insert a <title>; cleanup some surrounding code r=cmanske with change suggested above
Attachment #52973 - Flags: review+
Comment on attachment 52973 [details] [diff] [review] always insert a <title>; cleanup some surrounding code sr=kin@netscape.com
Attachment #52973 - Flags: superreview+
fix checked in
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Verified.
Status: RESOLVED → VERIFIED
Blocks: 144260
No longer blocks: 144260
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: