Closed Bug 1017566 Opened 5 years ago Closed 5 years ago

After "tab closed/undo" toast, cannot pan starting from where the toast was

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 32
Tracking Status
fennec 32+ ---

People

(Reporter: kats, Assigned: kats)

Details

Attachments

(1 file, 1 obsolete file)

On my Galaxy Q running gingerbread, if I close a tab, this shows the "tab closed" toast that was added recently. I can either hit the undo button or wait for the toast to disappear, but after this toast is shown any attempts to pan the page from a particular area seem to fail. That is, if I put my finger down around where the toast used to be (a little more halfway down the screen, around 80% width of the screen) and try to pan, the touch is ignored.
Just a note: You should be able to touch anywhere _not_ on the toast to make it disappear too.

Also, I can't reproduce on my Nexus 5
FWIW I remember running into something like this a while back, when supertoasts were first added. I thought I filed a bug for it but I can't find it now. I found bug 900385 which is pretty close though.
I can't reproduce this on my Nexus 4 either. Maybe gingerbread-specific?

(In reply to Mark Finkle (:mfinkle) from comment #1)
> Just a note: You should be able to touch anywhere _not_ on the toast to make
> it disappear too.

This doesn't appear to be the case on my Nexus 4 at least. It doesn't disappear until it's good and ready.
wesj might know what's going on here.
Flags: needinfo?(wjohnston)
Even if this isn't a new issue, we've been introducing more button toasts, so that increases its priority.
tracking-fennec: --- → ?
My guess is that this is visibility:GONE vs. visibility:INVISIBLE, and touch events.  I'll start the investigation.
Assignee: nobody → nalexander
We fixed this at one point. Its a Gingerbread bug.
Flags: needinfo?(wjohnston)
Ahh wait. That was for the ViewFlipper. We specialcased its touch event handling to fix this. We could do the same here I guess:

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/widget/GeckoViewFlipper.java
tracking-fennec: ? → 32+
I fixed an animation-related gingerbread issue in bug 976176. This may require a similar fix (something like clearing animations when hiding the banner).
Attached patch Patch (obsolete) — Splinter Review
Following margaret's patch above seemed to do the job.

Just need one reviewer, but would like to get this in before the merge, so sooner is better :)

https://tbpl.mozilla.org/?tree=Try&rev=bc3c5eaa4b95
Attachment #8436353 - Flags: review?(wjohnston)
Attachment #8436353 - Flags: review?(margaret.leibovic)
Attached patch PatchSplinter Review
Whoops, wrong patch. That approach worked too but this is simpler.
Attachment #8436353 - Attachment is obsolete: true
Attachment #8436353 - Flags: review?(wjohnston)
Attachment #8436353 - Flags: review?(margaret.leibovic)
Attachment #8436354 - Flags: review?(wjohnston)
Attachment #8436354 - Flags: review?(margaret.leibovic)
Attachment #8436354 - Flags: review?(wjohnston)
Attachment #8436354 - Flags: review?(margaret.leibovic)
Attachment #8436354 - Flags: review+
Comment on attachment 8436354 [details] [diff] [review]
Patch

Assuming we don't need the | Build.VERSION.SDK_INT < 11 | check here
I don't think so, although I didn't test that explicitly. There's another call to clearAnimation a few lines above which isn't version-checked so I assumed this should be fine.
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #13)
> I don't think so, although I didn't test that explicitly. There's another
> call to clearAnimation a few lines above which isn't version-checked so I
> assumed this should be fine.

Sounds good.
https://hg.mozilla.org/mozilla-central/rev/71494b7a518a
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 32
You need to log in before you can comment on or make changes to this bug.