1017566 - After "tab closed/undo" toast, cannot pan starting from where the toast was

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

On my Galaxy Q running gingerbread, if I close a tab, this shows the "tab closed" toast that was added recently. I can either hit the undo button or wait for the toast to disappear, but after this toast is shown any attempts to pan the page from a particular area seem to fail. That is, if I put my finger down around where the toast used to be (a little more halfway down the screen, around 80% width of the screen) and try to pan, the touch is ignored.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Just a note: You should be able to touch anywhere _not_ on the toast to make it disappear too.

Also, I can't reproduce on my Nexus 5

Comment 2

[Kartikaya Gupta (email:[e-mail])]

FWIW I remember running into something like this a while back, when supertoasts were first added. I thought I filed a bug for it but I can't find it now. I found bug 900385 which is pretty close though.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

I can't reproduce this on my Nexus 4 either. Maybe gingerbread-specific?

(In reply to Mark Finkle (:mfinkle) from comment #1)
> Just a note: You should be able to touch anywhere _not_ on the toast to make
> it disappear too.

This doesn't appear to be the case on my Nexus 4 at least. It doesn't disappear until it's good and ready.

Comment 4

[:Margaret Leibovic]

wesj might know what's going on here.

Comment 5

[:Margaret Leibovic]

Even if this isn't a new issue, we've been introducing more button toasts, so that increases its priority.

Comment 6

[Nick Alexander :nalexander [he/him]]

My guess is that this is visibility:GONE vs. visibility:INVISIBLE, and touch events.  I'll start the investigation.

Comment 7

[Wesley Johnston (:wesj)]

We fixed this at one point. Its a Gingerbread bug.

Comment 8

[Wesley Johnston (:wesj)]

Ahh wait. That was for the ViewFlipper. We specialcased its touch event handling to fix this. We could do the same here I guess:

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/widget/GeckoViewFlipper.java

Comment 9

[:Margaret Leibovic]

I fixed an animation-related gingerbread issue in bug 976176. This may require a similar fix (something like clearing animations when hiding the banner).

Comment 10

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

Following margaret's patch above seemed to do the job.

Just need one reviewer, but would like to get this in before the merge, so sooner is better :)

https://tbpl.mozilla.org/?tree=Try&rev=bc3c5eaa4b95

Comment 11

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

Whoops, wrong patch. That approach worked too but this is simpler.

Comment 12

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8436354 [details] [diff] [review]
Patch

Assuming we don't need the | Build.VERSION.SDK_INT < 11 | check here

Comment 13

[Kartikaya Gupta (email:[e-mail])]

I don't think so, although I didn't test that explicitly. There's another call to clearAnimation a few lines above which isn't version-checked so I assumed this should be fine.

Comment 14

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #13)
> I don't think so, although I didn't test that explicitly. There's another
> call to clearAnimation a few lines above which isn't version-checked so I
> assumed this should be fine.

Sounds good.

Comment 15

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/fx-team/rev/71494b7a518a

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/71494b7a518a