1017883 - Unable to view saved passwords in Thunderbird32.0a1, since _INTL_API not enabled

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Joe Sabash [:JoeS1]]

Tools>>Options>>Security>>Saved Passwords will not display
Error Console:Self built to current Tip
Timestamp: 5/29/2014 6:05:47 PM
Error: NS_ERROR_FAILURE: Couldn't decrypt string
Source File: file:///C:/Users/JoeS/comm-central/objdir-tb-trunk36/mozilla/dist/bin/components/crypto-SDR.js
Line: 165
Last good build I have handy is 2014-05-14

Comment 1

[Alice0775 White]

Regression window
Good:
https://hg.mozilla.org/mozilla-central/rev/e9b2b72f4e6c
https://hg.mozilla.org/comm-central/rev/e39749aee0ce
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:32.0) Gecko/20100101 Thunderbird/32.0a1 ID:20140523030203
Bad:
https://hg.mozilla.org/mozilla-central/rev/e86a0d92d174
https://hg.mozilla.org/comm-central/rev/7f20f6b479da
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:32.0) Gecko/20100101 Thunderbird/32.0a1 ID:20140524030204
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e9b2b72f4e6c&tochange=e86a0d92d174
http://hg.mozilla.org/comm-central/pushloghtml?fromchange=e39749aee0ce&tochange=7f20f6b479da

Suspect:
074c77fc983b	Justin Dolske — Bug 998081 - Show login metadata in password manager UI. r=mattn

Comment 2

[Alice0775 White]

I confirmed that backing out 074c77fc983b from tip(https://hg.mozilla.org/mozilla-central/rev/38c5e21a80fa, http://hg.mozilla.org/comm-central/rev/16295350aca3)fixes the problem.

Comment 3

[Matthew N. [:MattN]]

Weird, I'm not sure how this would break TB but not Fx.

Getting the stack of the error would help diagnose this. You should be able to use the Browser Debugger (assuming this is in TB) to break on exceptions and look at the stack.

Alice, can you reproduce this in Firefox or do you think it's specific to Thunderbird?

Comment 4

[Alice0775 White]

(In reply to Matthew N. [:MattN] from comment #3)
> Weird, I'm not sure how this would break TB but not Fx.

> Alice, can you reproduce this in Firefox or do you think it's specific to
> Thunderbird?


This problem also happens on Nightly32.0a1 on existing profile(which have been used since firefox3.6....), but not newly created one....

So, this is not Thunderbird specifc.

Comment 5

[Alice0775 White]

And  password auto complete also be broken in Nightly32.0a1 with existing profile....

If you do not understand what is wrong of Bug 998081.
I think Bug 998081 should be backed out for SECURITY reason ASAP.

Comment 6

[Alice0775 White]

Umm
I think Firefox's problem is a different problem (maybe migration problem caused by Bug 853549).

Comment 7

[Alice0775 White]

The problem is that |Intl| is undefined in Thunderbird32.0a1.

Comment 8

[Justin Dolske [:Dolske]]

Thunderbird should implement Intl, it's part of the web platform now.

Comment 9

[Alice0775 White]

Sorry, I do not understand your comment.

The broken Password Manager in Thunderbird is intentional?

Where is the alternative Password Manager in Thunderbird?

Comment 10

[Justin Dolske [:Dolske]]

Not intentional. As I said, Thunderbird needs add support for Intl so this works as expected, as it's part of the platform now and is going to show up in more and more code. I assume this is probably just a packaging problem, if it's a bigger problem I'd consider accepting a temporary workaround patch.

Please don't start reopen wars.

Comment 11

[Magnus Melin [:mkmelin]]

Not WONTFIX for thunderbird ;)

So the reason is probably http://mxr.mozilla.org/comm-central/source/mozilla/configure.in#9021

jcranmer: should it be enabled there, or do we have a more suitable place somewhere?

xref bug 992651

Comment 12

[Philip Chee]

(In reply to Magnus Melin from comment #11)
> Not WONTFIX for thunderbird ;)
> 
> So the reason is probably
> http://mxr.mozilla.org/comm-central/source/mozilla/configure.in#9021
> 
> jcranmer: should it be enabled there, or do we have a more suitable place
> somewhere?

You probably need more bits from:
http://hg.mozilla.org/mozilla-central/rev/b0678affef03
And perhaps:
http://hg.mozilla.org/mozilla-central/rev/6e75f48dd0cf

Comment 13

[Joshua Cranmer [:jcranmer]]

(In reply to Magnus Melin from comment #11)
> Not WONTFIX for thunderbird ;)
> 
> So the reason is probably
> http://mxr.mozilla.org/comm-central/source/mozilla/configure.in#9021
> 
> jcranmer: should it be enabled there, or do we have a more suitable place
> somewhere?

You should whack ehsan on the head for hard-coding MOZ_BUILD_APP instead of using confvars.sh.

Comment 14

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

This was the only thing needed for thunderbird, the changesets Philip mentioned have already been done for tb it seems. Works fine as least locally (but i notice some slowness, not sure if it's related or not?).

I didn't check suite, but arguably they are currently as broken as thunderbird by this - so no point including an opt out check for suite here.

Comment 15

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d5b0cce4d2b5

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d5b0cce4d2b5