Unable to view saved passwords in Thunderbird32.0a1, since _INTL_API not enabled

RESOLVED FIXED in Thunderbird 32.0

Status

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: JoeS1, Assigned: mkmelin)

Tracking

({regression})

Trunk
Thunderbird 32.0
Dependency tree / graph

Thunderbird Tracking Flags

(thunderbird32 affected)

Details

Attachments

(1 attachment)

Tools>>Options>>Security>>Saved Passwords will not display
Error Console:Self built to current Tip
Timestamp: 5/29/2014 6:05:47 PM
Error: NS_ERROR_FAILURE: Couldn't decrypt string
Source File: file:///C:/Users/JoeS/comm-central/objdir-tb-trunk36/mozilla/dist/bin/components/crypto-SDR.js
Line: 165
Last good build I have handy is 2014-05-14
Regression window
Good:
https://hg.mozilla.org/mozilla-central/rev/e9b2b72f4e6c
https://hg.mozilla.org/comm-central/rev/e39749aee0ce
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:32.0) Gecko/20100101 Thunderbird/32.0a1 ID:20140523030203
Bad:
https://hg.mozilla.org/mozilla-central/rev/e86a0d92d174
https://hg.mozilla.org/comm-central/rev/7f20f6b479da
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:32.0) Gecko/20100101 Thunderbird/32.0a1 ID:20140524030204
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e9b2b72f4e6c&tochange=e86a0d92d174
http://hg.mozilla.org/comm-central/pushloghtml?fromchange=e39749aee0ce&tochange=7f20f6b479da

Suspect:
074c77fc983b	Justin Dolske — Bug 998081 - Show login metadata in password manager UI. r=mattn
Blocks: 998081
Flags: needinfo?(dolske)
I confirmed that backing out 074c77fc983b from tip(https://hg.mozilla.org/mozilla-central/rev/38c5e21a80fa, http://hg.mozilla.org/comm-central/rev/16295350aca3)fixes the problem.
Component: Preferences → Password Manager
Product: Thunderbird → Toolkit
Version: Trunk → 32 Branch
Summary: Unable to view saved passwords → Unable to view saved passwords in Thunderbird 32.0a1
Weird, I'm not sure how this would break TB but not Fx.

Getting the stack of the error would help diagnose this. You should be able to use the Browser Debugger (assuming this is in TB) to break on exceptions and look at the stack.

Alice, can you reproduce this in Firefox or do you think it's specific to Thunderbird?
Flags: needinfo?(alice0775)
(In reply to Matthew N. [:MattN] from comment #3)
> Weird, I'm not sure how this would break TB but not Fx.

> Alice, can you reproduce this in Firefox or do you think it's specific to
> Thunderbird?


This problem also happens on Nightly32.0a1 on existing profile(which have been used since firefox3.6....), but not newly created one....

So, this is not Thunderbird specifc.
Flags: needinfo?(alice0775)
Summary: Unable to view saved passwords in Thunderbird 32.0a1 → Unable to view saved passwords in Thunderbird32.0a1 and Nightly32.0a1
And  password auto complete also be broken in Nightly32.0a1 with existing profile....

If you do not understand what is wrong of Bug 998081.
I think Bug 998081 should be backed out for SECURITY reason ASAP.
Umm
I think Firefox's problem is a different problem (maybe migration problem caused by Bug 853549).
Summary: Unable to view saved passwords in Thunderbird32.0a1 and Nightly32.0a1 → Unable to view saved passwords in Thunderbird32.0a1
The problem is that |Intl| is undefined in Thunderbird32.0a1.
Depends on: 1018244
Thunderbird should implement Intl, it's part of the web platform now.
Status: NEW → RESOLVED
Closed: 5 years ago
Flags: needinfo?(dolske)
Resolution: --- → WONTFIX
Sorry, I do not understand your comment.

The broken Password Manager in Thunderbird is intentional?

Where is the alternative Password Manager in Thunderbird?
Status: RESOLVED → REOPENED
Flags: needinfo?(dolske)
Resolution: WONTFIX → ---
Not intentional. As I said, Thunderbird needs add support for Intl so this works as expected, as it's part of the platform now and is going to show up in more and more code. I assume this is probably just a packaging problem, if it's a bigger problem I'd consider accepting a temporary workaround patch.

Please don't start reopen wars.
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Flags: needinfo?(dolske)
Resolution: --- → WONTFIX
Not WONTFIX for thunderbird ;)

So the reason is probably http://mxr.mozilla.org/comm-central/source/mozilla/configure.in#9021

jcranmer: should it be enabled there, or do we have a more suitable place somewhere?

xref bug 992651
Status: RESOLVED → REOPENED
Component: Password Manager → General
OS: Windows 7 → All
Product: Toolkit → Thunderbird
Hardware: x86_64 → All
Resolution: WONTFIX → ---
Target Milestone: --- → Thunderbird 32.0
Version: 32 Branch → Trunk
(In reply to Magnus Melin from comment #11)
> Not WONTFIX for thunderbird ;)
> 
> So the reason is probably
> http://mxr.mozilla.org/comm-central/source/mozilla/configure.in#9021
> 
> jcranmer: should it be enabled there, or do we have a more suitable place
> somewhere?

You probably need more bits from:
http://hg.mozilla.org/mozilla-central/rev/b0678affef03
And perhaps:
http://hg.mozilla.org/mozilla-central/rev/6e75f48dd0cf
Status: REOPENED → NEW
(In reply to Magnus Melin from comment #11)
> Not WONTFIX for thunderbird ;)
> 
> So the reason is probably
> http://mxr.mozilla.org/comm-central/source/mozilla/configure.in#9021
> 
> jcranmer: should it be enabled there, or do we have a more suitable place
> somewhere?

You should whack ehsan on the head for hard-coding MOZ_BUILD_APP instead of using confvars.sh.
Posted patch proposed fixSplinter Review
This was the only thing needed for thunderbird, the changesets Philip mentioned have already been done for tb it seems. Works fine as least locally (but i notice some slowness, not sure if it's related or not?).

I didn't check suite, but arguably they are currently as broken as thunderbird by this - so no point including an opt out check for suite here.
Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Attachment #8432110 - Flags: review?(mh+mozilla)
Attachment #8432110 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/d5b0cce4d2b5
Status: ASSIGNED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
Summary: Unable to view saved passwords in Thunderbird32.0a1 → Unable to view saved passwords in Thunderbird32.0a1, since _INTL_API not enabled
You need to log in before you can comment on or make changes to this bug.