1017950 - [Flatfish][Wifi] Not able to scan and connect to wifi

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Wifi, defect)

Description

[Sherman Chen [:chens] (inactive)]

We can't scan and connect to wifi using the latest version of B2G on flatfish, here's the error message: 

E/GeckoConsole(25584): Content JS ERROR at app://ftu.gaiamobile.org/js/wifi.js:62 in onScanError: Error reading networks: Unable to scan for networks

Latest commit log of B2G:
commit 3fdf2ece624d6fc0b67f81f38b017d80053d2fdf
Merge: a6e6e36 c36a14e
Author: Ryan VanderMeulen <[e-mail]>
Date:   Fri May 23 06:36:19 2014 -0700

    Merge pull request #348 from xwaynec/master
    
    Bug 1010652 - [Vixen][Tablet] Integrate vixen manifest file. r=mwu

Latest commit log of gecko:
commit 96c549d1054014ea76d8b079f36164eb437261c0
Merge: 8fd49b9 f634ff5
Author: Tim Taubert <[e-mail]>
Date:   Thu May 29 08:32:31 2014 +0200

    merge m-c to inbound

Latest commit log of gaia:
commit 6001520d36ff3ceb37acc30c93ef15560551bc6d
Merge: f24b8ab df90d63
Author: Timothy Guan-tin Chien <[e-mail]>
Date:   Thu May 29 16:34:02 2014 +0800

    Merge pull request #19714 from elefant/bug/1016866
    
    Bug 1016866 - Always send a notification when captive portal is detected, r=

Comment 1

[Sherman Chen [:chens] (inactive)]

More error message from after enable wifi logs in adb:
E/GeckoConsole( 1272): [JavaScript Error: "NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: [JavaScript Error: "this.isNetworkTypeMobile is not a function" {file: "jar:file:///system/b2g/omni.ja!/components/NetworkManager.js" line: 300}]'[JavaScript Error: "this.isNetworkTypeMobile is not a function" {file: "jar:file:///system/b2g/omni.ja!/components/NetworkManager.js" line: 300}]' when calling method: [nsINetworkManager::registerNetworkInterface]" {file: "jar:file:///system/b2g/omni.ja!/components/WifiWorker.js" line: 957}]
I/Gecko   ( 1272): settings 'handle' callback threw an exception, dropping: [Exception... "[JavaScript Error: "this.isNetworkTypeMobile is not a function" {file: "jar:file:///system/b2g/omni.ja!/components/NetworkManager.js" line: 300}]'[JavaScript Error: "this.isNetworkTypeMobile is not a function" {file: "jar:file:///system/b2g/omni.ja!/components/NetworkManager.js" line: 300}]' when calling method: [nsINetworkManager::registerNetworkInterface]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: jar:file:///system/b2g/omni.ja!/components/WifiWorker.js :: manager.setWifiEnabled :: line 957"  data: yes]

Comment 2

[:gerard-majax]

I see that getNetworkId() in dom/system/gonk/NetworkManager.js calls isNetworkTypeMobile(). But that last method is only devices when MOZ_B2G_RIL is defined; which is not the case for Flatfish.

Comment 3

[:gerard-majax]

Jessica, it seems your patch for bug 939046 regressed this on Flatfish: your code is called even when MOZ_B2G_RIL is not defined, but isNetworkTypeMobile is only defined when MOZ_B2G_RIL is.

Comment 4

[Jessica Jong [:jessica] (inactive)]

Oh, so sorry for this :(. I am out of the office today, will check it first thing tomorrow morning. Keeping the NI flag for tracking.

Comment 5

[Jessica Jong [:jessica] (inactive)]

Attachment: patch.

I don't have a Flatfish in hand, could someone help verify if the attached patch fixes the reported issue? Thanks a lot.

Comment 6

[Jessica Jong [:jessica] (inactive)]

Attachment: patch.

Attaching the correct patch.

I don't have a Flatfish in hand, could someone help verify if the attached patch fixes the reported issue? Thanks a lot.

Comment 7

[ralf tauscher]

hi jessica,

I applied the patch and will build it... but it will take some hours on my machine ;o)

greets,
ralf

Comment 8

[ralf tauscher]

yes, it worked. last build was fresh enough so it was faster.

so now wifi is working again on flatfish.

thanks jessica

Comment 9

[Jessica Jong [:jessica] (inactive)]

(In reply to ralf tauscher from comment #8)
> yes, it worked. last build was fresh enough so it was faster.
> 
> so now wifi is working again on flatfish.
> 
> thanks jessica

Thank you, ralf :) Will ask for review then.

Comment 10

[Jessica Jong [:jessica] (inactive)]

Attachment: patch, r=hsinyi

Hsinyi, we should wrap isNetworkTypeMobile() part in getNetworkId() with MOZ_B2G_RIL flag. May I have you review? Thanks.

Comment 11

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8441216 [details] [diff] [review]
patch, r=hsinyi

Review of attachment 8441216 [details] [diff] [review]:
-----------------------------------------------------------------

Oh... thank you ORZ

Comment 12

[:gerard-majax]

Comment on attachment 8441188 [details] [diff] [review]
patch.

I don't either. But I know people who does :)

Comment 13

[David Lawrence [:dkl]]

(In reply to Jessica Jong [:jjong] [:jessica] from comment #6)
> Created attachment 8441188 [details] [diff] [review]
> patch.
> 
> Attaching the correct patch.
> 
> I don't have a Flatfish in hand, could someone help verify if the attached
> patch fixes the reported issue? Thanks a lot.

Just wanted to verify that this patch also fixes the wireless issue for me.

dkl

Comment 14

[Jessica Jong [:jessica] (inactive)]

try: https://tbpl.mozilla.org/?tree=Try&rev=cc78527d41e1

Thanks for verifying, I think we are good to go!

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/b2g-inbound/rev/304c91c291a7

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/304c91c291a7

Comment 17

[Ralph Giles (:rillian)]

I see this fix on master, but not in my v2.0 branch build. Can we backport it?

Comment 18

[Ralph Giles (:rillian)]

Confirmed; cherry-picking this on top of 9db44df885da60ee3442362d0abd04e930124781 in my v2.0 build resolves the problem with wifi.