Closed
Bug 1018256
Opened 11 years ago
Closed 11 years ago
Save and Change Character Encoding dialog has no encodings
Categories
(SeaMonkey :: Composer, defect)
SeaMonkey
Composer
Tracking
(seamonkey2.28 unaffected, seamonkey2.29 fixed, seamonkey2.30 fixed)
RESOLVED
FIXED
seamonkey2.30
| Tracking | Status | |
|---|---|---|
| seamonkey2.28 | --- | unaffected |
| seamonkey2.29 | --- | fixed |
| seamonkey2.30 | --- | fixed |
People
(Reporter: neil, Assigned: neil)
Details
(Keywords: regression)
Attachments
(1 file)
|
6.40 KB,
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
Thanks to the magic of RDF, editor's change encoding dialog used to populate itself from the same data source as all of the character encoding menus that used to exist. Sadly people no longer get this and we have to reinvent the wheel all over again.
|
Assignee | |
Comment 1•11 years ago
|
||
I kept the tree as it's easier to select an item in a tree than a listbox.
CharsetMenu only provides methods to return a separate list of pinned and other charset info objects. I have to extract the charsets to ask for a single list, which it then gives to me in the correct order. (I then have to ask for the charsets again to find which one to select...)
Attachment #8431630 -
Flags: review?(iann_bugzilla) → review+
|
|
Assignee | |
Comment 2•11 years ago
|
||
Oops, comm-central changeset 699551e9deae was for bug 1018263, not this bug.
|
|
Assignee | |
Comment 3•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
status-seamonkey2.28:
--- → unaffected
status-seamonkey2.29:
--- → affected
status-seamonkey2.30:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.30
|
|
Assignee | |
Comment 4•11 years ago
|
||
Comment on attachment 8431630 [details] [diff] [review]
Proposed patch
[Approval Request Comment]
Regression caused by (bug #): 943252
User impact if declined: No encodings available
Testing completed (on m-c, etc.): Landed on c-c
Risk to taking this patch (and alternatives if risky): Low, rarely used
String changes made by this patch: None
Attachment #8431630 -
Flags: approval-comm-aurora?
Attachment #8431630 -
Flags: approval-comm-aurora? → approval-comm-aurora+
|
|
Assignee | |
Comment 5•11 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•