1018404 - [B2G][Settings][Send Feedback] The send feedback button does not prompt a thank you message

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Attachment: Flame 2.0 Logcat

Description:
When the user is trying to submit comments for feedback about the phone, the 'Send Feedback' button appears to not be working and will not display a thank you page when the button is tapped

Repro Steps:
1) Update a Flame to BuildID: 20140527040202
2)Open the Settings app.
3)Select Improve Firefox OS near the bottom of the list
4)Tap on the Send Performance data box to make sure it is checked
5)Select the 'Send Mozilla Feedback' Button
6)Select Happy or Sad
7)Select the Send Feedback Button

Actual:
The button will highlight blue but nothing appears to happen

Expected:
The button highlights blue indicating it has been tapped, then the user is taken to a screen thanking them for their feedback

Flame 2.0
2.0 Environmental Variables:
Device: Flame 2.0
BuildID: 20140530040207
Gaia: 26d8fcab9b61f46451600f39c51e03
87ef3c4f88
Gecko: e6f113c83095
Version: 32.0a1
Firmware Version: v10G-2
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0


Keywords: FireFox, Operating System, Happy, Sad, Feel, Send, Prompt, Details, Canceled

Repro frequency: 100%
Link to failed test case: https://moztrap.mozilla.org/manage/case/2857/
See attached: Logcat, Video - https://www.youtube.com/watch?edit=vd&v=TWPYgf2-Bkk

Logcat is currently affected based on bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1010993

Comment 1

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

This issue DOES repro on Buri 2.0


Buri 2.0

2.0 Environmental Variables:
Device: Buri 2.0 MOZ
BuildID: 20140530040207
Gaia: 26d8fcab9b61f46451600f39c51e0387ef3c4f88
Gecko: e6f113c83095
Version: 32.0a1
Firmware Version: v1.2-device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0



This issue DOES repro on Open C 2.0


Open_C 2.0

2.0 Environmental Variables:
Device: Open C 2.0
BuildID: 20140530040207
Gaia: 26d8fcab9b61f46451600f39c51e03
87ef3c4f88
Gecko: e6f113c83095
Version: 32.0a1
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0 


This issue does NOT occur on Flame 1.4

Flame 1.4

1.4 Environmental Variables:
Device: Flame 1.4
BuildID: 20140530000202
Gaia: fe612fd21389193a8e593aa718831602e5086a62
Gecko: 25011f9a8f26
Version: 30.0
Firmware Version: v10G-2
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

When the user taps on 'Send Feedback' there is a window that pops up thanking the user for their feedback

Comment 2

[Jason Smith [:jsmith]]

This is likely meaning that sending of feedback isn't working.

Comment 3

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Just took this.

Comment 4

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch on master

Hi Arthur,

can you help me review this small changes ? Thanks :]

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8434624 [details] [review]
patch on master

Good job! r=me.

Comment 6

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks Arthur, 

merged into Gaia/master : 8f75e3bae75c9133cdf7c14bc163e7aab60ffeca