1018551 - clean up font/shaper code to remove redundancy and dead mPlatformShaper field

Status: RESOLVED FIXED

(Core :: Graphics: Text, defect)

Description

[Jonathan Kew [:jfkthame]]

With the Windows-specific shapers gone, the only "platform shaper" we have left is Core Text, so it makes more sense to handle this entirely in the gfxMacFont subclass, and drop it from the generic gfxFont. (See bug 985220 comment 3.)

We can also clean up the gfx{backend}Font::ShapeText methods a bit, now that there are fewer platform-specific cases to handle.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: clean up redundancy in the font/shaper code.

Comment 2

[Jonathan Kew [:jfkthame]]

Tryserver run: https://tbpl.mozilla.org/?tree=Try&rev=17806e23c6a5

Comment 3

[John Daggett (:jtd)]

Comment on attachment 8432054 [details] [diff] [review]
clean up redundancy in the font/shaper code.

Yay!

Comment 4

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fd9518344a23

Comment 5

[Carsten Book [:Tomcat]]

sorry had to backout this change for test failures like https://tbpl.mozilla.org/php/getParsedLog.php?id=40847823&tree=Mozilla-Inbound

Comment 6

[Carsten Book [:Tomcat]]

did now a re-checkin in https://hg.mozilla.org/integration/mozilla-inbound/rev/3e9d9aa535c7 since the test failures seems to be caused by the checkin before

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3e9d9aa535c7

Comment 8

[Jonathan Kew [:jfkthame]]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/0e387a554646 due to Thai regression described in bug 1020826.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Merge of backout:
https://hg.mozilla.org/mozilla-central/rev/0e387a554646

Comment 10

[Jonathan Kew [:jfkthame]]

Re-landed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee3e74ba96a9

Comment 11

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/ee3e74ba96a9