1018720 - Translation infobar: missing HiDPI icon

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Sören Hentzschel]

Attachment: screenshot.png

The arrow icon in the select box needs a HiDPI version.

Comment 1

[Florian Quèze [:florian]]

Sevaan, do we have a HiDPI version of this icon somewhere?

Comment 2

[Sevaan Franks [:sevaan]]

The arrow can be found in the assets mmaslaney has uploaded here: https://bugzilla.mozilla.org/show_bug.cgi?id=1024741#c7

Comment 3

[Florian Quèze [:florian]]

(In reply to Sevaan Franks [:sevaan] from comment #2)
> The arrow can be found in the assets mmaslaney has uploaded here:
> https://bugzilla.mozilla.org/show_bug.cgi?id=1024741#c7

Are we intentionally switching from a double arrow to a single arrow?

Comment 4

[Steven MacLeod [:smacleod]]

(In reply to Florian Quèze [:florian] [:flo] from comment #3)
> (In reply to Sevaan Franks [:sevaan] from comment #2)
> > The arrow can be found in the assets mmaslaney has uploaded here:
> > https://bugzilla.mozilla.org/show_bug.cgi?id=1024741#c7
> 
> Are we intentionally switching from a double arrow to a single arrow?

^ Sevaan?

Comment 5

[:Gijs (he/him)]

(also, in-content we seem to have hi-dpi spinner-like icons for e.g. select boxes... don't know how hard it is to just steal that, and/or why this is a <menulist> rather than an html:select...)

Comment 6

[Sevaan Franks [:sevaan]]

Hey Steven, sorry for the late reply. Yes, that is the intention as we move toward a new, more unified style.

(In reply to Steven MacLeod [:smacleod] from comment #4)


> (In reply to Florian Quèze [:florian] [:flo] from comment #3)
> > (In reply to Sevaan Franks [:sevaan] from comment #2)
> > > The arrow can be found in the assets mmaslaney has uploaded here:
> > > https://bugzilla.mozilla.org/show_bug.cgi?id=1024741#c7
> > 
> > Are we intentionally switching from a double arrow to a single arrow?
> 
> ^ Sevaan?

Comment 7

[Sevaan Franks [:sevaan]]

Michael Maslaney, can you confirm the single arrow vs. double? Flo-retina pointed out that we are still using double-arrows in the Incontent UI stuff.

Comment 8

[Michael Maslaney [:mmaslaney] ([e-mail])]

Attachment: -Prompt-assets.zip

We are moving forward with the single arrow, attached.

Comment 9

[Steven MacLeod [:smacleod]]

Attachment: screenshot-select-box-icon.png

This is a screenshot using the updated HiDPI icon provided. Is it just me or does it bother anyone else that the options menu uses a different arrow icon?

Thoughts?

Comment 10

[Sevaan Franks [:sevaan]]

Those arrows should definitely match.

A couple other things I can see:

- The background colour of the options button should match the language drop-down (there should be a very subtle gradient).
- The border of the language drop-down should match the border of the options button: #cdd3d8
- The language drop-down should be the same height as the options button (slightly larger)

Comment 11

[Florian Quèze [:florian]]

(In reply to Sevaan Franks [:sevaan] from comment #10)

> - The language drop-down should be the same height as the options button
> (slightly larger)

We handled this in bug 1022405.

Comment 12

[Steven MacLeod [:smacleod]]

Attachment: Patch 1 - Switch the translation infobar select box icon and add a HiDPI variant.

This patch switches the select box and adds a HiDPI variant. This pretty much brings things to the state of the previously posted screenshot.

Comment 13

[Steven MacLeod [:smacleod]]

Attachment: Patch 2 - Fix translation infobar button styling.

The patch in Bug 1028942 was incorrect. This patch fixes the buttons so that the options dropdown has the correct style as well.

Comment 14

[Steven MacLeod [:smacleod]]

Attachment: Patch 3 - Change the translation infobar select dropdown styling to match the options dropdown.

This makes the styling of the select dropdown match the options dropdown (and fixes the height).

Comment 15

[Steven MacLeod [:smacleod]]

Attachment: Patch 4 - Change the options dropdown icon to match the select dropdown.

Finally, this updates the icon of the options dropdown to match the new select dropdown icon introduced in patch 1.

Comment 16

[Steven MacLeod [:smacleod]]

Attachment: screenshot-post-patches.png

This is a screenshot of the inforbar after applying the patches. The hover states of all the elements (excluding the "Translate" button) are now consistent as well.

Comment 17

[Sevaan Franks [:sevaan]]

That looks great, Steven. Thanks!

Comment 18

[Florian Quèze [:florian]]

Comment on attachment 8450511 [details]
screenshot-select-box-icon.png

Next version looks much better..

Comment 19

[Steven MacLeod [:smacleod]]

Patch 1: https://hg.mozilla.org/integration/fx-team/rev/d552d2ba30a5
Patch 2: https://hg.mozilla.org/integration/fx-team/rev/533c1369f45b
Patch 3: https://hg.mozilla.org/integration/fx-team/rev/b0084d208f32
Patch 4: https://hg.mozilla.org/integration/fx-team/rev/0102658bc570

Comment 20

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d552d2ba30a5
https://hg.mozilla.org/mozilla-central/rev/533c1369f45b
https://hg.mozilla.org/mozilla-central/rev/b0084d208f32
https://hg.mozilla.org/mozilla-central/rev/0102658bc570

Comment 21

[Bogdan Maris, Desktop QA]

We don`t have a Mac with Retina Display here, Sören can you please verify that the issue is fixed?

Comment 22

[Sören Hentzschel]

Yes, it looks good now. :)

Comment 23

[Bogdan Maris, Desktop QA]

Thanks a lot, marking this as verified then.