1019426 - When searching in the Address Book from the Dialer a white tab is shown over the keyboard

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Maria Angeles Oteo (:oteo)]

STR:

1. Go to Dialer aplication
2. Open Contacts
3. Start a search 

Current Result: a white tab appears over the Keyboard. Video of the bug: https://www.youtube.com/watch?v=j-eSJbE5tgM

I can reproduce the bug in latest master build:

Environmental Variables:
Device: Hamachi
BuildID: 20140602070515
B-185
Gecko-3e5340d
Gaia-e508b51
Version: 32.0a1

Bug does not happen in v1.4 release
Environmental Variables:
Device: Hamachi
BuildID: 20140602053909
B-80
Gecko-080d2fc
Gaia-ba8d7ef
Version: 30.0

Comment 1

[Francisco Jordano [:arcturus] [:francisco]]

Assigning for taking a look.

Thanks

Comment 2

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: 2.0+ as this is regression and also obvious UI bug

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Hei,

I've been trying to reproduce this bug in my hamachi but wasnt able.

Just recorded a video of this, with current master flashed on the phone:

https://drive.google.com/file/d/0B3RfQh7fuZjAMXB3Q3FPZGlpRXM/edit?usp=sharing

M. Angeles, do you still reproduce it?

Comment 4

[Maria Angeles Oteo (:oteo)]

I am still reproducing it in latest master buid on my buri.

Checking your video, I think you have missed the first step in the STR :)
1. Go to Dialer aplication

You need to launch the Contacts application from the Dialer to reproduce the fault, otherwise it works fine. 

It seems that the issue is related to the bottom tab (Call Log/Contacts/Dialpad) that when searching is not correctly hidden and that makes appears that white tab over the keyboard.

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Thanks M. Angeles, I totally missread the bug.

Now I can see it within the dialer :)

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to pr 20241

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Changing to the proper component and asking review from a dialer peer

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8437028 [details] [review]
Pointer to pr 20241

Anthony could you take a look?

Thanks.

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

No unit test added since it's a css change

Comment 10

[Anthony Ricaud (:rik)]

Comment on attachment 8437028 [details] [review]
Pointer to pr 20241

Thanks for trying to fix it. We've had many similar situations broken in the past so I'm gonna do another patch that cleans things up a bit.

Comment 11

[Anthony Ricaud (:rik)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/20303

Comment 12

[Etienne Segonzac (:etienne)]

Comment on attachment 8437742 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/20303

I like the approach, but it's pretty weird to see the toolbar appear then disappear again when the keyboard comes in.

I think we should have a NavBarManager.hide(true /* instant */) for this case where we don't wait 0.5s to start a 0.5s transition.

Comment 13

[Anthony Ricaud (:rik)]

Comment on attachment 8437742 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/20303

Instead of adding a mode, I just removed all the transitions. They were not working reliably and it kinda feels better with the keyboard.

Comment 14

[Anthony Ricaud (:rik)]

https://github.com/mozilla-b2g/gaia/commit/de4a53efe95f84e7f658d832d39ba2046448c3c8

Comment 15

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/70c788c833993c4fa486ff3a6670726e75526c5e

Comment 16

[Lancy(Leave from Mozilla)]

Attachment: Verify_Video_Flame.MP4

This issue has been verified successfully on Flame 2.0 & 2.1.
See attachment: Verify_Video_Flame.MP4
Reproducing rate: 0/10

Flame v2.0 version:
Gaia-Rev        856863962362030174bae4e03d59c3ebbc182473
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/e40fe21e37f1
Build-ID        20141208000206
Version         32.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141208.035628
FW-Date         Mon Dec  8 03:56:38 EST 2014
Bootloader      L1TC00011880

Flame v2.1 version:
Gaia-Rev        38e17b0219cbc50a4ad6f51101898f89e513a552
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/8b92c4b8f59a
Build-ID        20141205001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141205.035305
FW-Date         Fri Dec  5 03:53:16 EST 2014
Bootloader      L1TC00011880