1019432 - [AccessFu] Zooming doesn't work with TalkBack enabled

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P1)

Description

[Kostadin Kolev]

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release)
Build ID: 20140506152807

Steps to reproduce:

1. Enable TalkBack from Settings -> Accessibility -> TalkBack.
2. Start Firefox and load a page in it (a one that could be zoomed in).
3. Try zooming in and out the loaded page, using 2 (or 3 if necessary) fingers.


Actual results:

Zooming doesn't work.


Expected results:

Zooming should work, even when TalkBack is enabled. If necessary - 3 finger gestures should be used to make it work.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Any thoughts on whether you want this supported, and what the user interaction would be like? IMO if you want to support zooming with accessibility enabled then it might be better to have desktop-style zoom (i.e. fixed zoom amounts) rather than the current mobile pinch-zoom.

Comment 2

[Eitan Isaacson [:eeejay]]

(In reply to Kostadin Kolev from comment #0)
> Zooming should work, even when TalkBack is enabled. If necessary - 3 finger
> gestures should be used to make it work.

Is this how you zoom in Chrome?

Comment 3

[Eitan Isaacson [:eeejay]]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #1)
> Any thoughts on whether you want this supported, and what the user
> interaction would be like? IMO if you want to support zooming with
> accessibility enabled then it might be better to have desktop-style zoom
> (i.e. fixed zoom amounts) rather than the current mobile pinch-zoom.

Yeah, we capture all touch events, so we may need to do something ourselves.

Comment 4

[Kostadin Kolev]

Yes, I want zooming to be supported even with TalkBack enabled. And YES - in Chrome, I place 3 fingers on the screen and move 1 of them away or towards the other 2 and that is how zooming in and out works.

Comment 5

[Eitan Isaacson [:eeejay]]

Great, thanks Kostadin. I agree this would be a great improvement, and also needed in Firefox OS.

I am refiling this as an AccessFu bug. We currently capture all touch events, and we will probably be implementing this on our end as opposed to passing this through in Android.

Thanks for putting this on our radar!

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Do we have any idea about how we want to track this bug? Just a +? Or do we want this to land sooner?

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

filter on [mass-p5]

Comment 8

[Wesley Johnston (:wesj)]

I have no idea why I assigned this to myself. From comment 5 it sounds like the accessibility people wanted it.

Comment 9

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Seems important – I'm going to renom.

Comment 10

[Richard Newman [:rnewman]]

Still happens?

Comment 11

[Kevin Brosnan [Ex-Mozilla]]

This still happens in nightly. Chrome allows zooming using the 2 finger pinch/pull gesture.

Comment 12

[Mark Finkle (:mfinkle) (use needinfo?)]

Mike - Can you take a look at how the Android Gestures are being handled? Might be a Java side issue, but could be an APZ issue too?

Comment 13

[Eitan Isaacson [:eeejay]]

Attachment: [AccessFu] Only capture explore by touch events in Android.

Comment 14

[Eitan Isaacson [:eeejay]]

We currently capture all touch/mouse events in order to support things like swipe navigation with TalkBack in ICS. The ICS share is shrinking, and it is not worth having that extra functionality for a small segment.

Note, removing this does not completely remove accessibility support for ICS, it just removes the extra features we had in order to make it suck a bit less than the rest of the platform..

Comment 15

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Thanks for grabbing this Eitan. If you need me to jump in again, NI me.

Comment 16

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8658454 [details] [diff] [review]
[AccessFu] Only capture explore by touch events in Android.

Review of attachment 8658454 [details] [diff] [review]:
-----------------------------------------------------------------

This is good stuff :)

Comment 17

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bb14c6b7a30b

Comment 18

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bb14c6b7a30b

Comment 19

[Liz Henry (:lizzard) (relman/hg->git project)]

Release Note Request (optional, but appreciated)
[Why is this notable]:  User facing improvements! Great. 
[Suggested wording]: Accessibility improvements for scrolling, zooming, and context menus in Talkback 
[Links (documentation, blog post, etc)]: http://blog.monotonous.org/2015/09/15/firefox-for-android-accessibility-refresh/

It seems good to me to describe this and several other bugs mentioned in the blog post, rolled up into one release note. 

If you have improvements for the release note wording, please comment and needinfo me. Thanks!

Comment 20

[Eitan Isaacson [:eeejay]]

The wording looks good, I would add braille:
Accessibility improvements for scrolling, zooming, braille, and context menus in Talkback 

Also, this relnote tag should probably be on the dependent bug 1182162 instead of this one.