[Collection App] Migrate data to vertical homescreen format

RESOLVED FIXED in Firefox OS v2.0

Status

Firefox OS
Gaia::Homescreen
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: crdlc, Assigned: crdlc)

Tracking

unspecified
2.0 S3 (6june)
All
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(b2g-v2.0 fixed)

Details

(Whiteboard: [systemsfe])

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
See bug 1018852 comment 4
(Assignee)

Updated

4 years ago
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Depends on: 1018852
(Assignee)

Updated

4 years ago
Whiteboard: [systemsfe]
(Assignee)

Comment 1

4 years ago
Created attachment 8433260 [details]
Github pull request

10x
Attachment #8433260 - Flags: review?(amirn)

Comment 2

4 years ago
I'm sorry Crisitian, but I now realized that `apps` are called `pinned`.

I will compile a home1->home2 mapping of field names later this week.
changing the scope of this bug to match bug 1018852 comment 4

thanks.
Flags: needinfo?(amirn)

Updated

4 years ago
Blocks: 1016203
Flags: needinfo?(amirn)
Summary: [Collection App] Rename providerId to categoryId → [Collection App] Migrate data to vertical homescreen format

Updated

4 years ago
Flags: needinfo?(amirn)
(Assignee)

Comment 3

4 years ago
ok, apps to pinned, right? any change more?

Comment 4

4 years ago
change (home1 -> home2):
bg -> background
experienceId -> categoryId
apps -> pinned (TODO migrate the objects to vertical homescreen items)
extraIconsData -> webicons


no-change:
name -> name
icon -> icon
defaultIcon -> defaultIcon
query -> query
Flags: needinfo?(amirn)
(Assignee)

Comment 5

4 years ago
experienceId or provider_id?

Comment 6

4 years ago
both:

(only exists for user created collections)  experienceId -> categoryId 
(only exists for pre-installed collections) provider_id -> categoryId

sorry.
(Assignee)

Comment 7

4 years ago
The homescreen had in its database

(In reply to Amir Nissim (Everything.me) from comment #4)
> change (home1 -> home2):
> bg -> background NO
> experienceId -> categoryId YES (see https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/js/grid_components.js#L106)
> apps -> pinned (TODO migrate the objects to vertical homescreen items) YES
> extraIconsData -> webicons NO
> 
> 
> no-change:
> name -> name YES
> icon -> icon YES
> defaultIcon -> defaultIcon NO
> query -> query NO
(Assignee)

Comment 8

4 years ago
and the path of icons was saved like

app://homescreen.gaiamobile.org/collections/social/icon.png

so should we change it to

app://collection.gaiamobile.org/collections/social/icon.png

right?
(Assignee)

Comment 9

4 years ago
Added categoryId, pinned and icon with the correct path to the PR. The homescreen hadn't info about bg, extraIconsData, defaultIcon nor query. Is it in some indexedDB of evme?
Target Milestone: --- → 2.0 S3 (6june)
(Assignee)

Comment 10

4 years ago
Done Amir, please you can review right now
Comment on attachment 8433260 [details]
Github pull request

added comments on GH.

didn't get a chance to test on device, but don't want to block you from making progress.

Thank you very much Cristian!
Attachment #8433260 - Flags: review?(amirn) → review+
(Assignee)

Comment 12

4 years ago
Merged in master:

https://github.com/mozilla-b2g/gaia/commit/c149fdc2235cbc8e800a43a30630b9559978ebe2
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Mass modify - set status-b2g-v2.0 fixed for fixed bugs under vertical homescreen dependency tree.
status-b2g-v2.0: --- → fixed
You need to log in before you can comment on or make changes to this bug.