Replace exposeAll in DOM browserelement-parent code with Cu.cloneInto

VERIFIED FIXED in mozilla32

Status

()

defect
VERIFIED FIXED
5 years ago
4 months ago

People

(Reporter: Gijs, Assigned: Gijs)

Tracking

Trunk
mozilla32
Points:
---
Dependency tree / graph
Bug Flags:
firefox-backlog +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: p=1 s=it-32c-31a-30b.3 [qa-])

Attachments

(1 attachment)

For more net code removal and speed bonuses (over manually, recursively, looping over objects etc.)

See:

http://mxr.mozilla.org/mozilla-central/ident?i=exposeAll
This passes all the browser-element tests for me locally, at least...
Attachment #8434093 - Flags: review?(bobbyholley)
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Hrm, looks like the test code uses this to expose entire interfaces, with methods, which you can't cloneInto, so morphing this bug to just focus on dom/browser-element/ for now. :-(
Summary: Replace exposeAll in DOM and specialpowers mock code with Cu.cloneInto → Replace exposeAll in DOM browserelement-parent code with Cu.cloneInto
Marco, can you add this to the current iteration please? Thanks!
Flags: needinfo?(mmucci)
Whiteboard: p=1 [qa-]
Added to Iteration 32.3
Flags: needinfo?(mmucci) → firefox-backlog+
Whiteboard: p=1 [qa-] → p=1 s=it-32c-31a-30b.3 [qa-]
Comment on attachment 8434093 [details] [diff] [review]
use Cu.cloneInto for browser elements instead of manually looping through objects and exposing them,

Review of attachment 8434093 [details] [diff] [review]:
-----------------------------------------------------------------

\o/
Attachment #8434093 - Flags: review?(bobbyholley) → review+
remote:   https://hg.mozilla.org/integration/fx-team/rev/e5306a36435b
Whiteboard: p=1 s=it-32c-31a-30b.3 [qa-] → [fixed-in-fx-team] p=1 s=it-32c-31a-30b.3 [qa-]
https://hg.mozilla.org/mozilla-central/rev/e5306a36435b
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team] p=1 s=it-32c-31a-30b.3 [qa-] → p=1 s=it-32c-31a-30b.3 [qa-]
Target Milestone: --- → mozilla32
Status: RESOLVED → VERIFIED
Blocks: 1021244
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.