Switch the browser-element API to Cu.exportFunction

RESOLVED FIXED in mozilla32

Status

()

Core
DOM
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Bobby Holley (parental leave - send mail for anything urgent), Assigned: Bobby Holley (parental leave - send mail for anything urgent))

Tracking

unspecified
mozilla32
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Gijs' patch in bug 1019643 unfortunately collided with Object Xrays during the merge, causing it to be backed out. The basic issue is that evt.detail is now a cloned content object, so we're not allowed to define cross-origin functions on it.

In the long term, if this API matures we'll probably want to use WebIDL. But for now, exportFunction lets us be safe without major code changes.
Created attachment 8435227 [details] [diff] [review]
Switch the browser-element API to Cu.exportFunction. v1
Attachment #8435227 - Flags: review?(amarchesini)
Comment on attachment 8435227 [details] [diff] [review]
Switch the browser-element API to Cu.exportFunction. v1

Review of attachment 8435227 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm
Attachment #8435227 - Flags: review?(amarchesini) → review+
https://tbpl.mozilla.org/?tree=Try&rev=7cc2e09b0e79
Depends on: 1021312
https://tbpl.mozilla.org/?tree=Try&rev=0872c62a17e2
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=8501686e4923

Comment 6

3 years ago
https://hg.mozilla.org/mozilla-central/rev/06e276460c5b
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.