Closed
Bug 1021244
Opened 11 years ago
Closed 11 years ago
Switch the browser-element API to Cu.exportFunction
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: bholley, Assigned: bholley)
References
Details
Attachments
(1 file)
3.37 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
Gijs' patch in bug 1019643 unfortunately collided with Object Xrays during the merge, causing it to be backed out. The basic issue is that evt.detail is now a cloned content object, so we're not allowed to define cross-origin functions on it.
In the long term, if this API matures we'll probably want to use WebIDL. But for now, exportFunction lets us be safe without major code changes.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #8435227 -
Flags: review?(amarchesini)
Comment 2•11 years ago
|
||
Comment on attachment 8435227 [details] [diff] [review]
Switch the browser-element API to Cu.exportFunction. v1
Review of attachment 8435227 [details] [diff] [review]:
-----------------------------------------------------------------
lgtm
Attachment #8435227 -
Flags: review?(amarchesini) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Assignee | ||
Comment 4•11 years ago
|
||
Assignee | ||
Comment 5•11 years ago
|
||
Comment 6•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•