1020010 - [flame][gallery] [video] fuzzy icons

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[Tiffanie Shakespeare [:tif]]

In the gallery and video apps on the Flame, the icons in the toolbars still appear to be fuzzy.

Comment 1

[Carol Huang [:Carol]]

Attachment: [e-mail]

Hi Pavel,
The attachment is the missing icons for "Video". Please update these files, thank you!!

Comment 2

[Helen Huang [:HHuang]]

Attachment: Gallery missing images.zip

Updated Gallery missing images which is based on Pavel's feedback.

In addition, some images named with tablet, for example:
./apps/gallery/style/images/ui/[e-mail]

and others image as below, those images are tablet only, no need various sizes.
./apps/gallery/style/images/fullscreen.png
./apps/gallery/style/images/player_mask.png
./apps/gallery/style/images/selection_mask_L.png
./apps/gallery/style/images/selection_mask_R.png
./apps/gallery/style/images/slider-background.png
./apps/gallery/style/images/video_pause_button_46x46.png
./apps/gallery/style/images/video_pause_pressed_46x46.png

Comment 3

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

Comment 4

[David Flanagan [:djf]]

Comment on attachment 8434109 [details] [review]
patch for Gaia/master

Punam,

Would you take this review for me, please? It looks like it just adding and replacing images, so it should be just a matter of trying out the apps with the new images and double-checking that there is a complete set of images in each of the sizes 1, 1.5, 2, and 2.25.

Comment 5

[Helen Huang [:HHuang]]

Attachment: Gallery revised images.zip

Update the revised @1/@2x images.

Just found that the style of some existing icons is outdated, please help to replace them, thank you.

Comment 6

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

PR is updated and also all images are compressed

Comment 7

[Punam Dahiya [:pdahiya]]

Comment on attachment 8434109 [details] [review]
patch for Gaia/master

Hi Pavel
I noticed new files in the patch that are not used in the code

 create mode 100644 apps/gallery/style/images/[e-mail]
 create mode 100644 apps/gallery/style/images/[e-mail]
 create mode 100644 apps/gallery/style/images/actionicon_gallery_edit_effect_30x30.png
 create mode 100644 apps/gallery/style/images/[e-mail]
 create mode 100644 apps/gallery/style/images/[e-mail]
 create mode 100644 apps/gallery/style/images/[e-mail]
 create mode 100644 apps/gallery/style/images/[e-mail]
 create mode 100644 apps/gallery/style/images/[e-mail]
 create mode 100644 apps/gallery/style/images/actionicon_gallery_edit_rotate_selected_30x30.png
 create mode 100644 apps/gallery/style/images/[e-mail]
 create mode 100644 apps/gallery/style/images/[e-mail]
 create mode 100644 apps/gallery/style/images/[e-mail]
 create mode 100644 apps/gallery/style/images/[e-mail]
 create mode 100644 apps/gallery/style/images/[e-mail]
 create mode 100644 apps/gallery/style/images/[e-mail]
 create mode 100644 apps/gallery/style/images/[e-mail]
 create mode 100644 apps/gallery/style/images/[e-mail]
 create mode 100644 apps/gallery/style/images/[e-mail]
 create mode 100644 apps/gallery/style/images/[e-mail]
 create mode 100644 apps/gallery/style/images/[e-mail]
 create mode 100644 apps/gallery/style/images/[e-mail]
 create mode 100644 apps/gallery/style/images/[e-mail]
 create mode 100644 apps/gallery/style/images/[e-mail]



In addition, 2.25x icon images are missing for few files in apps/gallery/style/images/ folder
e.g.
apps/gallery/style/images/[e-mail]
[e-mail]


actionicon_gallery_edit_effects_30x30.png  has missing 2 and 2.25x

Please check and fix the images for missing 2.25x

Below files in apps/video/style/images/ need 1.5, 2 and 2.5 images

apps/video/style/images/IconAction_Media_Pause_30x30.png
apps/video/style/images/IconAction_Media_Play_30x30.png
apps/video/style/images/IconAction_Media_SkipBackwards_30x30.png
apps/video/style/images/IconAction_Media_SkipForward_30x30.png


Thanks

Comment 8

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Hey Punam,
thanks for the info ... I will fix that

Hey Helen,
can you provide the missing images for: 
apps/video/style/images/IconAction_Media_Pause_30x30.png
apps/video/style/images/IconAction_Media_Play_30x30.png
apps/video/style/images/IconAction_Media_SkipBackwards_30x30.png
apps/video/style/images/IconAction_Media_SkipForward_30x30.png

Comment 9

[Helen Huang [:HHuang]]

Attachment: Gallery & Video updated images.zip

Hi Pavel,

I've updated the missing images for Gallery and Video, if any missing please let me know, thanks a lot!

Comment 10

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Comment on attachment 8434109 [details] [review]
patch for Gaia/master

Hey :) hope now everything is OK :)

Comment 11

[Punam Dahiya [:pdahiya]]

Comment on attachment 8434109 [details] [review]
patch for Gaia/master

Thanks Pavel, images in video looks good. I still see images in gallery that are unused and missing. 

Missing Images

Missing
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]


Unused images added in patch
 create mode 100644 apps/gallery/style/images/[e-mail]


Below images has missing 30x30 in filenames 
create mode 100644 apps/gallery/style/images/[e-mail]
 create mode 100644 apps/gallery/style/images/[e-mail]
 create mode 100644 apps/gallery/style/images/[e-mail]
 create mode 100644 apps/gallery/style/images/[e-mail]
 create mode 100644 apps/gallery/style/images/[e-mail]
 create mode 100644 apps/gallery/style/images/[e-mail]
 create mode 100644 apps/gallery/style/images/[e-mail]
 create mode 100644 apps/gallery/style/images/[e-mail]

Thanks

Comment 12

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Hey Thanks for the help

Helen it looks like we need a bunch of images for gallery ... I made a list but I saw that we have a lot of outdated images (with shadows) from version v1x of gaia ... AIK we don't use shadows on icons anymore ... can you check the list and also https://github.com/mozilla-b2g/gaia/tree/master/apps/gallery/style/images/ and ping me back when we have these images or info what we will do :)

we need following images:
===== specific versions =====
[e-mail]
actionicon_gallery_edit_rotate_30x30.png
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
slider-line.png
[e-mail]
[e-mail]
slider-marker.png
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]


===== versions 1.5, 2x, 2.25x =====
fullscreen_pressed.png
fullscreen.png
handle_pressed.png
options-background.png
player_mask.png
selection_mask_L.png
selection_mask_R.png
slider-bg.png
slider-indicator.png
tab_selected.png
tab.png
video_pause_button_46x46.png
video_pause_pressed_46x46.png



Thanks :)

Comment 13

[Helen Huang [:HHuang]]

Attachment: MIssing images_0612.zip

Hi Pavel,

Thanks for noticing. I've updated the missing images, please check it.
I found [e-mail] and [e-mail] have appeared twice in the list.

Some images are for tablet only:
handle_pressed.png
player_mask.png
selection_mask_L.png
selection_mask_R.png
slider-bg.png
slider-indicator.png
video_pause_button_46x46.png
video_pause_pressed_46x46.png

Can you help to check if we are using those images?
fullscreen_pressed.png
fullscreen.png

Thanks!

Comment 14

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Hey Helen,

Thanks :)

For the [e-mail] and [e-mail] is a copy paste mistake.
Yep we use these images `fullscreen_pressed.png` and `fullscreen.png`

Comment 15

[Helen Huang [:HHuang]]

Hi Pavel,

Thanks for helping. However I found that `fullscreen_pressed.png` and `fullscreen.png` are for tablet only, so they don't need other sizes images.

Comment 16

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

ok :) I already r? Thanks :)

Comment 17

[Punam Dahiya [:pdahiya]]

Comment on attachment 8434109 [details] [review]
patch for Gaia/master

Thanks Pavel, patch looks good and has my r+. 

I noticed apps/gallery/style/images/slider-marker.png file has it's 1.5x missing

With that added patch looks good to land.

Comment 18

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Helen can you help wit this 1.5x version?

Comment 19

[Helen Huang [:HHuang]]

Attachment: [e-mail]

Hi! I' ve updated [e-mail]. Sorry for missing this one.

Comment 20

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Thanks :)

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/90e9a17245de09120f31788ad7fe842836ffe11a

Comment 21

[Tiffanie Shakespeare [:tif]]

Hey Pavel - I've got the latest from Master on my Flame. Looking at video and gallery, the icons still don't seem crisp. Especially when you compare the video play screen to the preview screen in camera.

Comment 22

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Hey Tiffanie,
can you attach few shots and Helen and I will take a look. Thanks :)

Comment 23

[Tiffanie Shakespeare [:tif]]

Attachment: gallery

Looks like something must have landed - updated to Master again today and all the icons look crisp! 

The only one that "feels" weird is the back arrow when looking at a photo/video in Gallery - it seems bigger than it should be? I don't know how to go back a build to make the comparison. I've attached a screenshot.

Flame
Gaia      ccd70903544486bea04e85d8a4aacf63f1de2a72
Gecko     https://hg.mozilla.org/mozilla-central/rev/bdac18bd6c74
BuildID   20140620040204
Version   33.0a1

Comment 24

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: shot

Should be like this one, right?

Comment 25

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

Tiffanie found that the Back button in Gallery looks bigger ... it's a one line patch.

Comment 26

[Tiffanie Shakespeare [:tif]]

ya you got it - thanks for finding the issue and fixing! :)

Comment 27

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Sure :) no problem :)

Comment 28

[Punam Dahiya [:pdahiya]]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #25)
> Created attachment 8443733 [details] [review]
> patch for Gaia/master
> 
> Tiffanie found that the Back button in Gallery looks bigger ... it's a one
> line patch.

Thanks Pavel for the fix. I tested on flame in m-c build Id: 20140608040204, and the back button looks bigger and not related to patch landed in #comment 20.

Can you pl. attach fix for bigger back button for high resolution devices as a separate bug so that its easier to track and test. Thanks

Comment 29

[Punam Dahiya [:pdahiya]]

Hi Pavel,
I have created bug 1029382 for tracking back arrow button size fix. Please feel free to set review flag for me in 1029382 for the proposed fix. Thanks

Punam