Closed Bug 1020010 Opened 10 years ago Closed 10 years ago

[flame][gallery] [video] fuzzy icons

Categories

(Firefox OS Graveyard :: Gaia::Gallery, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: tif, Assigned: pivanov)

References

Details

Attachments

(9 files, 1 obsolete file)

In the gallery and video apps on the Flame, the icons in the toolbars still appear to be fuzzy.
Blocks: 1016987
Attached file Video_@2x.zip
Hi Pavel,
The attachment is the missing icons for "Video". Please update these files, thank you!!
Flags: needinfo?(pivanov)
Updated Gallery missing images which is based on Pavel's feedback.

In addition, some images named with tablet, for example:
./apps/gallery/style/images/ui/tablet_button_separator@1.5x.png

and others image as below, those images are tablet only, no need various sizes.
./apps/gallery/style/images/fullscreen.png
./apps/gallery/style/images/player_mask.png
./apps/gallery/style/images/selection_mask_L.png
./apps/gallery/style/images/selection_mask_R.png
./apps/gallery/style/images/slider-background.png
./apps/gallery/style/images/video_pause_button_46x46.png
./apps/gallery/style/images/video_pause_pressed_46x46.png
Attached file patch for Gaia/master
Attachment #8434109 - Flags: review?(dflanagan)
Flags: needinfo?(pivanov)
Comment on attachment 8434109 [details] [review]
patch for Gaia/master

Punam,

Would you take this review for me, please? It looks like it just adding and replacing images, so it should be just a matter of trying out the apps with the new images and double-checking that there is a complete set of images in each of the sizes 1, 1.5, 2, and 2.25.
Attachment #8434109 - Flags: review?(dflanagan) → review?(pdahiya)
Update the revised @1/@2x images.

Just found that the style of some existing icons is outdated, please help to replace them, thank you.
Flags: needinfo?(pivanov)
PR is updated and also all images are compressed
Flags: needinfo?(pivanov)
Comment on attachment 8434109 [details] [review]
patch for Gaia/master

Hi Pavel
I noticed new files in the patch that are not used in the code

 create mode 100644 apps/gallery/style/images/actionicon_camera@2.25x.png
 create mode 100644 apps/gallery/style/images/actionicon_camera@2x.png
 create mode 100644 apps/gallery/style/images/actionicon_gallery_edit_effect_30x30.png
 create mode 100644 apps/gallery/style/images/actionicon_gallery_edit_effect_30x30@1.5x.png
 create mode 100644 apps/gallery/style/images/actionicon_gallery_edit_effect_30x30@2x.png
 create mode 100644 apps/gallery/style/images/actionicon_gallery_edit_rotate@2xpng.png
 create mode 100644 apps/gallery/style/images/actionicon_gallery_edit_rotate_30x30@1.5x.png
 create mode 100644 apps/gallery/style/images/actionicon_gallery_edit_rotate_selected@2xpng.png
 create mode 100644 apps/gallery/style/images/actionicon_gallery_edit_rotate_selected_30x30.png
 create mode 100644 apps/gallery/style/images/actionicon_gallery_edit_rotate_selected_30x30@1.5x.png
 create mode 100644 apps/gallery/style/images/actionicon_media_info@2.25x.png
 create mode 100644 apps/gallery/style/images/actionicon_media_pause@2.25x.png
 create mode 100644 apps/gallery/style/images/actionicon_media_pause@2x.png
 create mode 100644 apps/gallery/style/images/actionicon_media_play@2.25x.png
 create mode 100644 apps/gallery/style/images/actionicon_media_playcirbtn@2.25x.png
 create mode 100644 apps/gallery/style/images/actionicon_media_playcirbtn@2x.png
 create mode 100644 apps/gallery/style/images/actionicon_misc_edit_image@2.25x.png
 create mode 100644 apps/gallery/style/images/actionicon_misc_gridview@2.25x.png
 create mode 100644 apps/gallery/style/images/actionicon_misc_undo@2.25x.png
 create mode 100644 apps/gallery/style/images/actionicon_misc_undo@2x.png
 create mode 100644 apps/gallery/style/images/iconaction_delete@2.25x.png
 create mode 100644 apps/gallery/style/images/iconaction_delete@2x.png
 create mode 100644 apps/gallery/style/images/iconaction_done@2.25x.png



In addition, 2.25x icon images are missing for few files in apps/gallery/style/images/ folder
e.g.
apps/gallery/style/images/back@2.25x.png
iconaction_camera_editphoto_30x30@2.25x.png


actionicon_gallery_edit_effects_30x30.png  has missing 2 and 2.25x

Please check and fix the images for missing 2.25x

Below files in apps/video/style/images/ need 1.5, 2 and 2.5 images

apps/video/style/images/IconAction_Media_Pause_30x30.png
apps/video/style/images/IconAction_Media_Play_30x30.png
apps/video/style/images/IconAction_Media_SkipBackwards_30x30.png
apps/video/style/images/IconAction_Media_SkipForward_30x30.png


Thanks
Attachment #8434109 - Flags: review?(pdahiya) → review-
Hey Punam,
thanks for the info ... I will fix that

Hey Helen,
can you provide the missing images for: 
apps/video/style/images/IconAction_Media_Pause_30x30.png
apps/video/style/images/IconAction_Media_Play_30x30.png
apps/video/style/images/IconAction_Media_SkipBackwards_30x30.png
apps/video/style/images/IconAction_Media_SkipForward_30x30.png
Flags: needinfo?(hhuang)
Hi Pavel,

I've updated the missing images for Gallery and Video, if any missing please let me know, thanks a lot!
Flags: needinfo?(hhuang)
Assignee: nobody → pivanov
Comment on attachment 8434109 [details] [review]
patch for Gaia/master

Hey :) hope now everything is OK :)
Attachment #8434109 - Flags: review- → review?(pdahiya)
Comment on attachment 8434109 [details] [review]
patch for Gaia/master

Thanks Pavel, images in video looks good. I still see images in gallery that are unused and missing. 

Missing Images

Missing
actionicon_gallery_edit_effects_30x30@1.5x.png
iconaction_camera_30x30@2.25x.png
iconaction_camera_gridview_30x30@2.25x.png
iconaction_delete_30x30@2.25x.png
iconaction_done_30x30@2.25x.png
iconaction_media_info_30x30@2.25x.png
iconaction_select_30x30@2.25x.png
iconaction_share_30x30@2.25x.png
iconaction_undo_30x30@2.25x.png
play@2.25x.png
progress@2.25x.png
slider-scrubber-active@2x.png
spinner@2.25x.png
slider-background@1.5x.png
slider-background@2x.png
slider-marker@2x.png
slider-scrubber@2x.png
slider-scrubber-active@2x.png


Unused images added in patch
 create mode 100644 apps/gallery/style/images/actionicon_gallery_edit_effects_selected_30x30@2x.png


Below images has missing 30x30 in filenames 
create mode 100644 apps/gallery/style/images/iconaction_camera_crop1x1@2.25x.png
 create mode 100644 apps/gallery/style/images/iconaction_camera_crop1x1@2x.png
 create mode 100644 apps/gallery/style/images/iconaction_camera_crop2x3@2.25x.png
 create mode 100644 apps/gallery/style/images/iconaction_camera_crop2x3@2x.png
 create mode 100644 apps/gallery/style/images/iconaction_camera_crop3x2@2.25x.png
 create mode 100644 apps/gallery/style/images/iconaction_camera_crop3x2@2x.png
 create mode 100644 apps/gallery/style/images/iconaction_camera_freecrop@2.25x.png
 create mode 100644 apps/gallery/style/images/iconaction_camera_freecrop@2x.png

Thanks
Attachment #8434109 - Flags: review?(pdahiya) → review-
Hey Thanks for the help

Helen it looks like we need a bunch of images for gallery ... I made a list but I saw that we have a lot of outdated images (with shadows) from version v1x of gaia ... AIK we don't use shadows on icons anymore ... can you check the list and also https://github.com/mozilla-b2g/gaia/tree/master/apps/gallery/style/images/ and ping me back when we have these images or info what we will do :)

we need following images:
===== specific versions =====
actionicon_gallery_edit_effects_30x30@1.5x.png
actionicon_gallery_edit_rotate_30x30.png
iconaction_camera_30x30@2.25x.png
iconaction_camera_gridview_30x30@2.25x.png
iconaction_delete_30x30@2.25x.png
iconaction_done_30x30@2.25x.png
iconaction_media_info_30x30@2.25x.png
iconaction_select_30x30@2.25x.png
iconaction_share_30x30@2.25x.png
iconaction_undo_30x30@2.25x.png
play@2.25x.png
progress@2.25x.png
slider-scrubber-active@2x.png
spinner@2.25x.png
slider-background@1.5x.png
slider-background@2x.png
slider-line.png
slider-line@1.5x.png
slider-line@2x.png
slider-marker.png
slider-marker@2x.png
slider-scrubber@2x.png
slider-scrubber-active@2x.png
spinner@2.25x.png
video_pause_button@2.25x.png
gradient@2x.png
gradient@2.25x.png


===== versions 1.5, 2x, 2.25x =====
fullscreen_pressed.png
fullscreen.png
handle_pressed.png
options-background.png
player_mask.png
selection_mask_L.png
selection_mask_R.png
slider-bg.png
slider-indicator.png
tab_selected.png
tab.png
video_pause_button_46x46.png
video_pause_pressed_46x46.png



Thanks :)
Flags: needinfo?(hhuang)
Hi Pavel,

Thanks for noticing. I've updated the missing images, please check it.
I found Spinner@2.25x.png and slider-scrubber-active@2x.png have appeared twice in the list.

Some images are for tablet only:
handle_pressed.png
player_mask.png
selection_mask_L.png
selection_mask_R.png
slider-bg.png
slider-indicator.png
video_pause_button_46x46.png
video_pause_pressed_46x46.png

Can you help to check if we are using those images?
fullscreen_pressed.png
fullscreen.png

Thanks!
Flags: needinfo?(hhuang) → needinfo?(pivanov)
Hey Helen,

Thanks :)

For the Spinner@2.25x.png and slider-scrubber-active@2x.png is a copy paste mistake.
Yep we use these images `fullscreen_pressed.png` and `fullscreen.png`
Flags: needinfo?(pivanov)
Attachment #8434109 - Flags: review- → review?(pdahiya)
Hi Pavel,

Thanks for helping. However I found that `fullscreen_pressed.png` and `fullscreen.png` are for tablet only, so they don't need other sizes images.
ok :) I already r? Thanks :)
Comment on attachment 8434109 [details] [review]
patch for Gaia/master

Thanks Pavel, patch looks good and has my r+. 

I noticed apps/gallery/style/images/slider-marker.png file has it's 1.5x missing

With that added patch looks good to land.
Attachment #8434109 - Flags: review?(pdahiya) → review+
Helen can you help wit this 1.5x version?
Flags: needinfo?(hhuang)
Attached image slider-marker@1.5x.png
Hi! I' ve updated slider-marker@1.5x.png. Sorry for missing this one.
Flags: needinfo?(hhuang) → needinfo?(pivanov)
Thanks :)

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/90e9a17245de09120f31788ad7fe842836ffe11a
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: needinfo?(pivanov)
Resolution: --- → FIXED
Hey Pavel - I've got the latest from Master on my Flame. Looking at video and gallery, the icons still don't seem crisp. Especially when you compare the video play screen to the preview screen in camera.
Flags: needinfo?(pivanov)
Hey Tiffanie,
can you attach few shots and Helen and I will take a look. Thanks :)
Flags: needinfo?(pivanov) → needinfo?(tshakespeare)
Attached image gallery
Looks like something must have landed - updated to Master again today and all the icons look crisp! 

The only one that "feels" weird is the back arrow when looking at a photo/video in Gallery - it seems bigger than it should be? I don't know how to go back a build to make the comparison. I've attached a screenshot.

Flame
Gaia      ccd70903544486bea04e85d8a4aacf63f1de2a72
Gecko     https://hg.mozilla.org/mozilla-central/rev/bdac18bd6c74
BuildID   20140620040204
Version   33.0a1
Flags: needinfo?(tshakespeare) → needinfo?(pivanov)
Attached image shot
Should be like this one, right?
Flags: needinfo?(pivanov) → needinfo?(tshakespeare)
Attached file patch for Gaia/master (obsolete) —
Tiffanie found that the Back button in Gallery looks bigger ... it's a one line patch.
Attachment #8443733 - Flags: review?(pdahiya)
ya you got it - thanks for finding the issue and fixing! :)
Flags: needinfo?(tshakespeare)
Sure :) no problem :)
(In reply to Pavel Ivanov [:ivanovpavel] from comment #25)
> Created attachment 8443733 [details] [review]
> patch for Gaia/master
> 
> Tiffanie found that the Back button in Gallery looks bigger ... it's a one
> line patch.

Thanks Pavel for the fix. I tested on flame in m-c build Id: 20140608040204, and the back button looks bigger and not related to patch landed in #comment 20.

Can you pl. attach fix for bigger back button for high resolution devices as a separate bug so that its easier to track and test. Thanks
Flags: needinfo?(pivanov)
Attachment #8443733 - Flags: review?(pdahiya)
Hi Pavel,
I have created bug 1029382 for tracking back arrow button size fix. Please feel free to set review flag for me in 1029382 for the proposed fix. Thanks

Punam
Attachment #8443733 - Attachment is obsolete: true
Flags: needinfo?(pivanov)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: