1029382 - [Gallery] [Flame]- Back arrow button shows too large in high resolution devices.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[Punam Dahiya [:pdahiya]]

In high resolution devices such as Flame, while viewing images in gallery, back arrow button shows too large. See https://bugzilla.mozilla.org/show_bug.cgi?id=1020010#c23

Pavel has proposed fix for this issue in Bug 1020010, opening this bug to track back arrow button size fix.

Comment 1

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

Comment 2

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Comment on attachment 8445030 [details] [review]
patch for Gaia/master

https://github.com/mozilla-b2g/gaia/pull/20923

Comment 3

[Punam Dahiya [:pdahiya]]

Comment on attachment 8445030 [details] [review]
patch for Gaia/master

Thanks Pavel. Patch looks good and has my r+. It's safe to carry over ui-review by tif for 1.5 device from https://bugzilla.mozilla.org/show_bug.cgi?id=1020010#c26

An extra ui-review check that might be good is to look at back button in 2x and 2.5x device but i don't have one :(. 
Tif, if you have 2, 2.5x device can you please check or else we can request QA to attach screen shot for ui-review. Thanks

Comment 4

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

I also don't have @2x or @2.25x device ... it will be good if we can test this patch on these devices

Comment 5

[Tiffanie Shakespeare [:tif]]

I only have the Flame, we should ask QA to take some screenshots for us.

Comment 6

[Punam Dahiya [:pdahiya]]

Setting qawanted flag to get the screen shot of back arrow button - while viewing full screen images in gallery, on @2x , @2.25x devices

Setting NI for Pavel as attached PR https://github.com/mozilla-b2g/gaia/pull/20825 is closed without merging with master.

Comment 7

[Punam Dahiya [:pdahiya]]

(In reply to Punam Dahiya from comment #6)
> Setting qawanted flag to get the screen shot of back arrow button - while
> viewing full screen images in gallery, on @2x , @2.25x devices
> 
screen shot of back arrow button with the patch for ui-review on @2x, @2.5x devices

Comment 8

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

Sorry mess the PRs

Comment 9

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Thanks,

I will merge that and if there are some problems with @2x and @2.25x I will provide a patch

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/d4c509040da5f0c39d1192873c3c854960527ab2