1020095 - [Flame] Keyboard sticks on screen after leaving layout switcher

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Input Mgmt, defect)

Description

[Evelyn Hung]

STR:
1. focus on an input field and a keyboard layout shows
2. drag down utility tray and click on layout switcher
3. dismiss the 'Select' dialog displayed by layout switcher, then you will be brought back to the original input field

Expected Result:
the input field is still focused, and you can unfocus it to hide keyboard

Actual Result:
the input field lost focus but keyboard is still there, so there is not mean to hide keyboard.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I wonder if this is a regression of bug 1018590 ... will confirm that.

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Yes. The bug is gone after I revert the patch.

Comment 3

[Mozilla Shepherd (This account is used for automation and doesn't receive bugmail)]

Attachment: mozilla-b2g:master PR#19979

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8433875 [details] [review]
mozilla-b2g:master PR#19979

Rudy, can this review cut in line since this is a blocking regression?

The proper fix of this bug should be moving the IMESwitcher controller to another module and properly cover it with tests, but for 2.0 I think this is the sensible thing to do instead.

Comment 5

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8433875 [details] [review]
mozilla-b2g:master PR#19979

Yes, this patch could fix this issue.
However, I found another issue which might also be related to the same regression bug, bug 1018590.

STR
===
1. Launch keyboard.
2. use IME switching function in utility tray to switch to demo-keyboard (another app).
3. switching back to built-in keyboard again.
   => Found that cannot switch back.

Please let me know if I need to take over this bug to address the above issue.

Thanks.

Comment 6

[Mozilla Shepherd (This account is used for automation and doesn't receive bugmail)]

Attachment: mozilla-b2g:master PR#19986

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8433948 [details] [review]
mozilla-b2g:master PR#19986

Thanks for catching the problem. How about this?

Comment 8

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8433948 [details] [review]
mozilla-b2g:master PR#19986

r=me with the comment addressed.

Tim, thanks.

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master: https://github.com/mozilla-b2g/gaia/commit/877c2fd081c4fba46ba56b87705cb40296ef20ec