1020134 - Add backgrounds to pre-defined collections

Status: RESOLVED DUPLICATE of bug 1016221

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Comment 1

[Cristian Rodriguez (:crdlc)]

Attachment: Github pull request

10x

Comment 2

[Amir Nissim (:amirn)]

Comment on attachment 8433955 [details]
Github pull request

This is just adding the assets right? (no functionality)

Comment 3

[Amir Nissim (:amirn)]

maybe change 'collection/collections/' to 'collection/presets/' ?

Comment 4

[Cristian Rodriguez (:crdlc)]

yes, it is out of the scope of this bug, once implemented all bugs, this kind of changes could be performed

Comment 5

[Cristian Rodriguez (:crdlc)]

Merged in master:

https://github.com/mozilla-b2g/gaia/commit/ad3fd209ffed635bdc650e400687514258e3860e

Comment 6

[Cristian Rodriguez (:crdlc)]

Backout:

https://github.com/crdlc/gaia/commit/ad83bab6e5fd681548e3915a41dff4f8378a7793

Comment 7

[Cristian Rodriguez (:crdlc)]

See bug 960720 comment 22

Comment 8

[Kevin Grandon :kgrandon]

I'm going to block bug 960720 on this, as this is not a blocking bug, and not certain if we can include it in 2.0 yet. Let's revisit this in the future once everything else is done. Thanks.