Closed
Bug 1020213
Opened 10 years ago
Closed 10 years ago
[NFC] javascript error when send image/video via NFC
Categories
(Firefox OS Graveyard :: NFC, defect)
Tracking
(b2g-v2.0 fixed)
RESOLVED
FIXED
2.0 S3 (6june)
| Tracking | Status | |
|---|---|---|
| b2g-v2.0 | --- | fixed |
People
(Reporter: dimi, Assigned: dimi)
References
Details
Attachments
(1 file)
"let is a reserved identifier" javascript error show up when send image/video via NFC
|
Assignee | |
Updated•10 years ago
|
Summary: [NFC ] javascript errors when send image/video via NFC → [NFC ] javascript error when send image/video via NFC
|
|
Assignee | |
Updated•10 years ago
|
Summary: [NFC ] javascript error when send image/video via NFC → [NFC] javascript error when send image/video via NFC
|
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8434040 -
Flags: review?(alive)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8434040 [details] [review]
pull request to mozilla-b2g/gaia v1
My fault not catching this :( thanks!
Attachment #8434040 -
Flags: review?(alive) → review+
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
||
Comment 3•10 years ago
|
||
I'm really confused - I merged the pull request, but the resulting commit looks empty?
Master: https://github.com/mozilla-b2g/gaia/commit/2cf60d47415ee7d3bcbaf799a3dae38b89229bc5
Flags: needinfo?(dlee)
Keywords: checkin-needed
|
|
||
Comment 5•10 years ago
|
||
Oh, this was apparently already landed. Please update the bug in the future so you don't waste people's time?
Master: https://github.com/mozilla-b2g/gaia/commit/6956b58490a20472bc9de302e0dfa55e1b2f0ea8#diff-7ba38d6949d3b228ce9433ce9cb1595f
|
||
Comment 6•10 years ago
|
||
I've fixed this already in https://bugzilla.mozilla.org/show_bug.cgi?id=1020549 -> https://github.com/mozilla-b2g/gaia/commit/ac47da8f463aabcbf7d93aa76e3d517753d02302.
Sorry for even introducing this bug. Does anyone know why both unit tests and Travis were passing?
|
|
Assignee | |
Updated•10 years ago
|
Flags: needinfo?(dlee)
You need to log in
before you can comment on or make changes to this bug.
Description
•