Closed Bug 1020460 Opened 6 years ago Closed 6 years ago

Array.prototype.toSource should be generic

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33
Tracking Status
firefox32 --- fixed
firefox33 --- fixed

People

(Reporter: bholley, Assigned: bholley)

References

Details

Attachments

(1 file, 1 obsolete file)

Spoke with jorendorff about this on IRC. There's no reason for it to be non-generic, and having it be so makes this less safe for Xrays. Patch coming up.
Attachment #8434295 - Flags: review?(jorendorff)
No longer blocks: 987163
Blocks: 1020609
Needed to fix a test.
Attachment #8434295 - Attachment is obsolete: true
Attachment #8434295 - Flags: review?(jorendorff)
Attachment #8434573 - Flags: review?(jorendorff)
Comment on attachment 8434573 [details] [diff] [review]
Array.prototype.toSource should be generic. v2

Review of attachment 8434573 [details] [diff] [review]:
-----------------------------------------------------------------

Please throw in some trivial tests for applying this toSource method to non-array objects. (I don't care what the output is, as long as we don't crash.)
Attachment #8434573 - Flags: review?(jorendorff) → review+
https://hg.mozilla.org/mozilla-central/rev/e54cc67cf015
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.