Array.prototype.toSource should be generic

RESOLVED FIXED in Firefox 32

Status

()

Core
JavaScript Engine
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: bholley, Assigned: bholley)

Tracking

unspecified
mozilla33
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(firefox32 fixed, firefox33 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
Spoke with jorendorff about this on IRC. There's no reason for it to be non-generic, and having it be so makes this less safe for Xrays. Patch coming up.
(Assignee)

Comment 1

4 years ago
Created attachment 8434295 [details] [diff] [review]
Array.prototype.toSource should be generic. v1
Attachment #8434295 - Flags: review?(jorendorff)
(Assignee)

Updated

4 years ago
No longer blocks: 987163
(Assignee)

Updated

4 years ago
Blocks: 1020609
(Assignee)

Comment 2

4 years ago
Created attachment 8434573 [details] [diff] [review]
Array.prototype.toSource should be generic. v2

Needed to fix a test.
Attachment #8434295 - Attachment is obsolete: true
Attachment #8434295 - Flags: review?(jorendorff)
Attachment #8434573 - Flags: review?(jorendorff)
Comment on attachment 8434573 [details] [diff] [review]
Array.prototype.toSource should be generic. v2

Review of attachment 8434573 [details] [diff] [review]:
-----------------------------------------------------------------

Please throw in some trivial tests for applying this toSource method to non-array objects. (I don't care what the output is, as long as we don't crash.)
Attachment #8434573 - Flags: review?(jorendorff) → review+

Comment 7

4 years ago
https://hg.mozilla.org/mozilla-central/rev/e54cc67cf015
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
https://hg.mozilla.org/releases/mozilla-aurora/rev/12161a842a8e
status-firefox32: --- → fixed
status-firefox33: --- → fixed
You need to log in before you can comment on or make changes to this bug.