Closed
Bug 1020525
Opened 11 years ago
Closed 11 years ago
The checkbox for the telemetry prompt in the FTU appears in the middle of the screen
Categories
(Firefox OS Graveyard :: Gaia::First Time Experience, defect)
Tracking
(b2g-v2.2 verified)
VERIFIED
FIXED
Tracking | Status | |
---|---|---|
b2g-v2.2 | --- | verified |
People
(Reporter: ehsan.akhgari, Assigned: pivanov)
References
Details
Attachments
(3 files)
No description provided.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → pivanov
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #8449732 -
Flags: feedback?(nefzaoui.ahmed)
Comment 2•11 years ago
|
||
Comment on attachment 8449732 [details] [review]
patch for Gaia/master
Perfect! Just a little nit I commented for you on in your patch :)
Thanks!
Attachment #8449732 -
Flags: feedback?(nefzaoui.ahmed) → feedback+
Assignee | ||
Updated•11 years ago
|
Attachment #8449732 -
Flags: review?(fernando.campo)
Comment 3•11 years ago
|
||
Comment on attachment 8449732 [details] [review]
patch for Gaia/master
Looks nice, but please for future bugs like this (UI), please provide a screenshot of the bug, and a screenshot after the fix, it would help on evaluating the patch.
Also, a nit for the patch, remove extra line at the end of the file.
Thanks for fixing it.
Attachment #8449732 -
Flags: review?(fernando.campo) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Thanks Fernando,
I will :)
Landed to master:
https://github.com/mozilla-b2g/gaia/commit/3dba671ab090f66f283d71d97b52816ce96958be
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Unable to verify the fix on 2.2 and 2.1,
Telemetry page is not localized and not adopted for RTL language (See screenshot)
The checkmark is displayed on the right side
Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141204040202
Gaia: 984e6d79aa799d2695f9ca132dfdc1665a56c019
Gecko: a9fc46355661
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 37.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
Device: Flame 2.1 (319mb)(KitKat)(Full Flash)
BuildID: 20141204001201
Gaia: 5655269098c7e82254e56933f1af05b4abe2a2f3
Gecko: 86608c9389b5
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 34.0 (2.1)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
QA Whiteboard: [QAnalyst-Triage?][QAnalyst-verify-]
Flags: needinfo?(ktucker)
Verification is failed on 2.2 Flame, according to the patch "check-box" should be on the left side, but it displays on the right side, opened a bug 1108697
"Flame 2.2
Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141208040202
Gaia: 0e429d970c160e580e19e61ad8ff5612de159f00
Gecko: c4c7442e9113
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 37.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0"
QA Whiteboard: [QAnalyst-Triage?][QAnalyst-verify-] → [QAnalyst-Triage?][failed-verification]
Depends on: 1108697
Updated•11 years ago
|
QA Whiteboard: [QAnalyst-Triage?][failed-verification] → [QAnalyst-Triage+][failed-verification]
Flags: needinfo?(ktucker)
Updated•11 years ago
|
QA Whiteboard: [QAnalyst-Triage+][failed-verification] → [QAnalyst-Triage+][failed-verification][rtl-impact]
Whiteboard: [rtl-meta]
Updated•10 years ago
|
This issue Verified successfully on flame 2.2
Gaia-Rev f5b3d1b6cfa3e702033f613915ae637cb735cbfb
Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/5d7497ce4cc7
Build-ID 20150120002507
Version 37.0a2
Device-Name flame
FW-Release 4.4.2
Refer to picture 2015-01-21-14-02-53.png
Comment 10•10 years ago
|
||
Comment 11•10 years ago
|
||
Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15507/
Flags: in-moztrap+
Updated•10 years ago
|
QA Whiteboard: [QAnalyst-Triage+][failed-verification][rtl-impact] → [QAnalyst-Triage+][rtl-impact]
You need to log in
before you can comment on or make changes to this bug.
Description
•