1020558 - Add Involved with Bugs and Never Visited Query to MyDashboard

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: MyDashboard, defect, P2)

Description

[Bobby Holley (:bholley)]

If someone CCs me on a bug, it never shows up on the dashboard until I view it. This makes the dashboard significantly less useful as a bugmail replacement.

Comment 1

[(no longer active)]

Bobby's suggestion was to set the last visited timestamp for the person being CCed to something in the past to make the bug appear on their dashboard which makes sense to me.

Comment 2

[Dylan Hardison [:dylan] (he/him)]

I think we could just do a custom query to search "bugs cc'd on" and "last changed great than ..." (something that is already possible with custom search and unrelated to the new last_visit feature.

Comment 3

[Dylan Hardison [:dylan] (he/him)]

Actually, there is a query called "Bugs You Are CC'd On" and you can sort that by the Updated column.

Comment 4

[(no longer active)]

(In reply to comment #3)
> Actually, there is a query called "Bugs You Are CC'd On" and you can sort that
> by the Updated column.

Yes, but the issue is that query is mostly uses for folks such as myself who have been CCed on thousands of bugs...

Also, you could search on %last_changed% separately too, right?  I would expect the set of bugs in comment 0 to be included in those results.

Comment 5

[Mark Côté [:mcote]]

I believe the fundamental request is to treat "becoming involved with a bug"--reporting, getting assigned, becoming qa contact, or getting cced--as visiting the bug, and thus the event should be inserted into the last-visited table.  This is similar to bug 1020023, except the action may be performed by someone else.

Comment 6

[Dylan Hardison [:dylan] (he/him)]

As discussed in the b-team meeting, perhaps we should provide a "Involved Bugs That Have Never Been Visited" query. This would be all bugs that you have reported, been assigned, became qa contact, or got cced on. As the number of bugs that this would be true for would be very large, we could provide some mechanism (button/link) to "mark all these bugs as visited".

Comment 7

[Dylan Hardison [:dylan] (he/him)]

Would an "Involved With and Never Visited" query meet your needs for this feature?

See comment #6. Thanks!

Comment 8

[Bobby Holley (:bholley)]

(In reply to Dylan William Hardison [:dylan] from comment #7)
> Would an "Involved With and Never Visited" query meet your needs for this
> feature?
> 
> See comment #6. Thanks!

I think so, yes.

Comment 9

[Dylan Hardison [:dylan] (he/him)]

Adding this query will mean implementing the logic for "is involved in bug" in the SQL query.
If we simply search for "every bug never visited" and then do the "is involved with" check in perl... that would be bad.

Comment 10

[Dylan Hardison [:dylan] (he/him)]

Attachment: bug-1020558-v1.patch

Right, totally forgot how simple the queries in MyDashboard were. I also forgot that we get an "is empty" operator.

The only thing I'm not sure of is how to make the qa contact search term optional. Would it require renumbering the search terms?

Comment 11

[:glob ✱]

(In reply to Dylan William Hardison [:dylan] from comment #10)
> The only thing I'm not sure of is how to make the qa contact search term
> optional. Would it require renumbering the search terms?

why does the qa-contact search term need to be optional?

Comment 12

[Dylan Hardison [:dylan] (he/him)]

The code below lead me to believe that it did, although it didn't make sense.

extensions/MyDashboard/lib/Queries.pm:

    if (Bugzilla->params->{'useqacontact'}) {
        push(@query_defs, {
            name        => 'qacontactbugs',
            heading     => 'You Are QA Contact',
            description => 'You are the qa contact on this bug, and it is not resolved or closed.',
            params      => {
                'bug_status'       => ['__open__'],
                'emailqa_contact1' => 1,
                'emailtype1'       => 'exact',
                'email1'           => $user->login
            }
        });
    }

Comment 13

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8484751 [details] [diff] [review]
bug-1020558-v1.patch

For review

Comment 14

[:glob ✱]

Comment on attachment 8484751 [details] [diff] [review]
bug-1020558-v1.patch

Review of attachment 8484751 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob

Comment 15

[Dylan Hardison [:dylan] (he/him)]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   cf7ddf8..34cc540  master -> master