Closed
Bug 1020695
Opened 9 years ago
Closed 9 years ago
Update Mozilla 32 to use NSS 3.16.2 (once it's ready)
Categories
(Core :: Security: PSM, defect, P1)
Core
Security: PSM
Tracking
()
People
(Reporter: wtc, Assigned: wtc)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file, 1 obsolete file)
44 bytes,
text/plain
|
wtc
:
review+
abillings
:
approval-mozilla-aurora+
abillings
:
approval-mozilla-beta+
abillings
:
approval-mozilla-esr24+
|
Details |
This bug is used for landing NSS 3.16.2 Beta and RTM tags in mozilla-inbound and mozilla-central.
Assignee | ||
Comment 1•9 years ago
|
||
Pushed NSS_3_16_2_BETA3 to mozilla-inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/8406a2b981c5
Assignee | ||
Comment 2•9 years ago
|
||
I had to revert the NSS_3_16_2_BETA3 update because it broke the build on some platforms. See bug 1020776. https://hg.mozilla.org/integration/mozilla-inbound/rev/e9859d8b5e51
Assignee | ||
Comment 3•9 years ago
|
||
Pushed NSS_3_16_2_BETA3 to mozilla-inbound, with a forced clobber: https://hg.mozilla.org/integration/mozilla-inbound/rev/189492a9a115
Comment 4•9 years ago
|
||
(In reply to Wan-Teh Chang from comment #3) > Pushed NSS_3_16_2_BETA3 to mozilla-inbound, with a forced clobber: > https://hg.mozilla.org/integration/mozilla-inbound/rev/189492a9a115 Backed out for mochitest-2 failures in test_WebCrypto.html: https://tbpl.mozilla.org/php/getParsedLog.php?id=41119166&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=41119060&tree=Mozilla-Inbound remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/6a527532be74
Assignee | ||
Comment 5•9 years ago
|
||
Fixed the mochitest test_WebCrypto.html failures in bug 1021102. Pushed NSS_3_16_2_BETA4 to mozilla-inbound, with a forced clobber: https://hg.mozilla.org/integration/mozilla-inbound/rev/957b31f09f9e
I generated this patch with: python client.py update_nss NSS_3_16_2_BETA4
Attachment #8444741 -
Flags: review?(wtc)
Comment 9•9 years ago
|
||
Comment on attachment 8444741 [details] [diff] [review] update mozilla-aurora to NSS 3.16.2 beta 4 David, we usually don't attach the automatically diffs between NSS version as a patch, it's too big to review anyway. In the past I usually attached a small text file that contained the command that I executed (the python command you stated), and IMHO that's sufficient.
Attachment #8444741 -
Flags: review?(wtc) → review+
Updated•9 years ago
|
Summary: Update Mozilla 32 to use NSS 3.16.2 → Update Mozilla 32 to use NSS 3.16.2 (once it's ready)
Comment 10•9 years ago
|
||
This is a mandatory update for the current Mozilla Aurora 32 branch, because it's currently using a beta version of NSS. We must update the NSS version used by the Aurora 32 branch to a final release version of NSS. I expected NSS 3.16.2 to be released in a few days.
status-firefox32:
--- → affected
tracking-firefox32:
--- → ?
Comment 11•9 years ago
|
||
Comment on attachment 8444741 [details] [diff] [review] update mozilla-aurora to NSS 3.16.2 beta 4 FYI, by NOT attaching the patch, you encourage everyone to re-run the script for branch updates. That's recommended (instead of applying the patch). One reason is that it will correctly adjust the dummy-dependency-header files (which might differ between branches).
(In reply to Kai Engert (:kaie) from comment #9) > Comment on attachment 8444741 [details] [diff] [review] > update mozilla-aurora to NSS 3.16.2 beta 4 > > David, we usually don't attach the automatically diffs between NSS version > as a patch, it's too big to review anyway. > > In the past I usually attached a small text file that contained the command > that I executed (the python command you stated), and IMHO that's sufficient. Thanks, Kai - I'll do this in the future.
Comment on attachment 8444741 [details] [diff] [review] update mozilla-aurora to NSS 3.16.2 beta 4 [Approval Request Comment] Bug caused by (feature/regressing bug #): NSS update User impact if declined: various bugs in NSS Testing completed (on m-c, etc.): on m-c Risk to taking this patch (and alternatives if risky): low String or IDL/UUID changes made by this patch: none Note to whoever checks this in: this might require a clobber.
Attachment #8444741 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 14•9 years ago
|
||
Comment on attachment 8444741 [details] [diff] [review] update mozilla-aurora to NSS 3.16.2 beta 4 Review of attachment 8444741 [details] [diff] [review]: ----------------------------------------------------------------- r=wtc.
Attachment #8444741 -
Flags: review+
Comment 15•9 years ago
|
||
The final release of NSS 3.16.2 has been tagged (which means you could skip the step of updating aurora to beta 4, and rather go directly to RTM). The HG tag is NSS_3_16_2_RTM. (Source archives will be uploaded early tomorrow)
Comment 16•9 years ago
|
||
[Approval Request Comment] Bug caused by (feature/regressing bug #): User impact if declined: Testing completed (on m-c, etc.): Risk to taking this patch (and alternatives if risky): String or IDL/UUID changes made by this patch:
Attachment #8445500 -
Flags: review?(wtc)
Attachment #8445500 -
Flags: approval-mozilla-aurora?
Comment on attachment 8444741 [details] [diff] [review] update mozilla-aurora to NSS 3.16.2 beta 4 Sounds like a plan.
Attachment #8444741 -
Flags: approval-mozilla-aurora?
Attachment #8444741 -
Attachment is obsolete: true
Assignee | ||
Comment 18•9 years ago
|
||
Comment on attachment 8445500 [details]
update mozilla-central and aurora 32 to NSS 3.16.2 RTM
r=wtc.
Attachment #8445500 -
Flags: review?(wtc) → review+
Comment 20•9 years ago
|
||
Please don't resolve bugs unless they've been merged to m-c (per longstanding policy).
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://hg.mozilla.org/mozilla-central/rev/a77c7952a36a
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Comment 22•9 years ago
|
||
Per bug 963150, this is going to need to land on everything down to esr24. Try runs: Aurora - https://tbpl.mozilla.org/?tree=Try&rev=a7c043a45f4c Beta - https://tbpl.mozilla.org/?tree=Try&rev=98b0c1cbd1b0 b2g30 - https://tbpl.mozilla.org/?tree=Try&rev=f0cfefed1841 b2g28 - https://tbpl.mozilla.org/?tree=Try&rev=0a5dc6d2b6b6 esr24 - https://tbpl.mozilla.org/?tree=Try&rev=c9343b73c65e
status-b2g-v1.3:
--- → affected
status-b2g-v1.3T:
--- → affected
status-b2g-v1.4:
--- → affected
status-b2g-v2.0:
--- → affected
status-b2g-v2.1:
--- → fixed
status-firefox31:
--- → affected
status-firefox33:
--- → fixed
status-firefox-esr24:
--- → affected
Comment 23•9 years ago
|
||
Whoops, Aurora is going to need the patch from bug 1021102 as well.
Comment 24•9 years ago
|
||
Comment on attachment 8445500 [details] update mozilla-central and aurora 32 to NSS 3.16.2 RTM OK, so the runs from comment 22 are green with the exception of comment 23, which I've confirmed is indeed fixed by additionally backporting the test fix from bug 1021102.
Attachment #8445500 -
Flags: approval-mozilla-esr24?
Attachment #8445500 -
Flags: approval-mozilla-beta?
Updated•9 years ago
|
Comment 25•9 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #24) > OK, so the runs from comment 22 are green with the exception of comment 23, > which I've confirmed is indeed fixed by additionally backporting the test > fix from bug 1021102. I assume you're referring to attachment 8439528 [details] [diff] [review] only, which patches dom/crypto/test, because the other patches in bug 1021102 should already be part of the NSS release.
Comment 26•9 years ago
|
||
Correct, just the test fix :-)
Comment 27•9 years ago
|
||
I'm pretty sure we're supposed to set ESR tracking to a specific release or the release management team gets annoyed.
Updated•9 years ago
|
Attachment #8445500 -
Flags: approval-mozilla-esr24?
Attachment #8445500 -
Flags: approval-mozilla-esr24+
Attachment #8445500 -
Flags: approval-mozilla-beta?
Attachment #8445500 -
Flags: approval-mozilla-beta+
Attachment #8445500 -
Flags: approval-mozilla-aurora?
Attachment #8445500 -
Flags: approval-mozilla-aurora+
Comment 28•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/c4956e577397 https://hg.mozilla.org/releases/mozilla-beta/rev/636a8b19cf69 https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/f99b87d0b208 https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/37c8e720349f https://hg.mozilla.org/releases/mozilla-esr24/rev/c9b438b04225
You need to log in
before you can comment on or make changes to this bug.
Description
•