1020695 - Update Mozilla 32 to use NSS 3.16.2 (once it's ready)

Status: RESOLVED FIXED

(Core :: Security: PSM, defect, P1)

Description

[Wan-Teh Chang]

This bug is used for landing NSS 3.16.2 Beta and RTM tags in
mozilla-inbound and mozilla-central.

Comment 1

[Wan-Teh Chang]

Pushed NSS_3_16_2_BETA3 to mozilla-inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8406a2b981c5

Comment 2

[Wan-Teh Chang]

I had to revert the NSS_3_16_2_BETA3 update because it broke the build
on some platforms. See bug 1020776.

https://hg.mozilla.org/integration/mozilla-inbound/rev/e9859d8b5e51

Comment 3

[Wan-Teh Chang]

Pushed NSS_3_16_2_BETA3 to mozilla-inbound, with a forced clobber:
https://hg.mozilla.org/integration/mozilla-inbound/rev/189492a9a115

Comment 4

[Ed Morley [:emorley]]

(In reply to Wan-Teh Chang from comment #3)
> Pushed NSS_3_16_2_BETA3 to mozilla-inbound, with a forced clobber:
> https://hg.mozilla.org/integration/mozilla-inbound/rev/189492a9a115

Backed out for mochitest-2 failures in test_WebCrypto.html:
https://tbpl.mozilla.org/php/getParsedLog.php?id=41119166&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=41119060&tree=Mozilla-Inbound

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/6a527532be74

Comment 5

[Wan-Teh Chang]

Fixed the mochitest test_WebCrypto.html failures in bug 1021102.

Pushed NSS_3_16_2_BETA4 to mozilla-inbound, with a forced clobber:
https://hg.mozilla.org/integration/mozilla-inbound/rev/957b31f09f9e

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/957b31f09f9e

Comment 7

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

Attachment: update mozilla-aurora to NSS 3.16.2 beta 4

I generated this patch with:
python client.py update_nss NSS_3_16_2_BETA4

Comment 9

[Kai Engert (:KaiE:)]

Comment on attachment 8444741 [details] [diff] [review]
update mozilla-aurora to NSS 3.16.2 beta 4

David, we usually don't attach the automatically diffs between NSS version as a patch, it's too big to review anyway.

In the past I usually attached a small text file that contained the command that I executed (the python command you stated), and IMHO that's sufficient.

Comment 10

[Kai Engert (:KaiE:)]

This is a mandatory update for the current Mozilla Aurora 32 branch,
because it's currently using a beta version of NSS.

We must update the NSS version used by the Aurora 32 branch to a final release version of NSS.

I expected NSS 3.16.2 to be released in a few days.

Comment 11

[Kai Engert (:KaiE:)]

Comment on attachment 8444741 [details] [diff] [review]
update mozilla-aurora to NSS 3.16.2 beta 4

FYI, by NOT attaching the patch, you encourage everyone to re-run the script for branch updates. That's recommended (instead of applying the patch). One reason is that it will correctly adjust the dummy-dependency-header files (which might differ between branches).

Comment 12

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

(In reply to Kai Engert (:kaie) from comment #9)
> Comment on attachment 8444741 [details] [diff] [review]
> update mozilla-aurora to NSS 3.16.2 beta 4
> 
> David, we usually don't attach the automatically diffs between NSS version
> as a patch, it's too big to review anyway.
> 
> In the past I usually attached a small text file that contained the command
> that I executed (the python command you stated), and IMHO that's sufficient.

Thanks, Kai - I'll do this in the future.

Comment 13

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

Comment on attachment 8444741 [details] [diff] [review]
update mozilla-aurora to NSS 3.16.2 beta 4

[Approval Request Comment]
Bug caused by (feature/regressing bug #): NSS update
User impact if declined: various bugs in NSS
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: none

Note to whoever checks this in: this might require a clobber.

Comment 14

[Wan-Teh Chang]

Comment on attachment 8444741 [details] [diff] [review]
update mozilla-aurora to NSS 3.16.2 beta 4

Review of attachment 8444741 [details] [diff] [review]:
-----------------------------------------------------------------

r=wtc.

Comment 15

[Kai Engert (:KaiE:)]

The final release of NSS 3.16.2 has been tagged (which means you could skip the step of updating aurora to beta 4, and rather go directly to RTM).

The HG tag is NSS_3_16_2_RTM. (Source archives will be uploaded early tomorrow)

Comment 16

[Kai Engert (:KaiE:)]

Attachment: update mozilla-central and aurora 32 to NSS 3.16.2 RTM

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): 
String or IDL/UUID changes made by this patch:

Comment 17

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

Comment on attachment 8444741 [details] [diff] [review]
update mozilla-aurora to NSS 3.16.2 beta 4

Sounds like a plan.

Comment 18

[Wan-Teh Chang]

Comment on attachment 8445500 [details]
update mozilla-central and aurora 32 to NSS 3.16.2 RTM

r=wtc.

Comment 19

[Kai Engert (:KaiE:)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a77c7952a36a

Comment 20

[Ryan VanderMeulen [:RyanVM]]

Please don't resolve bugs unless they've been merged to m-c (per longstanding policy).

Comment 21

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a77c7952a36a

Comment 22

[Ryan VanderMeulen [:RyanVM]]

Per bug 963150, this is going to need to land on everything down to esr24.

Try runs:
Aurora - https://tbpl.mozilla.org/?tree=Try&rev=a7c043a45f4c
Beta   - https://tbpl.mozilla.org/?tree=Try&rev=98b0c1cbd1b0
b2g30  - https://tbpl.mozilla.org/?tree=Try&rev=f0cfefed1841
b2g28  - https://tbpl.mozilla.org/?tree=Try&rev=0a5dc6d2b6b6
esr24  - https://tbpl.mozilla.org/?tree=Try&rev=c9343b73c65e

Comment 23

[Ryan VanderMeulen [:RyanVM]]

Whoops, Aurora is going to need the patch from bug 1021102 as well.

Comment 24

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8445500 [details]
update mozilla-central and aurora 32 to NSS 3.16.2 RTM

OK, so the runs from comment 22 are green with the exception of comment 23, which I've confirmed is indeed fixed by additionally backporting the test fix from bug 1021102.

Comment 25

[Kai Engert (:KaiE:)]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #24)
> OK, so the runs from comment 22 are green with the exception of comment 23,
> which I've confirmed is indeed fixed by additionally backporting the test
> fix from bug 1021102.

I assume you're referring to attachment 8439528 [details] [diff] [review] only, which patches dom/crypto/test, because the other patches in bug 1021102 should already be part of the NSS release.

Comment 26

[Ryan VanderMeulen [:RyanVM]]

Correct, just the test fix :-)

Comment 27

[Al Billings [:abillings - ex-MoCo]]

I'm pretty sure we're supposed to set ESR tracking to a specific release or the release management team gets annoyed.

Comment 28

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c4956e577397
https://hg.mozilla.org/releases/mozilla-beta/rev/636a8b19cf69
https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/f99b87d0b208
https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/37c8e720349f
https://hg.mozilla.org/releases/mozilla-esr24/rev/c9b438b04225