1020977 - [flame] Tapping Done button on Data usage limit page has no effect

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect, P1)

Description

[Viorela Ioia [:viorela]]

Attachment: logcat

This is happening while trying to tap Done button on the Data usage limit page from Usage app, before or after setting a value. 
 
#STR:
1. Launch Usage app (Cost Control)
2. Go through the FTU steps by tapping Next (2 times)
3. Tap Let's got button
4. Tap Settings button in the right top corner of the screen
5. Toggle on the Data use alert checkbox
6. Tap on the input field below the 'When use is above' label text, which will take you to the Data usage limit page
7. Enter a value in the input field (E.g. 0,1)
8. Tap Done button (right top)

#Expected results:
Settings page is displayed. 

#Actual results:
Nothing happens, the Done button has no effect

Note: Tapping the close button in the left has no effect too. Data usage limit is not closing. 

I was able to reproduce this manually and also by running the automated tests
The issue is not reproducible on v1.4

#Env:
Device: Flame
Gaia      d2cfef555dabab415085e548ed44c48a99be5c32
Gecko     https://hg.mozilla.org/mozilla-central/rev/51b428be6213
BuildID   20140605040202
Version   32.0a1
ro.build.version.incremental=94
ro.build.date=Tue May 20 09:29:20 CST 2014

Link to jenkins report:
http://selenium.qa.mtv2.mozilla.com:8080/view/B2G%20Flame/job/b2g.flame.mozilla-central.ui.smoketest/54/HTML_Report/

Comment 1

[Viorela Ioia [:viorela]]

This is the only build where I saw this failure

Comment 2

[Joshua Mitchell (Inactive)]

B2G Inbound Regression Window:

Last Working:
Environmental Variables:
Device: Flame 2.0
Build ID: 20140603203003
Gaia: f37e71daf1d1dc4b4ed05e711301e145d8b281aa
Gecko: 6d5feecc487b
Version: 32.0a1 (2.0) 
Firmware Version: v10G-2

First Broken:
Environmental Variables:
Device: Flame 2.0
BuildID: 20140603233002
Gaia: a38a6a5c6fabc97dd16d5360632b5ac5c7e06241
Gecko: 35dda0499bc8
Version:  32.0a1
Firmware Version: v10G-2

Last Working Gaia First Broken Gecko: Issue does NOT reproduce
Gaia: f37e71daf1d1dc4b4ed05e711301e145d8b281aa
Gecko: 35dda0499bc8

First Broken Gaia Last Working Gecko: Issue does reproduce (Indicating a Gaia issue)
Gaia: a38a6a5c6fabc97dd16d5360632b5ac5c7e06241
Gecko: 6d5feecc487b

Gaia pushlog: https://github.com/mozilla-b2g/gaia/compare/f37e71daf1d1dc4b4ed05e711301e145d8b281aa...a38a6a5c6fabc97dd16d5360632b5ac5c7e06241

Comment 3

[Jason Smith [:jsmith]]

Broken by bug 977077.

Marina - Can you patch this quickly or backout?

Comment 4

[Jason Smith [:jsmith]]

Adding qawanted here to see if this happens on Buri.

Comment 5

[Joshua Mitchell (Inactive)]

This issue does NOT reproduce on Buri

Environmental Variables:
Device: Buri 2.0
Build ID: 20140605061016
Gaia: 908f94fda04462001ece86e6b6c15ad8b05f7526
Gecko: 219b3ed1b996
Version: 32.0a1 (2.0) MOZ
Firmware Version: v1.2device.cfg

Comment 6

[Marina Rodríguez [:mai]]

Attachment: patch v1.0

Salva,
would you mind reviewing the patch?
Regards

Comment 7

[Salvador de la Puente González [:salva]]

Comment on attachment 8436839 [details] [review]
patch v1.0

Nice catch.

Comment 8

[Marina Rodríguez [:mai]]

Master: 1f8b142d349f57135ea8ffffc4afe20c9d48bbec

Comment 9

[Jason Smith [:jsmith]]

2.0 already branched, so I'm not sure this should be marked fixed for 2.0 here.

Comment 10

[Jason Smith [:jsmith]]

Actually disregard - the commit made it into the merge.

Comment 11

[Natalya Kot [:nkot]]

Verified Fixed - Tapping Done button on Data usage limit page takes the user back to Settings page.

Flame 2.0
BuildID: 20140610000223
Gaia: 8d865839d932bfbd5e157f376f74d8cb12bfdd51
Gecko: 1d4046a8cb6c
Version: 32.0a2
V10G-2

Comment 12

[Seth Miko [:SMiko]]

Verified fixed in Flame 2.1 (319mb/full flash)

Actual result: The "done" button brings the user back to the "Settings" page.

Device: Flame 2.1
BuildID: 20141021001201
Gaia: e458f5804c0851eb4e93c9eb143fe044988cecda
Gecko: ee86921a986f
Gonk: 05aa7b98d3f891b334031dc710d48d0d6b82ec1d
Version: 34.0 (2.1)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0