1020991 - App Manager no longer can install packaged apps for FFOS 1.4

Status: RESOLVED INVALID

(DevTools Graveyard :: WebIDE, defect)

Description

[Jukka Jylänki]

After a recent change in FF Nightly, installing packaged apps to a Flame device running 1.4 no longer works, but after clicking Upload, the log will simply print out "Disconnected (unexpected)". Using App Manager in current FF Stable to upload still works though.

Did not test B2G 1.5/newer trunk.

Comment 1

[Paul Rouget [:paul]]

In the *browser console* (https://developer.mozilla.org/en-US/docs/Tools/Browser_Console), do you see anything?

Comment 2

[Jukka Jylänki]

The App Manager log says:

18:40:41: connecting to localhost:6000
18:40:42: connected
18:40:59: Installing the MyApp app...
18:41:02: disconnected (unexpected)

and the Browser Console log says:

"Starting bulk upload" app-actor-front.js:159
"File size: 60905680" app-actor-front.js:161
NS_BASE_STREAM_CLOSED: Component returned failure code: 0x80470002 (NS_BASE_STREAM_CLOSED) [nsIBufferedOutputStream.writeFrom] stream-utils.js:104

Comment 3

[Alexandre Poirot [:ochameau]]

That's disturbing. We shouldn't be running this code (that displays "starting bulk upload") when connected on 1.4 device. Can you tell us more about what version you are using on phone and how did you flashed it?

Comment 4

[Jukka Jylänki]

Oh, I now realize that this is not on 1.4 branch, but a custom build that is running on trunk from sometime around March that I flashed to get profiling support.

How does App Manager decide whether to use the bulk upload? I'm interested in the details since I need to develop the same logic in ffdb.py, which is a command line alternative to App Manager.

Comment 5

[Alexandre Poirot [:ochameau]]

If you are used to our codebase, it is being done right here:
http://mxr.mozilla.org/mozilla-central/source/toolkit/devtools/apps/app-actor-front.js#87

When connecting to the server, the root actor is going to respond to the "hello" request a "traits" object:
http://mxr.mozilla.org/mozilla-central/source/toolkit/devtools/server/actors/root.js#121
This traits object is going to have a "bulk" attribute set to true on 2.1+.
Note that we keep supporting old way of uploading packages, so you will still be able to upload package the old way on 2.1+.

Also while speaking about client libraries for devtools protocol, note the existance of this python code, that support parts of devtools protocol:
  http://mxr.mozilla.org/mozilla-central/source/testing/marionette/transport/marionette_transport/transport.py

I recently opened bug 1014516, in order to make this code implements a real devtools client, that would ideally also support bulk data upload.

Finally, If you happen to have nodejs environment, there is a real nodejs client, with full webapps actor support over here: https://github.com/ochameau/firefox-client

Comment 6

[Jukka Jylänki]

Thanks for the details, I think I'm good to go with that info!

Regarding this bug, perhaps I happened to flash my device in a middle of development, and the device advertises bulk=true but it didn't work properly yet back then?

Comment 7

[Paul Rouget [:paul]]

(In reply to Jukka Jylänki from comment #6)
> Thanks for the details, I think I'm good to go with that info!
> 
> Regarding this bug, perhaps I happened to flash my device in a middle of
> development, and the device advertises bulk=true but it didn't work properly
> yet back then?

Possibly. Can try with the latest 1.4 and see if the problem is fixed?


But at the same time, it looks a lot like bug 1013851.

Comment 8

[Jukka Jylänki]

Ok, flashed latest 1.4 and rebuilt latest B2G trunk, and the issue doesn't reproduce with either. Looks like my old version was in some odd middle state between latest trunk and 1.4 release. I'll just close this issue as invalid. Thanks!