1021123 - Improve colors in remote tabs pull-to-refresh

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[:Margaret Leibovic]

We should disable this until we fix bug 1014335.

Comment 1

[:Margaret Leibovic]

Oops, this is in 31.

Comment 2

[:Margaret Leibovic]

ibarlow and antlam decided that this is an improvement that would make this feature shippable in 31.

Comment 3

[:Margaret Leibovic]

Attachment: Improve colors in remote tabs pull-to-refresh

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8435961 [details] [diff] [review]
Improve colors in remote tabs pull-to-refresh

Review of attachment 8435961 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm.

Comment 5

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/a33f76e3ff8a

Comment 6

[:Margaret Leibovic]

Comment on attachment 8435961 [details] [diff] [review]
Improve colors in remote tabs pull-to-refresh

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 850600
User impact if declined: pull-to-refresh animation doesn't look good
Testing completed (on m-c, etc.): tested locally, just landed on fx-team
Risk to taking this patch (and alternatives if risky): very low-risk, some color changes
String or IDL/UUID changes made by this patch: none

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a33f76e3ff8a

Comment 8

[Ryan VanderMeulen [:RyanVM]]

This was made obsolete on 31 by bug 1010986, wasn't it? If not, needs a branch patch :)

Comment 9

[:Margaret Leibovic]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #8)
> This was made obsolete on 31 by bug 1010986, wasn't it? If not, needs a
> branch patch :)

No, that bug is pull-to-refresh for home panels, this bug is pull-to-refresh for remote tabs.

Does this patch not apply? I think it should.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #8)
> If not, needs a branch patch :)

I didn't.

Comment 11

[:Margaret Leibovic]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #10)
> (In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #8)
> > If not, needs a branch patch :)
> 
> I didn't.

Gah, sorry, this patch doesn't apply because of bug 958889. I'll make a branch patch.

Comment 12

[:Margaret Leibovic]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f11b164d7544

Comment 13

[Flaviu Cos]

Verified as fixed in builds:
- 31 beta 2;
- 32.0a2 (2014-06-16);
- 33.0a1 (2014-06-16);
Device: Lenovo Yoga Tab 10 (Android 4.4.2)