1021213 - [B2G][NFC] The browser will remain in landscape mode after bumping with another NFC phone

Status: VERIFIED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[KTucker [:KTucker][Inactive 3/4/2016]]

Attachment: Flamelogcat.txt

Description:
If the user changes the phone to landscape mode, bumps with another NFC device and then pulls the phone away, the browser will remain in landscape mode. 

Repro Steps:
1)  Updated Flame to Build ID: 20140605040202
2)  Connect two phones using Bluetooth.
3)  Enable NFC on both phones.
4)  Open the browser on Device A.
5)  Bump the phones together so vibration is felt. 
6)  Flip Device A to landscape mode. 
7)  Pull devices apart and flip device A back to portrait mode. 

Actual:
The browser will be stuck in landscape mode and will not revert back to portrait mode. 

Expected:
The browser will change orientation without issue. 

Environmental Variables
Device: Flame v 2.0 
Build ID: 20140605040202
Gecko: https://hg.mozilla.org/mozilla-central/rev/51b428be6213
Gaia: d2cfef555dabab415085e548ed44c48a99be5c32
Platform Version: 32.0a1
Firmware Version: v10G-2
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Notes:
Repro frequency: 100%
Link to failed test case:
See attached: video clip, logcat

Please note there is an issue with the Flame logs https://bugzilla.mozilla.org/show_bug.cgi?id=1010993

Unfortunately, the Buri and Open C phones do not have NFC so i cannot pull a log from those devices.

Comment 1

[KTucker [:KTucker][Inactive 3/4/2016]]

This bug could fail this test case https://moztrap.mozilla.org/manage/case/11495/ if the user takes it a couple steps further by moving the phone away and then rotating the phone to portrait mode.


This issue does not reproduce on the Flame 1.4:

1.4 Environmental Variables:
Device: Flame 1.4
BuildID: 20140530000202
Gaia: fe612fd21389193a8e593aa718831602e5086a62
Gecko: 25011f9a8f26
Version: 30.0
Firmware Version: v10G-2
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

The browser rotates back to portrait correctly without issue after bumping the phones in landscape mode.
 

The issue does not reproduce on the Flame base v10G-2:

1.3 Environmental Variables:
Device: Flame 1.3
BuildID: 20140520094859
Gaia: a73235d23685e9898f40647cebd83b3fcbfd0117
Gecko: Unknown
Version: 28.0
Firmware Version: v10G-2
User Agent: Mozilla/5.0 (Mobile; rv:28.0) Gecko/28.0 Firefox/28.0

The phones will vibrate when bumped with another NFC phone but the UI does not shrink to indicate the user can share a URL and the browser does not get stuck in landscape mode. 


This issue does not reproduce on the Open C 2.0 or the Buri 2.0:

Open C 2.0

2.0 Environmental Variables:
Device: Open C 2.0
BuildID: 20140530040207
Gaia: 26d8fcab9b61f46451600f39c51e03
87ef3c4f88
Gecko: e6f113c83095
Version: 32.0a1
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0 

Buri 2.0

2.0 Environmental Variables:
Device: Buri 2.0 MOZ
BuildID: 20140530040207
Gaia: 26d8fcab9b61f46451600f39c51e0387ef3c4f88
Gecko: e6f113c83095
Version: 32.0a1
Firmware Version: v1.2-device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

NFC is not an available option on the Open C phone and the Buri phone is not NFC capable.

Comment 2

[KTucker [:KTucker][Inactive 3/4/2016]]

Youtube video can be found here: http://youtu.be/i8x7raIqlzg

Comment 3

[Jason Smith [:jsmith]]

Alison - Can you triage this & weigh in on the severity of this bug from a NFC QA perspective?

Comment 4

[Jason Smith [:jsmith]]

I don't think I'd call this is a regression, since NFC is only enabled on 2.0 or later.

Comment 5

[Alison Shiue]

Not only browser but also gallery have the same problem. I think this is a P2 issue would be fixed in 2.0.

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: PullRequest

Comment 7

[Sandip Kamat]

From Product perspective, we need to fix this issue in 2.0 as the orientation seems to get stuck even after the NFC use case completes. Users will see this after sharing any content even once.

Comment 8

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8437588 [details] [review]
PullRequest

This is incorrect. You should let orientationManager to reset the orientation after the shrinking-stop.

Comment 9

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 8437588 [details] [review]
PullRequest

Find out orientation_manager didn't listen to shrinking-rejected event.

Comment 10

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8437588 [details] [review]
PullRequest

r+ if you have unit test.

Comment 11

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 8437588 [details] [review]
PullRequest

test case added, will merge when travis is green.

Comment 12

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://github.com/mozilla-b2g/gaia/commit/a9a37143e14669ae8df0e2c9af910e1ce4d3805b

Comment 13

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/21d579b9532792c7ce87ca92c1b6238d13589630

Comment 14

[Alison Shiue]

Verified on
Gaia      a3a5322692578e0a577fb7fa08e32144b2b05ba3
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/0293597de41f
BuildID   20140612160201
Version   32.0a2

Comment 15

[Lance（leave from Mozilla）]

This issue has been verified successfully on Flame 2.1.
See attachment: 1645.MP4
Reproducing rate: 0/5

Steps:
1.  Connect two phones using Bluetooth.
2.  Enable NFC on both phones.
3.  Open the browser on Device A.
4.  Bump the phones together so vibration is felt. 
5.  Flip Device A to landscape mode. 
6.  Pull devices apart and flip device A back to portrait mode. 

Actual:
7. The browser change to portrait mode successfully.

Flame 2.1 version:
Gaia-Rev        38e17b0219cbc50a4ad6f51101898f89e513a552
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-2g34_v2_1/rev/8b92c4b8f59a
Build-ID        20141205001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141205.035305
FW-Date         Fri Dec  5 03:53:16 EST 2014
Bootloader      L1TC00011880

Comment 16

[Lance（leave from Mozilla）]

Attachment: 1645.MP4