1021270 - [Vertical Homescreen] Smart collections app shows a blank page when adding a collection for the first time

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Johan Lorenzo [:jlorenzo]]

Device: Flame
Gaia      d2cfef555dabab415085e548ed44c48a99be5c32
Gecko     https://hg.mozilla.org/mozilla-central/rev/51b428be6213
BuildID   20140605040202
Version   32.0a1
ro.build.version.incremental=94
ro.build.date=Tue May 20 09:29:20 CST 2014

STR
1. Reset the phone
2. Connect to a Wi-Fi hotspot
3. Long press an empty space of the vertical homescreen
4. Tap Add Smart Collections
5. Share (or not, both doesn't work) your position

Expected result
Standard Smart Collections list should appear

Actual result
A blank page is displayed

Reproducibility rate: 100%

Additional notes: Going back to the menu and restart the STR from step 3 fix the problem until the next reset.

Comment 1

[Kevin Grandon :kgrandon]

Amir - I am only able to reproduce this after flashing a device for the first time. What data are we caching, do you think we could be forgetting to resolve a promise somewhere?

Comment 2

[Amir Nissim (:amirn)]

Do you see a blank white screen?

Actually, all the content is there but is not visible.
The <select> is populated with all the options but all we see is the body's background (white)

If you tap and scroll the screen then the <select> becomes visible.

Any idea what might cause this?

Comment 3

[Amir Nissim (:amirn)]

BTW I can reproduce this by re-building the Collection app.

Comment 4

[Amir Nissim (:amirn)]

(In reply to Amir Nissim (Everything.me) from comment #2)
> Do you see a blank white screen?
> 
> Actually, all the content is there but is not visible.
> The <select> is populated with all the options but all we see is the body's
> background (white)
> 
> If you tap and scroll the screen then the <select> becomes visible.
> 

see: http://youtu.be/N8gqvmoK2XU?t=13s

Comment 5

[Amir Nissim (:amirn)]

(In reply to Kevin Grandon :kgrandon from comment #1)
> Amir - I am only able to reproduce this after flashing a device for the
> first time. What data are we caching, do you think we could be forgetting to
> resolve a promise somewhere?

Kevin, it looks like an Activity rendering bug. The E.me code works as expected.
Please forward this accordingly.

Comment 6

[Kevin Grandon :kgrandon]

Moving into system and doing a ni? on Tim and Alive after your investigation.

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

Could you explain what is that feature doing and how it works?

Comment 8

[James Lal [:lightsofapollo]]

I traced this through gaia just now...

The whole workflow is something like this:

- verthome triggers an activity launching the collections app

- collections app builds up a select element then focuses it

<stuff starts to go wrong here>

- Sometimes you see a nice blank white screen (the value selector is .hidden)

- In ValueSelector inputmethod-contextchange is not fired until _after_ (this is a race btw) scrolling in the blank white area

- Now you can see stuff 

The problem is somewhere in the platform (else we are eating an event somewhere in gaia somehow that prevents it from reaching ValueSelector). I am starting to debug gecko now.

If you have any suggestions please let me know!

Comment 9

[(inactive after 6/18) Alive Kuo [:alive]]

Yeah I am doing the same as you.
I guess it's because focus doesn't reach the activity before user touches it. Trying this way...

Comment 10

[(inactive after 6/18) Alive Kuo [:alive]]

OK I think I fixed the problem. It's because the permission dialog steal the focus from the user touch but doesn't give focus back to the activity.

If there's no permission dialog this problem won't happen.

James is this what you found?

Comment 11

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/20332

Proposed fix v1: Focus the top most window when permission dialog is hidden.

Comment 12

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8438142 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/20332

Please note the change made here.

Comment 13

[James Lal [:lightsofapollo]]

Talking with alive... the current patch does not fix the issue for me... here is my STR:

 -> go to vertical home
 -> long press
 -> click smart collection
 -> sometimes you see blank white screen (70% I see the white screen)

Comment 14

[[e-mail]]

Comment on attachment 8438142 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/20332

looks good to me with comments addressed

Comment 15

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8438142 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/20332

Please clarify if we really need part 2, and why.

Comment 16

[James Lal [:lightsofapollo]]

FWIW- With only part when I tested the patch I still often saw blank screens (probably less then initially) with the second part I could not reproduce after trying for 5 minutes.

Comment 17

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #15)
> Comment on attachment 8438142 [details] [review]
> https://github.com/mozilla-b2g/gaia/pull/20332
> 
> Please clarify if we really need part 2, and why.

I am writing tests for second part.
There are two issues in this bug
(1) After permission dialog is gone the app is not focused
(2) The app/activity may be opened but still loading; we don't get it to focus after loading is done so we need part2.

Comment 18

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8438142 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/20332

1. Fix the permission dialog steal the focus
2. Correct focus the app again when it's loaded to reduce the launch time.
3. Unit tests

Comment 19

[(inactive after 6/18) Alive Kuo [:alive]]

BTW I found when the value selector is shown, press home button won't blur it. Should be another issue.

Comment 20

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8438142 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/20332

Looks good enough, re-request for review if you want to make improvements.

Comment 21

[(inactive after 6/18) Alive Kuo [:alive]]

https://github.com/mozilla-b2g/gaia/commit/e4d34f6847b5191f3148d72b1bcaa9f04ede2dd3

Comment 22

[Kevin Grandon :kgrandon]

Comment on attachment 8438142 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/20332

This is required for the vertical homescreen. We've done our best effort at testing and believe the tree will remain green with uplift.

Comment 23

[Johan Lorenzo [:jlorenzo]]

Verified on master.

Comment 24

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/d694072ba6cbf2180daa1cea09fd535f44815f83

Comment 26

[Lancy(Leave from Mozilla)]

Attachment: Verify_Video_Flame.MP4

This issue has been verified successfully on Flame 2.0 & 2.1.
See attachment: Verify_Video_Flame.MP4
Reproducing rate: 0/5

Flame v2.0 version:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/ff1100ba2ab8
Build-ID        20141204000228
Version         32.0

Flame v2.1 version:
Gaia-Rev        5655269098c7e82254e56933f1af05b4abe2a2f3
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/86608c9389b5
Build-ID        20141204001201
Version         34.0