1021327 - [Flatfish] No icons at homescreen when building with vertical homescreen as default

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Raniere Silva]

Steps to Reproduce:

1. Download/Update Gaia source tree
2. Change to last commit at Gaia source tree (right now c0a5cc59d3a12ff2ce70f9b028c3a9468e58a555)
3. Update Flatfish with the last version of Gaia

$ GAIA_KEYBOARD_LAYOUTS=en PRODUCTION=1 NOFTU=1 REMOTE_DEBUGER=1 GAIA_DEVICE_TYPE=tablet make reset-gaia
	 
Actual Results:

No icons at homescreen.
	 
Expected Results:

Vertical homescreen with large icons due three columns (at least this was what I get at hamachi).

Environment Informations:

- OS version: 2.0.0.0-prerelease
- Firmware revision: flatfish_20140519-1653
- Platform version: 32.0a1
- Builder Identifier: 20140519171236
- Git commit info: 2014-06-05 21:41:27 c0a5cc59

Comment 1

[Kevin Grandon :kgrandon]

Thanks for filing. I will take a look as time permits.

Comment 2

[Sherman Chen [:chens] (inactive)]

I think that's because tablet's app list didn't have it, I will add verticalhome to tablet's app list and try on flatfish.

Comment 3

[Sherman Chen [:chens] (inactive)]

Attachment: WIP

WIP for adding verticalhome in tablet app list

Comment 4

[Sherman Chen [:chens] (inactive)]

Do we have to enable verticalhome in tablet by default or just to stick with the original one?

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 8435373 [details] [review]
WIP

Clearing the feedback? for now. Do you have a screenshot? I'm thinking we may actually want to set the settings database to use the old homescreen if this one is not functional.

Comment 6

[Raniere Silva]

Attachment: flatfish-vertical-homescreen.png

Sherman, thanks. It works for me.

Comment 7

[Sherman Chen [:chens] (inactive)]

Attachment: flatfish-verticalhome.png

Also update screenshot from my side, although it's a little bit different that I got 3 icons per row.

Comment 8

[Raniere Silva]

Sherman, maybe this is due the old version of Gecko that I'm using.

Comment 9

[Sherman Chen [:chens] (inactive)]

And vertical homescreen will only work after first flash gaia, once restart the tablet or change from original homescreen, there is no icon on vertical homescreen again.

Comment 10

[Sherman Chen [:chens] (inactive)]

Attachment: WIP - verticalhome not default

Comment 11

[Kevin Grandon :kgrandon]

I took a look at the UX, and until we get specs from designers, I would strongly suggest that we use the current horizontal homescreen on tablet. I think it's going to provide a better experience for now.

Comment 12

[Sherman Chen [:chens] (inactive)]

Update some findings I got so far: 

1. Flash gaia with WIP:
Got vertical homescreen with icon

2. Flash gaia with WIP, then restart device:
Got vertical homescreen with no icon

3. Flash gaia with WIP, change to original then to vertical:
Got vertical homescreen with no icon

4. Flash gaia with WIP - verticalhome not default:
Got original homescreen with icon

5. Flash gaia with WIP - verticalhome not default, and restart device:
Got original homescreen with icon

6. Flash gaia with WIP - verticalhome not default, change to vertical:
Got vertical homescreen with icon

7. Flash gaia with WIP - verticalhome not default, change to vertical, original then vertical again:
Got vertical homescreen with no icon

Comment 13

[Joe Cheng [:jcheng] (please needinfo)]

agree with comment 11 to use the current horizontal homescreen before we have new tablet homescreen
ni? UX

Comment 14

[GoodMike]

For tablet, please use horizontal screen now.

Comment 15

[Sherman Chen [:chens] (inactive)]

Comment on attachment 8435449 [details] [review]
WIP - verticalhome not default

Since we will continue to use horizontal homescreen on tablet, this patch may help.

Comment 16

[Kevin Grandon :kgrandon]

Comment on attachment 8435449 [details] [review]
WIP - verticalhome not default

This generally looks good to me, but I think yuren or someone on the build system should review it.

Comment 17

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8435449 [details] [review]
WIP - verticalhome not default

r=yurenju if nit is address, thanks Kevin and chens!

Comment 18

[Sherman Chen [:chens] (inactive)]

Merged to master
https://github.com/mozilla-b2g/gaia/commit/feb16ac7599fe0a9c320542878452b23d6001211