1021328 - Leak under AudioOutputObserver::InsertFarEnd (continued)

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect)

Description

[Andrew McCreight [:mccr8]]

Attachment: stacks for leaking allocations

Despite the landing bug 1000539, I'm still seeing leaks under stacks in AudioOutputObserver::InsertFarEnd while running Mochitest-3.  I'm now seeing about 1mb of leaks under M3.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: ensure no error paths lose far-end audio chunks in getUserMedia

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Attachment: ensure no error paths lose far-end audio chunks in getUserMedia

Noticed this isn't a new'd object; we should balance moz_xmalloc() with moz_free().  Also, Clear() was popping but not freeing, and that was likely the source of the leaks.

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Attachment: ensure no error paths lose far-end audio chunks in getUserMedia

now actually tested and working

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8435615 [details] [diff] [review]
ensure no error paths lose far-end audio chunks in getUserMedia

one more try...

Comment 5

[Andrew McCreight [:mccr8]]

Comment on attachment 8435615 [details] [diff] [review]
ensure no error paths lose far-end audio chunks in getUserMedia

Review of attachment 8435615 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! It might be nice to do MOZ_COUNT_CTOR/MOZ_COUNT_DTOR when you allocate and free these chunks, so that we would detect leaks in regular debug builds.  I guess it would be a little tedious to put them every place these blocks are allocated and freed, as there is no actual CTOR/DTOR for them.

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dbb05142c666

Comment 7

[Andrew McCreight [:mccr8]]

This patch fixed the leaks I was seeing with LSAN.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/dbb05142c666