If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Leak under AudioOutputObserver::InsertFarEnd (continued)

RESOLVED FIXED in mozilla32

Status

()

Core
WebRTC: Audio/Video
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mccr8, Assigned: jesup)

Tracking

(Blocks: 2 bugs)

Trunk
mozilla32
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [lsan][MemShrink])

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

3 years ago
Created attachment 8435339 [details]
stacks for leaking allocations

Despite the landing bug 1000539, I'm still seeing leaks under stacks in AudioOutputObserver::InsertFarEnd while running Mochitest-3.  I'm now seeing about 1mb of leaks under M3.
(Assignee)

Comment 1

3 years ago
Created attachment 8435556 [details] [diff] [review]
ensure no error paths lose far-end audio chunks in getUserMedia
(Assignee)

Updated

3 years ago
Attachment #8435556 - Flags: review?(continuation)
(Assignee)

Comment 2

3 years ago
Created attachment 8435563 [details] [diff] [review]
ensure no error paths lose far-end audio chunks in getUserMedia

Noticed this isn't a new'd object; we should balance moz_xmalloc() with moz_free().  Also, Clear() was popping but not freeing, and that was likely the source of the leaks.
(Assignee)

Updated

3 years ago
Attachment #8435556 - Attachment is obsolete: true
Attachment #8435556 - Flags: review?(continuation)
(Assignee)

Updated

3 years ago
Attachment #8435563 - Flags: review?(continuation)
(Assignee)

Comment 3

3 years ago
Created attachment 8435615 [details] [diff] [review]
ensure no error paths lose far-end audio chunks in getUserMedia

now actually tested and working
(Assignee)

Updated

3 years ago
Attachment #8435563 - Attachment is obsolete: true
Attachment #8435563 - Flags: review?(continuation)
(Assignee)

Comment 4

3 years ago
Comment on attachment 8435615 [details] [diff] [review]
ensure no error paths lose far-end audio chunks in getUserMedia

one more try...
Attachment #8435615 - Flags: review?(continuation)
(Reporter)

Comment 5

3 years ago
Comment on attachment 8435615 [details] [diff] [review]
ensure no error paths lose far-end audio chunks in getUserMedia

Review of attachment 8435615 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! It might be nice to do MOZ_COUNT_CTOR/MOZ_COUNT_DTOR when you allocate and free these chunks, so that we would detect leaks in regular debug builds.  I guess it would be a little tedious to put them every place these blocks are allocated and freed, as there is no actual CTOR/DTOR for them.
Attachment #8435615 - Flags: review?(continuation) → review+
(Assignee)

Comment 6

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/dbb05142c666
Target Milestone: --- → mozilla32
(Reporter)

Comment 7

3 years ago
This patch fixed the leaks I was seeing with LSAN.
https://hg.mozilla.org/mozilla-central/rev/dbb05142c666
Assignee: nobody → rjesup
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.