Closed
Bug 1021328
Opened 11 years ago
Closed 11 years ago
Leak under AudioOutputObserver::InsertFarEnd (continued)
Categories
(Core :: WebRTC: Audio/Video, defect)
Core
WebRTC: Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: mccr8, Assigned: jesup)
References
(Blocks 1 open bug)
Details
(Whiteboard: [lsan][MemShrink])
Attachments
(2 files, 2 obsolete files)
1.61 KB,
text/plain
|
Details | |
4.35 KB,
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
Despite the landing bug 1000539, I'm still seeing leaks under stacks in AudioOutputObserver::InsertFarEnd while running Mochitest-3. I'm now seeing about 1mb of leaks under M3.
Assignee | ||
Comment 1•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Attachment #8435556 -
Flags: review?(continuation)
Assignee | ||
Comment 2•11 years ago
|
||
Noticed this isn't a new'd object; we should balance moz_xmalloc() with moz_free(). Also, Clear() was popping but not freeing, and that was likely the source of the leaks.
Assignee | ||
Updated•11 years ago
|
Attachment #8435556 -
Attachment is obsolete: true
Attachment #8435556 -
Flags: review?(continuation)
Assignee | ||
Updated•11 years ago
|
Attachment #8435563 -
Flags: review?(continuation)
Assignee | ||
Comment 3•11 years ago
|
||
now actually tested and working
Assignee | ||
Updated•11 years ago
|
Attachment #8435563 -
Attachment is obsolete: true
Attachment #8435563 -
Flags: review?(continuation)
Assignee | ||
Comment 4•11 years ago
|
||
Comment on attachment 8435615 [details] [diff] [review]
ensure no error paths lose far-end audio chunks in getUserMedia
one more try...
Attachment #8435615 -
Flags: review?(continuation)
Reporter | ||
Comment 5•11 years ago
|
||
Comment on attachment 8435615 [details] [diff] [review]
ensure no error paths lose far-end audio chunks in getUserMedia
Review of attachment 8435615 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks! It might be nice to do MOZ_COUNT_CTOR/MOZ_COUNT_DTOR when you allocate and free these chunks, so that we would detect leaks in regular debug builds. I guess it would be a little tedious to put them every place these blocks are allocated and freed, as there is no actual CTOR/DTOR for them.
Attachment #8435615 -
Flags: review?(continuation) → review+
Assignee | ||
Comment 6•11 years ago
|
||
Target Milestone: --- → mozilla32
Reporter | ||
Comment 7•11 years ago
|
||
This patch fixed the leaks I was seeing with LSAN.
Comment 8•11 years ago
|
||
Assignee: nobody → rjesup
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•