Closed Bug 1021328 Opened 6 years ago Closed 6 years ago

Leak under AudioOutputObserver::InsertFarEnd (continued)

Categories

(Core :: WebRTC: Audio/Video, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: mccr8, Assigned: jesup)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [lsan][MemShrink])

Attachments

(2 files, 2 obsolete files)

Despite the landing bug 1000539, I'm still seeing leaks under stacks in AudioOutputObserver::InsertFarEnd while running Mochitest-3.  I'm now seeing about 1mb of leaks under M3.
Attachment #8435556 - Flags: review?(continuation)
Noticed this isn't a new'd object; we should balance moz_xmalloc() with moz_free().  Also, Clear() was popping but not freeing, and that was likely the source of the leaks.
Attachment #8435556 - Attachment is obsolete: true
Attachment #8435556 - Flags: review?(continuation)
Attachment #8435563 - Flags: review?(continuation)
Attachment #8435563 - Attachment is obsolete: true
Attachment #8435563 - Flags: review?(continuation)
Comment on attachment 8435615 [details] [diff] [review]
ensure no error paths lose far-end audio chunks in getUserMedia

one more try...
Attachment #8435615 - Flags: review?(continuation)
Comment on attachment 8435615 [details] [diff] [review]
ensure no error paths lose far-end audio chunks in getUserMedia

Review of attachment 8435615 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! It might be nice to do MOZ_COUNT_CTOR/MOZ_COUNT_DTOR when you allocate and free these chunks, so that we would detect leaks in regular debug builds.  I guess it would be a little tedious to put them every place these blocks are allocated and freed, as there is no actual CTOR/DTOR for them.
Attachment #8435615 - Flags: review?(continuation) → review+
This patch fixed the leaks I was seeing with LSAN.
https://hg.mozilla.org/mozilla-central/rev/dbb05142c666
Assignee: nobody → rjesup
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.