979928 - [meta] WebRTC leaks detected by Leak Sanitizer

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Andrew McCreight [:mccr8]]

I'd say about 95% of the leaks that LSAN finds on crash tests are from WebRTC.  It would be good to investigate some of that.

To do an LSAN run, make an ASAN build, then run with ASAN_OPTIONS="detect_leaks=1".

Note that there are some existing known leaks in an LSAN suppression file:
  https://code.google.com/p/webrtc/source/browse/trunk/tools/lsan/suppressions.txt

The log that was produced from crash tests is:
  https://bug976414.bugzilla.mozilla.org/attachment.cgi?id=8386177

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Major leak is of VoiceEngineImpls due to missing Release() calls in MediaEngineWebRTC.

Fixing those locally has exposed that we don't reliably release MediaEngineWebRTCAudioSource objects (sometimes yes, sometimes no).

Losing the VoiceEngineImpl has a huge cascade effect

Opt builds may expose an issue with a race condition in shutdown; not verified yet (pure virtual crash dereferencing clock_)

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: updated M2 leaks

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: updated M3 leaks

Comment 4

[Sylvestre Ledru [:Sylvestre]]

not used anymore, closing