1021457 - [Keyboard] Alternatives bubble should include the origin key

Status: RESOLVED DUPLICATE of bug 985334

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Omega Feng [:Omega] [:馮於懋]]

Device: Flame
Gaia: 2014-06-05 23:34:17
BuildID: 20140602160205 
Version: 2.0.0.0-prerelease

STR:
1) Tap any text input to show keyboard
2) Long press on "A" on keyboard

Actual:
Alternatives bubble doesn't include "A"

Expected:
Alternatives bubble should include "A"
(It should apply to all keys which have alternatives.)

Comment 1

[Raniere Silva]

Attachment: add-origin-key-into-alternatives

Comment 2

[Jason Smith [:jsmith]]

QA Wanted to check 1.4.

Comment 3

[Omega Feng [:Omega] [:馮於懋]]

Comment on attachment 8436231 [details] [review]
add-origin-key-into-alternatives

Good job! Thanks!
However, if there are too many alternatives (like 'A'), the bubble is too long and out of the screen. So I think we should have bug 985334 (multi-row alternatives bubble) fixed beforehand.

Comment 4

[Chris Kreinbring [:CKreinbring]]

Able to repro on Flame 1.4 and Buri 1.4 mozilla RIL.

Flame 1.4
Build ID: 20140609000201
Gecko: https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/e3f85877db29
Gaia: 8b239e41bbd85aa7b6a2c5d388e775ba7de6fb2b
Platform Version: 30.0
Firmware Version: V10g-2
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Buri 1.4
Build ID: 20140609091337
Gecko: https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/dee60bc7a6cf
Gaia: 172acbe168c263e5cda6f8125aa18873e9ecc3a4
Platform Version: 30.0
Firmware Version: V1.2-device.cfg
User Agent: Mozilla/5.0 (Mobile; rv 30.0) Gecko/30.0 Firefox/30.0

Comment 5

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

I think this is exactly the same as bug 985334.
And as Omega mentioned, we should have bug 934209 fixed first to implement this *new* requirement.

Comment 6

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Kept tracked by bug 985334, so remove the dependency.

Comment 7

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8436231 [details] [review]
add-origin-key-into-alternatives

Sorry that I have to cancel the review for the same reason as comment 5.

You may take those bugs instead if you're interested.
Thanks!