1021512 - [Vertical Homescreen] Icon gets stuck while activating notification panel while dragging

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Johan Lorenzo [:jlorenzo]]

Build Information

Device: Flame
Gaia      d2cfef555dabab415085e548ed44c48a99be5c32
Gecko     https://hg.mozilla.org/mozilla-central/rev/51b428be6213
BuildID   20140605040202
Version   32.0a1
ro.build.version.incremental=94
ro.build.date=Tue May 20 09:29:20 CST 2014

Steps to Reproduce
1. Enter edit mode
2. Start dragging an icon
3. With another finger, initiate a top edge gesture to drop down the notification panel

Actual Results
Notification panel is displayed leaving the drop action unfinished. This may cause the icon to be placed out the grid.

Reproduction Frequency: 100%

Comment 1

[Jason Smith [:jsmith]]

Given that this was something a user explicitly triggered & not by accident, I don't think this is a blocker. Feel free to request approval though.

Comment 2

[Kevin Grandon :kgrandon]

Making the title a bit more clear to me - seems like the icon just needs to get dropped into the right place.

I don't think we'll have much success in actually allowing the utility tray to expand (you can't do that with two fingers on the screen anywhere), but the dragdrop should recover more gracefully.

Comment 3

[Etienne Segonzac (:etienne)]

Taking a look.

Comment 4

[Kevin Grandon :kgrandon]

Sure, fwiw - I'm pretty sure all of the dragdrop issues are under one umbrella, but any improvement is welcome. (I don't really think there is any problem with the system here, the notification tray has never worked with a second finger)

Comment 5

[Etienne Segonzac (:etienne)]

Attachment: Gaia PR

Comment 6

[Kevin Grandon :kgrandon]

Comment on attachment 8437939 [details] [review]
Gaia PR

I like the patch because it does fix our homescreen icon use case, so thank you very much for that. I think there's probably still some issues with the system statusbar, but I'm fine putting that in another bug.

Comment 7

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/8d40a9499457c511db955ca9c81ee2931543d071

Comment 8

[Kevin Grandon :kgrandon]

Comment on attachment 8437939 [details] [review]
Gaia PR

This is required for the vertical homescreen. We've done our best effort at testing and believe the tree will remain green with uplift.

Comment 9

[Johan Lorenzo [:jlorenzo]]

Verified on master. Icons are now automatically dropped when the notification panel is pulled down.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/b201c0b703eecc514c3b9df6e17898852aa0308e

Comment 11

[Gregor Wagner [:gwagner]]

Thanks Etienne!

Comment 12

[Lancy(Leave from Mozilla)]

Attachment: Verify_Video_Flame.MP4

This issue has been verified successfully on Flame 2.0 & 2.1.
See attachment: Verify_Video_Flame.MP4
Reproducing rate: 0/10

Flame v2.0 version:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/29222e215db8
Build-ID        20141203000201
Version         32.0

Flame v2.1 version:
Gaia-Rev        dbaf3e31c9ba9c3436e074381744f2971e15c7bf
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/ebce587d2194
Build-ID        20141203001205
Version         34.0