1021548 - Importing second time from SIM card yields to errors in the console and contacts are not updated

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Jose Manuel Cantera]

STR: Go to Contacts App. Import your SIM Contacts. Everything is ok
Then, Import SIM Contacts another time. 

In the console can be found errors like this

Content JS ERROR at app://communications.gaiamobile.org/shared/js/contacts/import/utilities/import_sim_contacts.js:225 in saveError: SIM Import: Error importing  89340711002753192957 UnknownError

The Corresponding Contact is not saved nor updated.

Comment 1

[Jason Smith [:jsmith]]

QA Wanted to check 1.4.

Comment 2

[Jose Manuel Cantera]

Attachment: 20232.html

Comment 3

[Cody Roesch [:croesch]]

Verified that this bug DOES repro on Flame 1.4. I get the same Errors in the log report when trying to reimport already imported contacts from the SIM.

SIM Import: Error importing  89014103255663540814210 UnknownError
06-09 17:24:43.281  1169  1169 E GeckoConsole: Content JS ERROR at app://communications.gaiamobile.org/contacts/js/utilities/import_sim_contacts.js:207 in saveError: SIM Import: Error importing  89014103255663540814209 UnknownError

Environmental Variables:
Device: Flame 1.4
Build ID: 20140609000201
Gaia: 8b239e41bbd85aa7b6a2c5d388e775ba7de6fb2b
Gecko: e3f85877db29
Version: 30.0 (1.4) 
Firmware Version: v10G-2

Comment 4

[Loli (:lolimartinezcr)]

(In reply to croesch from comment #3)
> Verified that this bug DOES repro on Flame 1.4. I get the same Errors in the
> log report when trying to reimport already imported contacts from the SIM.
> 
> SIM Import: Error importing  89014103255663540814210 UnknownError
> 06-09 17:24:43.281  1169  1169 E GeckoConsole: Content JS ERROR at
> app://communications.gaiamobile.org/contacts/js/utilities/
> import_sim_contacts.js:207 in saveError: SIM Import: Error importing 
> 89014103255663540814209 UnknownError
> 
> Environmental Variables:
> Device: Flame 1.4
> Build ID: 20140609000201
> Gaia: 8b239e41bbd85aa7b6a2c5d388e775ba7de6fb2b
> Gecko: e3f85877db29
> Version: 30.0 (1.4) 
> Firmware Version: v10G-2

Bug development by TEF team, for this reason I change QA contact.

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8436933 [details]
20232.html

Can we have unit tests for this, I know is a small change but with the current policy we should add always unit tests to our changes.

Code wise looks good to me, also tried on the phone and working.

Comment 6

[Preeti Raghunath(:Preeti)]

Jose,

So does this happen when the SAME set of contacts are imported OR does it happen when NEW contacts are imported?

Comment 7

[Jason Smith [:jsmith]]

QA Wanted to check 1.3.

Comment 8

[Jose Manuel Cantera]

(In reply to Preeti Raghunath(:Preeti) from comment #6)
> Jose,
> 
> So does this happen when the SAME set of contacts are imported OR does it
> happen when NEW contacts are imported?

It happens when the SAME set of contacts are imported

Comment 9

[Loli (:lolimartinezcr)]

(In reply to Jason Smith [:jsmith] from comment #7)
> QA Wanted to check 1.3.

Verified that this bug DOES repro on Hamachi 1.3.

Gecko-8f64291
Gaia-7a69ecb

Comment 10

[Jose Manuel Cantera]

landed in master

https://github.com/mozilla-b2g/gaia/commit/07ab0bb6a6b26f4b0a2aaafb0c725f20464440de

Comment 11

[Loli (:lolimartinezcr)]

Tested and NOT working
Hamachi
2.1
Gecko-a3c4c53
Gaia-5f9f64a

Comment 12

[Francisco Jordano [:arcturus] [:francisco]]

Jose could you sync with Loli about this?

Comment 13

[Loli (:lolimartinezcr)]

(In reply to Francisco Jordano [:arcturus] [:francisco] from comment #12)
> Jose could you sync with Loli about this?

Jose and I have already talked about this bug.

Comment 14

[Francisco Jordano [:arcturus] [:francisco]]

(In reply to Loli from comment #13)
> (In reply to Francisco Jordano [:arcturus] [:francisco] from comment #12)
> > Jose could you sync with Loli about this?
> 
> Jose and I have already talked about this bug.

So, does the patch work? I doesnt?

We will need to know that to know if we backout the patch that doesnt work or is a small follow up.

Thanks!

Comment 15

[Jose Manuel Cantera]

Francisco,

The patch works partially. We have found that for certain contacts which are not merged they get duplicated. I'm currently investigating the issue and Loli will open a new bug that will try to fix asap

thanks

Comment 16

[Maria Angeles Oteo (:oteo)]

(In reply to Jose Manuel Cantera from comment #15)
> Francisco,
> 
> The patch works partially. We have found that for certain contacts which are
> not merged they get duplicated. I'm currently investigating the issue and
> Loli will open a new bug that will try to fix asap
> 
> thanks

Bug 1026369 opened to track this issue

Comment 17

[Loli (:lolimartinezcr)]

Tested and working
Hamachi
2.1
Gecko:57d05d4
Gaia:846f561

Pending 2.0, 1,4 and 1.3

Comment 18

[Loli (:lolimartinezcr)]

Tested and working
Hamachi 2.0
Gecko-c91e987
Gaia-87d0463

1.4
Gecko-b7cb7d7
Gaia-a054aa2

Comment 19

[Loli (:lolimartinezcr)]

(In reply to Loli from comment #18)
> Tested and working
> Hamachi 2.0
> Gecko-c91e987
> Gaia-87d0463
> 
> 1.4
> Gecko-b7cb7d7
> Gaia-a054aa2

Where I say tested in 2.0, it isn't correct. Pending uplift in 2.0, for this reason i change status to RESOLVED.

Comment 20

[Jose Manuel Cantera]

Comment on attachment 8436933 [details]
20232.html

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Different behavior of mozContacts / iccManager between different versions of Gecko. 
[User impact] if declined: High, contacts can be duplicated or not updated, so the EX can be severely impacted. 
[Testing completed]: Yes, including unit testing. Tested by QA as well on v2.1 
[Risk to taking this patch] (and alternatives if risky): very low
[String changes made]:

Comment 21

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/0a3932cb0a1956e30f3a277c0c69de4fd2bef562

Comment 22

[Loli (:lolimartinezcr)]

Tested and working
Hamachi 2.0
Gecko-bffdf5e
Gaia-2248c03

Comment 23

[Corinne Innes [:CorinneI]]

Verified fixed on 2.0 and 2.1

Device: Flame 2.0 (319mb)(Kitkat Base)(Shallow Flash)
BuildID: 20141121000203
Gaia: 626d4d11a8c7e55022c1f364abb72ea340e2f1e7
Gecko: 74a294e72d0a
Version: 32.0 (2.0)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Device: Flame 2.1 (319mb)(Kitkat Base)(Shallow Flash)
BuildID: 20141125001201
Gaia: 1bdd49770e2cb7a7321e6202c9bf036ab5d8f200
Gecko: db893274d9a6
Version: 34.0 (2.1)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Actual:
No errors occur and contacts with info get merged correctly