1026369 - In import, contacts are duplicated.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Loli (:lolimartinezcr)]

Tested
Hamachi
2.1
Gecko: a3c4c53
Gaia: 5f9f64a

Reproducible 100%

Pre-requisites: Contacts created  in Memory card
 
STRs:
1. Tap contacts application.
2. Tap settings option.
3. Tap import contacts option.
4. Tap "Memory card" button.
5. Once all contacts have been imported, tap in settings option.
6. Tap import contacts option.
7. Tap "Memory card" button.

Expected result:
Contacts aren't duplicate.

Actual result: 
All contacts are duplicate.

Comment 1

[Loli (:lolimartinezcr)]

This bugs also is reproducible if user import to SIM card.

Comment 2

[Loli (:lolimartinezcr)]

Tested in 1.4 and it isn't reproducible.
Hamachi
1.4
Gecko-b92e1fb
Gaia-99394f1

Comment 3

[Jose Manuel Cantera]

Attachment: 20605.html

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8441281 [details]
20605.html

Code wise LGTM,

I'm just struggling with two things:

- Adding the dependecy of SIM in the macthing algorithm, but seems we will need to deal with it. Just thinking on if new contacts sources will need special rules for the matching, and if it's time to add something that is plugabble, or at least well sepparated.

- The naming of the functions, the old |doMatchPassive| in charge of doing the proper matching ,now is |doMatchPassiveNoSim|, again it has to be with the fact that is couple the sim process with this.

In case that we keep the sim matching inside the matcher, can we create two functions, like:

performMatchPassive and performSIMMatchPassive ?

Does that sounds good?

As I commented before the code is perfect, just a matter of organization.

Comment 5

[Jose Manuel Cantera]

(In reply to Francisco Jordano [:arcturus] [:francisco] from comment #4)
> Comment on attachment 8441281 [details]
> 20605.html
> 
> Code wise LGTM,
> 
> I'm just struggling with two things:
> 
> - Adding the dependecy of SIM in the macthing algorithm, but seems we will
> need to deal with it. Just thinking on if new contacts sources will need
> special rules for the matching, and if it's time to add something that is
> plugabble, or at least well separated.

Yes, once we add more dependencies on specific contacts sources we can aim at a refactoring of the contacts_matcher module

> 
> - The naming of the functions, the old |doMatchPassive| in charge of doing
> the proper matching ,now is |doMatchPassiveNoSim|, again it has to be with
> the fact that is couple the sim process with this.

Oh absolutely. I have implemented this suggestion on the last version of the PR

> 
> In case that we keep the sim matching inside the matcher, can we create two
> functions, like:
> 
> performMatchPassive and performSIMMatchPassive ?
> 
> Does that sounds good?
> 
> As I commented before the code is perfect, just a matter of organization.

Thanks, very good and precise comments, Francisco

Comment 6

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/c2c92e7be95dd0b65ee44113e1d17592dd0e20c6

Comment 7

[Loli (:lolimartinezcr)]

I have tested this bug.

Memory card with four contacts:
1. One contact: Only with name.
2. Second contact: Name and surname.
3. Third contact: Name, surname and mobile
4. Four contact: Name, surname, mobile and photo.

First and second contact have been duplicated, and third and fourth haven't been duplicated.

For this reason this bug have been verified in 2.1:
Hamachi
2.1
Gecko-af6ad08
Gaia-2863c6e

Comment 8

[Maria Angeles Oteo (:oteo)]

Nominating to 2.0 as this is a regression (1.4 version is working fine) and QA has already verified that the patch solves the problem in 2.1

Comment 9

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/adc8e8ecaaecff4aad8c44d835aa44256df374cd

Comment 10

[Loli (:lolimartinezcr)]

Tested and working
2.0
Hamachi
Gecko-e50f6b7
Gaia-3bfe47c

Comment 11

[Mike Lien[:mlien]]

verify with Flame KK v180 + v2.0 gaia/gecko, it's fine
Gaia      7edd3b0b9f65c3dde235c732d270e43e055a1254
Gecko     https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/13e04ab68621
BuildID   20140914162307
Version   32.0