1021582 - Upcoming changes in Firefox 24.6.0 ESR break mingw-w64 compilation in jstypedarray.cpp

Status: RESOLVED DUPLICATE of bug 1019003

(Core :: JavaScript Engine, defect)

Description

[Georg Koppen]

Compiling Firefox ESR 24.6.0 with mingw-w64 results in an error:

/home/ubuntu/build/tor-browser/js/src/jstypedarray.cpp:3486:1: error: external linkage required for symbol 'js::detail::Int8ArrayClassPtr' because of 'dllexport' attribute
/home/ubuntu/build/tor-browser/js/src/jstypedarray.cpp:3487:1: error: external linkage required for symbol 'js::detail::Uint8ArrayClassPtr' because of 'dllexport' attribute
/home/ubuntu/build/tor-browser/js/src/jstypedarray.cpp:3488:1: error: external linkage required for symbol 'js::detail::Uint8ClampedArrayClassPtr' because of 'dllexport' attribute
/home/ubuntu/build/tor-browser/js/src/jstypedarray.cpp:3489:1: error: external linkage required for symbol 'js::detail::Int16ArrayClassPtr' because of 'dllexport' attribute
/home/ubuntu/build/tor-browser/js/src/jstypedarray.cpp:3490:1: error: external linkage required for symbol 'js::detail::Uint16ArrayClassPtr' because of 'dllexport' attribute
/home/ubuntu/build/tor-browser/js/src/jstypedarray.cpp:3491:1: error: external linkage required for symbol 'js::detail::Int32ArrayClassPtr' because of 'dllexport' attribute
/home/ubuntu/build/tor-browser/js/src/jstypedarray.cpp:3492:1: error: external linkage required for symbol 'js::detail::Uint32ArrayClassPtr' because of 'dllexport' attribute
/home/ubuntu/build/tor-browser/js/src/jstypedarray.cpp:3493:1: error: external linkage required for symbol 'js::detail::Float32ArrayClassPtr' because of 'dllexport' attribute
/home/ubuntu/build/tor-browser/js/src/jstypedarray.cpp:3494:1: error: external linkage required for symbol 'js::detail::Float64ArrayClassPtr' because of 'dllexport' attribute
/home/ubuntu/build/tor-browser/js/src/jsstr.cpp: In function 'JSBool js::str_split(JSContext*, unsigned int, JS::Value*)':
/home/ubuntu/build/tor-browser/js/src/jsstr.cpp:2924:70: warning: 'result.SplitMatchResult::length_' may be used uninitialized in this function [-Wuninitialized]
/home/ubuntu/build/tor-browser/js/src/jsstr.cpp:2852:22: note: 'result.SplitMatchResult::length_' was declared here
/home/ubuntu/build/tor-browser/js/src/jsstr.cpp:2913:9: warning: 'result.SplitMatchResult::endIndex_' may be used uninitialized in this function [-Wuninitialized]
/home/ubuntu/build/tor-browser/js/src/jsstr.cpp:2852:22: note: 'result.SplitMatchResult::endIndex_' was declared here
make[5]: *** [jstypedarray.o] Error 1
make[5]: *** Waiting for unfinished jobs....
make[5]: Leaving directory `/home/ubuntu/build/tor-browser/obj-mingw/js/src'
make[4]: *** [default] Error 2
make[4]: Leaving directory `/home/ubuntu/build/tor-browser/obj-mingw/js/src'
make[3]: *** [tier_js] Error 2
make[3]: Leaving directory `/home/ubuntu/build/tor-browser/obj-mingw'
make[2]: *** [default] Error 2
make[2]: Leaving directory `/home/ubuntu/build/tor-browser/obj-mingw'
make[1]: *** [realbuild] Error 2
make[1]: Leaving directory `/home/ubuntu/build/tor-browser'
make: *** [build] Error 2

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

CCing Waldo as he made these changes.

Comment 2

[Jacek Caban]

It's a fixed in bug 1019003. Should we cherry-pick that to esr branch?

Comment 3

[Benjamin Bouvier [:bbouvier] (inactive)]

(In reply to Jacek Caban from comment #2)
> It's a fixed in bug 1019003. Should we cherry-pick that to esr branch?

Sure. I will make the uplift request. If you can confirm that it fixes the build for you, feel free to close the bug as duplicate, otherwise I'll do it once I have your confirmation. Thanks for the report!

Comment 4

[Georg Koppen]

The patch in bug 1019003 applied to ESR 24.6.0 fixes the problem for me. Thanks!

Comment 5

[Benjamin Bouvier [:bbouvier] (inactive)]

Cool, thanks for confirming that!