1019003 - Build warning: ‘visibility’ attribute ignored [-Wattributes] in TypedArrayObject.cpp

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: warning-js-default-visibility.patch

These ArrayClassPtr are already defined as JS_FRIEND_DATA in jsfriendapi.h, so it doesn't seem needed in TypedArrayObject.cpp.

The shell compiles without any issue when disabling it. The full browser does too (gcc 4.8.2). Do you think it'd need a try build?

In file included from /home/ben/code/moz/builds/wd64/js/src/Unified_cpp_js_src11.cpp:28:0:
/home/ben/code/moz/inbound/js/src/vm/TypedArrayObject.cpp:2105:1251: warning: ‘visibility’ attribute ignored [-Wattributes]
 IMPL_TYPED_ARRAY_JSAPI_CONSTRUCTORS(Float32, float)

Comment 1

[Jeff Walden [:Waldo]]

Comment on attachment 8432552 [details] [diff] [review]
warning-js-default-visibility.patch

Review of attachment 8432552 [details] [diff] [review]:
-----------------------------------------------------------------

I wouldn't bother tryservering, myself.

Comment 3

[Benjamin Bouvier [:bbouvier] (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b4376eee6dea

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b4376eee6dea

Comment 5

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: bug1019003.patch

[Aurora/Beta Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 991981
User impact if declined: can't build with Mingw (as stated in bug 1021582, it's used for cross-compilation of the Tor bundle project).
Testing completed (on m-c, etc.): m-i, m-c
Risk to taking this patch (and alternatives if risky): no risk, build passed on all platforms.
String or IDL/UUID changes made by this patch: n/a

[ESR Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration:
User impact if declined: can't build with Mingw (as stated in bug 1021582, it's used for cross-compilation of the Tor bundle project).
Fix Landed on Version: current Nightly.
Risk to taking this patch (and alternatives if risky): no risk, build passed on all platforms.
String or UUID changes made by this patch: n/a


Apparently, there was a build error caused by this on mingw (see also bug 1021582), so we should uplift that to all versions that received the uplift for bug 991981.

Carrying forward r+ from Waldo.

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8435639 [details] [diff] [review]
bug1019003.patch

Too late for beta/release.

Accepting for ESR since the Tor project is using esr (like Debian).

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/082d356f509c

esr24 is going to need a branch-specific patch.

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Ben, should this have tests or be in the test suite?  Thanks!

Comment 10

[Jeff Walden [:Waldo]]

Attachment: ESR24 backport of a visibility warning-fix

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Thanks :)

https://hg.mozilla.org/releases/mozilla-esr24/rev/178814d7bc15

Comment 12

[Lawrence Mandel [:lmandel] (use needinfo)]

This just missed the ESR 24.6.0 build #2. Can this be worked around in the 24.6.0 cycle so that we don't have to respin?

Comment 13

[Benjamin Bouvier [:bbouvier] (inactive)]

(In reply to Liz Henry :lizzard from comment #9)
> Ben, should this have tests or be in the test suite?  Thanks!

We can't actually test that, as it's a build warning in the best case, a build failure for cross compilation in the worst case (and that cross compilation build is not included in our CI platform).