102184 - javascript strict warnings in tabbrowser.xml

Status: VERIFIED FIXED

(SeaMonkey :: Tabbed Browser, defect)

Description

[Henrik Gemal]

Whoever checkedin tabbrowser.xml should get spanked!!!!!

TURN ON JAVASCRIPT STRICT WARNINGS IN THE "EDIT -> PREFS -> DEBUG" SO WE COULD
AVOID ALL THE STRICT WARNING FIXUP...!!!!!!!!!!!!

Warning: redeclaration of var webProgress
Source File:
chrome://global/content/bindings/tabbrowser.xml#tabbrowser.updateCurrentBrowser()
Line: 26, Column: 18
Source Code:
              var webProgress = this.mCurrentBrowser.webProgress;

Warning: redeclaration of var i
Source File:
chrome://global/content/bindings/tabbrowser.xml#tabbrowser.updateCurrentBrowser()
Line: 27, Column: 23
Source Code:
              for (var i = 0; i < this.mProgressListeners.length; i++) {

Warning: redeclaration of var p
Source File:
chrome://global/content/bindings/tabbrowser.xml#tabbrowser.updateCurrentBrowser()
Line: 28, Column: 20
Source Code:
                var p = this.mProgressListeners[i];

Warning: redeclaration of var webProgress
Source File:
chrome://global/content/bindings/tabbrowser.xml#tabbrowser.updateCurrentBrowser()
Line: 38, Column: 18
Source Code:
              var webProgress = this.mCurrentBrowser.webProgress;

Warning: redeclaration of var i
Source File:
chrome://global/content/bindings/tabbrowser.xml#tabbrowser.updateCurrentBrowser()
Line: 39, Column: 23
Source Code:
              for (var i = 0; i < this.mProgressListeners.length; i++) {

Warning: redeclaration of var p
Source File:
chrome://global/content/bindings/tabbrowser.xml#tabbrowser.updateCurrentBrowser()
Line: 40, Column: 20
Source Code:
                var p = this.mProgressListeners[i];

Comment 1

[Henrik Gemal]

Hyatt: please please please please:
turn on javascript strict warnings in the "Edit -> Prefs -> Debug" so we could
avoid all the strict warning fixup...!

Comment 2

[Christopher Aillon (sabbatical, not receiving bugmail)]

*** Bug 104656 has been marked as a duplicate of this bug. ***

Comment 3

[Christopher Aillon (sabbatical, not receiving bugmail)]

fwiw, recently duped bug 104656 has a partial patch...

Comment 4

[Phil Pishioneri]

Additional (not strict) error: in build 2001102903 (windows 98se), I'm seeing

Error: mBlank is not defined
Source File:
chrome://global/content/bindings/tabbrowser.xml#tabbrowser.mTabProgressListener()
Line: 90

Comment 5

[Henrik Gemal]

the mBlank error is:
http://bugzilla.mozilla.org/show_bug.cgi?id=107094

Comment 6

[Niklas Mehner]

Attachment: Fix for this bug

Fixes the warnings. Only the change in the method getBrowserForTab() is a
little more than a one line change.

Comment 7

[sairuh (rarely reading bugmail)]

spam: set your filter for "SeverusSnape" to avoid the influx of bugmail

changing QA contact of open tabbed browser bugs from blake to me. if this bug
requires a reassignment, however, feel free to change it!

Comment 8

[sairuh (rarely reading bugmail)]

jag, could you review the patch here? thx!

oh, an additional js error:

Warning: function getBrowserForTab does not always return a value
Source File:
chrome://global/content/bindings/tabbrowser.xml#tabbrowser.getBrowserForTab()
Line: 14, Column: 7
Source Code:

Comment 9

[jag (Peter Annema)]

Comment on attachment 58977 [details] [diff] [review]
Fix for this bug

r=jag

Comment 10

[Joe Hewitt (gone)]

Comment on attachment 58977 [details] [diff] [review]
Fix for this bug

sr=hewitt

Comment 11

[jag (Peter Annema)]

Sairuh: the js warning you cited should be fixed by this patch too.

Checked in.

Comment 12

[sairuh (rarely reading bugmail)]

yep, no longer see these errors. vrfy fixed using 2002.01.07.08 comm bits on
linux rh7.2.