1021900 - Preference intl.charset.default referenced but not used on fonts.xul

Status: RESOLVED DUPLICATE of bug 1140720

(Thunderbird :: Preferences, defect)

Description

[Javi Rueda :javirid]

On http://mxr.mozilla.org/comm-central/source/mail/components/preferences/fonts.xul#40 there is a reference to intl.charset.default preference but it is never used nor in the XUL neither on corresponding JS.

http://mxr.mozilla.org/comm-central/search?string=intl.charset.default

Comment 1

[Nomis101]

It is defined in the l10n files:
http://mxr.mozilla.org/l10n-central/search?string=intl.charset.default

Comment 2

[:aceman]

This is probably due to the recent reworks of the charset menus in toolkit and resulting breakage of many charset menupopup throughout c-c. I think there was a bug for it already.

Comment 3

[Javi Rueda :javirid]

Neither fonts.xul nor fonts.js haven't used this preference ever.

http://mxr.mozilla.org/comm-central/source/mail/components/preferences/fonts.xul?rev=e4f4569d451a

http://mxr.mozilla.org/comm-central/source/mail/components/preferences/fonts.js?rev=e4f4569d451a#167

Those are the older versions available on comm-central repository. At the XUL file, it just appears at the <preference> block. At the JS file, there is no single line of code trying to access it.

What I am asking myself is why it is necessary to reference in XUL a <preference> but not using it at all :/ :\

Comment 4

[:aceman]

OK, this pref doesn't seem to be used anywhere in the tree:
http://mxr.mozilla.org/comm-central/search?string=intl.charset.default&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central, only in one instance at editor.

It is also seen in the Seamonkey preferences at /suite/common/pref/pref-languages.xul without any JS usage.

Comment 5

[:aceman]

Either we need to do what bug 934492 is doing for SM, or we do not need it in Thunderbird.

Comment 6

[aleth [:aleth]]

Reference removed as part of bug 1140720.