Closed Bug 1022098 Opened 5 years ago Closed 5 years ago
[Vertical] Show default icon if download of the real icon fails
+++ This bug was initially created as a clone of Bug #1020722 +++ The current homescreen has functionality which will allow you to continue an app download (by tapping it) if it fails for some reason this should be ported over to the vertical home screen.
596.36 KB, application/pdf
83 bytes, text/plain
117.44 KB, application/zip
46 bytes, text/x-github-pull-request
|Details | Review|
Currently we show no icon (blank) if a hosted app icon fails to download.
Taking this... it ended up in my WIP patch for some icon reworking in preparation of dealing with some more error/retry states.
Assignee: crdlc → jlal
feature-b2g: --- → 2.0
Target Milestone: --- → 2.0 S4 (20june)
Hi James, I'll be attaching a visual spec for app install tomorrow. This will include this state as well. Stay tuned.
Great! Depending on the order we will get some logic for this tomorrow (Tues PST) which should be better then what we have now at least then I will tackle the changes in the update.
QA Whiteboard: [VH-FL-blocking+] → [VH-FL-blocking+][VH-FC-blocking+]
Attaching spec that includes the app installation states in a bit more detail. Let me know if there are any questions.
https://github.com/mozilla-b2g/gaia/commit/5438f4773400a77f4d04f9e120a3c488c699ef7b I am going to move out the visual design state to another bug
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Verified with download error and download cancelled on master.
Status: RESOLVED → VERIFIED
This is needed for the vertical homescreen. We've put forward a best effort to believe that this is safe for uplift and the tree will remain green.
Attachment #8438704 - Flags: approval-gaia-v2.0?(bbajaj)
Comment on attachment 8438704 [details] Github commit Thanks for the proactive verification Johan!
Attachment #8438704 - Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+
This test was originally checked in with a wrong name, meaning it was not being run on CI. Trying to move and fix the tests now.
You need to log in before you can comment on or make changes to this bug.