Closed Bug 1022098 Opened 10 years ago Closed 10 years ago

[Vertical] Show default icon if download of the real icon fails

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Homescreen
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(feature-b2g:2.0, b2g-v2.0 fixed, b2g-v2.1 fixed)

Status:
VERIFIED FIXED
Milestone:
2.0 S4 (20june)
Project Flags:
feature-b2g 2.0
Tracking Flags:
Tracking Status
b2g-v2.0 --- fixed
b2g-v2.1 --- fixed

People

(Reporter: jlal, Assigned: jlal)

References

Details

(Whiteboard: [systemsfe])

User Story

+++ This bug was initially created as a clone of Bug #1020722 +++

The current homescreen has functionality which will allow you to continue an app download (by tapping it) if it fails for some reason this should be ported over to the vertical home screen.

Attachments

(4 files)

App Download June10.pdf
596.36 KB, application/pdf
Details
Github commit
83 bytes, text/plain
bajaj
: approval-gaia-v2.0+
Details
AppInstallVisualAssets.zip
117.44 KB, application/zip
Details
Github pull request
46 bytes, text/x-github-pull-request
Details | Review 
Currently we show no icon (blank) if a hosted app icon fails to download.
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Taking this... it ended up in my WIP patch for some icon reworking in preparation of dealing with some more error/retry states.
Assignee: crdlc → jlal
QA Whiteboard: [VH-FL-blocking+]
feature-b2g: --- → 2.0
Target Milestone: --- → 2.0 S4 (20june)
Whiteboard: [systemsfe]
Hi James,

I'll be attaching a visual spec for app install tomorrow.  This will include this state as well.  Stay tuned.
Depends on: 1022247
Great! Depending on the order we will get some logic for this tomorrow (Tues PST) which should be better then what we have now at least then I will tackle the changes in the update.
QA Whiteboard: [VH-FL-blocking+] → [VH-FL-blocking+][VH-FC-blocking+]
Attaching spec that includes the app installation states in a bit more detail. Let me know if there are any questions.
https://github.com/mozilla-b2g/gaia/commit/5438f4773400a77f4d04f9e120a3c488c699ef7b

I am going to move out the visual design state to another bug
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Verified with download error and download cancelled on master.
Status: RESOLVED → VERIFIED
Attached file Github commit — 
This is needed for the vertical homescreen. We've put forward a best effort to believe that this is safe for uplift and the tree will remain green.
Attachment #8438704 - Flags: approval-gaia-v2.0?(bbajaj)
Comment on attachment 8438704 [details]
Github commit

Thanks for the  proactive verification Johan!
Attachment #8438704 - Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+

    
  
blocking-b2g: --- → 2.0?
blocking-b2g: 2.0? → ---

    
    

    
  

      
      
      
      

        Attached file
          
        Github pull request
        — 
      

    


  
This test was originally checked in with a wrong name, meaning it was not being run on CI. Trying to move and fix the tests now.
Flags: in-moztrap?(jlorenzo)
Flags: in-moztrap?(jlorenzo)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: