102215 - Message display messed up by xul syntax changes

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Scott MacGregor]

XUL syntax changes to use align="center" and the pack attribute appear to have
caused some UI issues in the message pane. 

In particular:
1) When viewing messages with a lot of recipients, the To and cc fields actually
move into the middle. i..e
    [e-mail]
    [e-mail]
    [e-mail]
To: [e-mail]
    [e-mail]
    [e-mail]

The to should stay at to the top on the same line as the first address.
Collapsing the to field using the toggle causes it to jump back up to the first
line. The jumping around behavior looks very strange.

I can easily fix this part of the problem by undoing Joe's change to add
align="center" to all of the email address fields. making these align="top"
instead fixes that problem. 

However that still doesn't fix the problem with the toggle. Now the toggle is
way at the top and isn't centered vertically with respect to the header name. 

i.e.
->
   To:
instead of
-> To:

I'm still trying to fix that problem. Will probably need Joe's help for that. 

Due to the high UI visibility and the fact that the patch is going to have
pretty much 0 risk, I'm going to try to get this into the branch.

Comment 1

[Scott MacGregor]

Another example of the problem is with long subject lines which wrap. Today
you'll get:

         Hello there. Here's an easy way to win
SUBJECT: easy money while still keeping your current job. 
         Try This Now.

Basically if any of the headers require wrapping we'll get this centered header
name. 

Comment 2

[Scott MacGregor]

Attachment: first part of the fix. Fix the vertical alignment of the header names

Comment 3

[Scott MacGregor]

this patch fixes the bulk of the problems. However the twisties are still not
lining up right after this patch. I'll need help from hewitt to figure out how
to get them centered again within the current line.

Comment 4

[Jaime Rodriguez, Jr.]

Adding PDT to keep on our radar. This looks like something we'd like to take.

Comment 5

[Scott MacGregor]

Attachment: new fix to recenter the toggle icons too

Comment 6

[Joe Hewitt (gone)]

sr=hewitt

Comment 7

[(not reading, please use [e-mail] instead)]

Comment on attachment 51364 [details] [diff] [review]
new fix to recenter the toggle icons too

r=sspitzer

Comment 8

[Scott MacGregor]

Comment on attachment 51364 [details] [diff] [review]
new fix to recenter the toggle icons too

sr=hewitt, r=sspitzer

Comment 9

[Scott MacGregor]

this is now in the trunnk.

Comment 10

[[e-mail] (gone - use [e-mail] instead)]

So isn't this bug 91244, which was already triaged ('not an emojo stopper')?

Comment 11

[Jaime Rodriguez, Jr.]

I think we should get a response to Donner's question, before we plus this one
... waiting

Comment 12

[Scott MacGregor]

*** Bug 91244 has been marked as a duplicate of this bug. ***

Comment 13

[Jaime Rodriguez, Jr.]

pls check it in today if you can - PDT+

Comment 14

[Scott MacGregor]

This is now in the branch and the trunk. 

Comment 15

[esther]

Using build 2001-10-01 branch on winxp, lunux macosx and macos9.1 this is fixed,
adding vtrunk for more verification.

Comment 16

[esther]

Verified on trunk 2001-10-01 on winxp, macos9.1 and linux. Verified.  I used
Scott's scenario with a long Subject.  I saw the problem with 9-27 branch builds
and verified on 10-01-01 branch & trunk commercial builds.