Closed Bug 1022212 Opened 6 years ago Closed 6 years ago

Enable WebRTC load adaptation by default

Categories

(Core :: WebRTC: Audio/Video, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: jesup, Assigned: jesup)

References

Details

Attachments

(1 file)

Per private conversation, the load adaptation code is ready to enable by default, and works across all platforms (and even BSD).
I'm seeing a lot of webrtc-related crashes on inbound since this landed. Hard to tell for sure given the high rate of crashes we were already seeing before (*sigh*), but it still does appear to have ticked upwards a bit.
Flags: needinfo?(rjesup)
Depends on: 1022235
Depends on: 1022376
https://hg.mozilla.org/integration/mozilla-inbound/rev/6cc9ac1f57fa
No longer will leak threads.  Timing changes could affect the root cause for the crashtest bugs still.
So we're still expecting the crashes? Good, I guess...
https://tbpl.mozilla.org/php/getParsedLog.php?id=41324327&tree=Mozilla-Inbound

Same as before, about to run out the door. Will backout when I return if you don't beat me to it.
Flags: needinfo?(rjesup)
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #6)
> So we're still expecting the crashes? Good, I guess...
> https://tbpl.mozilla.org/php/getParsedLog.php?id=41324327&tree=Mozilla-
> Inbound
> 
> Same as before, about to run out the door. Will backout when I return if you
> don't beat me to it.

Sorry, I think I wasn't clear.  The underlying cause of a lot of crashes is an ASAN problem that is not caused by LoadManager (and apparently recent).  The bug in load manager that leaked threads seemed to provoke the ASAN bug and cause more-frequent hits esp on Android.  Removing that bug hopefully will cause this to no longer provoke the ASAN bug more than normal; but in any case the ASAN bug is splattering all over the tree, with or without load manager.

I plan to dig into the ASAN bug later tonight.
Flags: needinfo?(rjesup)
https://hg.mozilla.org/mozilla-central/rev/6cc9ac1f57fa
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
This push backed out for Android crashes during 408431-1.html:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&jobname=Android%204.0%20Panda%20mozilla-inbound%20opt%20test%20crashtest&fromchange=c66224db3600&tochange=6cc9ac1f57fa

I saw bug 1022235 comment 8 - however the existing 408431-1.html crashes were on other platforms - Android 4.0 debug m-6 was green before, with these two changesets, it isn't.

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/dc93584a0948
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Relanding with agreement in IRC from edmorely -- see bug 1022235
https://hg.mozilla.org/integration/mozilla-inbound/rev/fc05ea905ce5
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
Depends on: 1023712
You need to log in before you can comment on or make changes to this bug.