1022433 - Browser's domain-not-found message is missing the domain name ("Can't find the server at .")

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Daniel Holbert [:dholbert]]

STR:
 1. Visit http://aaaa.mozilla.org or some other nonexistent domain in the Firefox OS browser app.

ACTUAL RESULTS:
Browser displays this message:
> Server not found
> Can't find the server at .

EXPECTED RESULTS:
Looks like the domain name is supposed to be included between "at" and the "."



I'm using a Flame device, running a locally-built version of B2G trunk.
OS Version: 2.0.0.0-prerelease
Git commit info: 2014-06-08 87a937c5
(I also remember seeing this on an Unagi w/ B2G trunk a week or so ago, too.)

Comment 1

[Daniel Holbert [:dholbert]]

Also:
- Firefox OS 2.0 in the simulator reproduces the problem.
- Firefox OS 1.4 in the simulator works correctly. (It displays the domain name.)

So this is a regression.

Comment 2

[Jason Smith [:jsmith]]

QA Wanted - can we get a screenshot?

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: screenshot from Firefox OS 1.4 in simulator (showing correct error-message)

Comment 4

[Daniel Holbert [:dholbert]]

Attachment: screenshot from Firefox OS 2.0 in simulator (showing broken error-message)

Comment 5

[Joshua Mitchell (Inactive)]

B2G Inbound Regression Window:

Last Working:
Environmental Variables:
Device: Flame Master
Build ID: 20140417180011
Gaia: e3474caf17e7e2a30e5d99f29dbf3413cb24cc12
Gecko: e224847eaf96
Version: 31.0a1 (Master) 
Firmware Version: v10G-2

First Broken:
Environmental Variables:
Device: Flame Master
Build ID: 20140418000002
Gaia: acfa2cccdbd7d23c9b51a930be78f7ef19a6b925
Gecko: 9772ba4d13bf
Version: 31.0a1 (Master) 
Firmware Version: v10G-2

Last Working Gaia First Broken Gecko: Issue does NOT reproduce
Gaia: e3474caf17e7e2a30e5d99f29dbf3413cb24cc12
Gecko: 9772ba4d13bf

First Broken Gaia Last Working Gecko: Issue DOES reproduce
Gaia: acfa2cccdbd7d23c9b51a930be78f7ef19a6b925
Gecko: e224847eaf96

Gaia pushlog: https://github.com/mozilla-b2g/gaia/compare/e3474caf17e7e2a30e5d99f29dbf3413cb24cc12...acfa2cccdbd7d23c9b51a930be78f7ef19a6b925

Comment 6

[Daniel Holbert [:dholbert]]

Thanks. Given that range, looks likely to be a regression from bug 912445. ("Show specific information when there is a server connection issue with an application")

Comment 7

[Daniel Holbert [:dholbert]]

Albert, looks like your patch in bug 912445 may have caused this. Do you have cycles to take a look at this? (or can you suggest someone who might?)

Comment 8

[Albert [:albert]]

(In reply to Daniel Holbert [:dholbert] from comment #7)
> Albert, looks like your patch in bug 912445 may have caused this. Do you
> have cycles to take a look at this? (or can you suggest someone who might?)

I can work on it.

Comment 9

[Albert [:albert]]

I found the root problem and have a fix for it but I'm not able to reproduce the bug. When I open a wrong url the browser shows a blank page instead of the error page. Tried master and 1.4.

Comment 11

[Albert [:albert]]

Attachment: Patch

Comment 13

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8439818 [details]
Patch

Code looks good, and I can confirm this fixes the issue. Good work!

Albert, please add a unit test that would fail before adding this patch. Then I think we are good to land.

Comment 14

[Albert [:albert]]

(In reply to Michael Henretty [:mhenretty] from comment #13)
> Comment on attachment 8439818 [details]
> Patch
> 
> Code looks good, and I can confirm this fixes the issue. Good work!
> 
> Albert, please add a unit test that would fail before adding this patch.
> Then I think we are good to land.

Tests added and travis is green.

Comment 15

[Albert [:albert]]

Master: https://github.com/mozilla-b2g/gaia/commit/1412afd61342da6a0517c7bd2e5e22ef57715517

Comment 16

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/c35bc525232bb66089f729dd887e21436a385ab2

Comment 17

[sarsenyev]

Verified the issue is fixed on 2.1 and 2.0 Flame builds

"Server" not found" message appears with complete address 

Device: Flame 2.1
BuildID: 20141103001220
Gaia: 027a7de0c95320cea0579bfd1a4ceef3e9038f34
Gecko: ffecb2be228b
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 34.0 (2.1)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
  
Device: Flame 2.0
BuildID: 20141103000201
Gaia: 7b8df9941700c1f6d6d51ff464f0c8ae32008cd2
Gecko: 82a6ed695964
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 32.0 (2.0)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0
  
Notes: