1022564 - Border of arrow panels lack contrast when using High Contrast mode

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect, P3)

Description

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Screenshot - panel

The border of our panels lack contrast when using High Contrast mode. It should use the same color as the border of normal menu popups. See screenshots for comparison.

Comment 1

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Screenshot - menu

Comment 2

[Dão Gottwald [:dao]]

This is ThreeDShadow (i.e. a native color), isn't it?

Comment 3

[Dão Gottwald [:dao]]

I think we can make the border stronger by just replacing ThreeDShadow with ThreeDDarkShadow here:

toolkit/themes/windows/global/arrow/panelarrow-vertical-themed.svg

and in the --panel-arrowcontent-border variable here:

toolkit/themes/windows/global/popup.css

Comment 4

[Dão Gottwald [:dao]]

I believe this is a widget bug. In high contrast mode, ThreeDShadow (used by arrow panels) provides less contrast than ThreeDLightShadow, which seems backwards.

Comment 5

[Jim Mathies [:jimm]]

(In reply to Dão Gottwald [:dao] from comment #4)
> I believe this is a widget bug. In high contrast mode, ThreeDShadow (used by
> arrow panels) provides less contrast than ThreeDLightShadow, which seems
> backwards.

ThreeDLightShadow returns COLOR_3DLIGHT
ThreeDShadow returns COLOR_3DSHADOW

http://searchfox.org/mozilla-central/rev/767e1e9b118269f957ca1817138472146278a29e/widget/windows/nsLookAndFeel.cpp#241

We can change the above easily if we need to.

Standard win7 themes with glass:
 COLOR_3DLIGHT = light gray
 COLOR_3DSHADOW = dark gray

High contrast, dark: 
 COLOR_3DLIGHT = white
 COLOR_3DSHADOW = dark gray

Maybe we need to chose a different css value here. MSDN describes the two as:

COLOR_3DLIGHT (ThreeDLightShadow) - "Light color for three-dimensional display elements (for edges facing the light source.)"
COLOR_3DSHADOW (ThreeDShadow) - "Shadow color for three-dimensional display elements (for edges facing away from the light source)."

Comment 6

[Dão Gottwald [:dao]]

(In reply to Jim Mathies [:jimm] from comment #5)
> Maybe we need to chose a different css value here. MSDN describes the two as:
> 
> COLOR_3DLIGHT (ThreeDLightShadow) - "Light color for three-dimensional
> display elements (for edges facing the light source.)"
> COLOR_3DSHADOW (ThreeDShadow) - "Shadow color for three-dimensional display
> elements (for edges facing away from the light source)."

You're right, we're abusing these colors, so that's why the contrasts are backwards with dark themes. This actually shows in many places using ThreeDShadow and ThreeDLightShadow where we expect ThreeDLightShadow to provide lower contrast and get the opposite effect in high contrast mode.

I don't think there's any other color available for these kind borders. Maybe we could generate something ourselves based on the Window or -moz-dialog colors, or based on ThreeDShadow? If I remember correctly Gtk widget code already generates ThreeDLightShadow and ThreeDDarkShadow based on ThreeDShadow rather than getting them directly from the OS.

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information

Comment 9

[Dão Gottwald [:dao]]

Attachment: Bug 1022564 - Increase contrast of the arrow panel border in High Contrast mode. r=Itiel

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c3c18577116e
Increase contrast of the arrow panel border in High Contrast mode. r=Itiel

Comment 11

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/c3c18577116e