1022579 - Help buttons in about:preferences have no icon when using High Contrast mode

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Screenshot

The help buttons in about:preferences just look like an square box with no icon, when using High Contrast mode. See attached screenshot.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

We can fix this by using SVG for the help icon and then using the right CSS system color values for the color of the glyph (like bug 1016405).

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Michael, can you attach an SVG version of the help icon (question mark)?

Comment 3

[Michael Maslaney [:mmaslaney] ([e-mail])]

Attachment: FX_inContent-help-16x16.svg

Help SVG attached.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Thanks for the SVG, we can use the same bug for implementation.

Comment 5

[Tim Nguyen :ntim]

Attachment: Patch

I had to change from bg-image to list-style-image, since bg-images didn't show on high-contrast themes.

Comment 6

[Matthew N. [:MattN]]

https://hg.mozilla.org/integration/fx-team/rev/68a30a046bc5

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/68a30a046bc5

Comment 8

[Camelia Badau [:cbadau], Desktop Test Engineering]

Verified fixed on Windows 7 64bit, Windows 8.1 64 bit and Windows 8 32bit using latest Nightly 36.0a1 (buildID: 20141127030208).