Closed Bug 1022579 Opened 5 years ago Closed 5 years ago

Help buttons in about:preferences have no icon when using High Contrast mode

Categories

(Firefox :: Preferences, defect)

30 Branch
x86_64
Windows 8.1
defect
Not set
Points:
2

Tracking

()

VERIFIED FIXED
Firefox 36
Iteration:
36.3

People

(Reporter: Unfocused, Assigned: ntim)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

Attached image Screenshot
The help buttons in about:preferences just look like an square box with no icon, when using High Contrast mode. See attached screenshot.
Flags: firefox-backlog+
We can fix this by using SVG for the help icon and then using the right CSS system color values for the color of the glyph (like bug 1016405).
Michael, can you attach an SVG version of the help icon (question mark)?
Points: --- → 2
Flags: needinfo?(mmaslaney)
Whiteboard: p=2
Assignee: nobody → mmaslaney
Flags: needinfo?(mmaslaney)
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Thanks for the SVG, we can use the same bug for implementation.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → NEW
Assignee: mmaslaney → nobody
Flags: qe-verify?
Assignee: nobody → ntim007
Status: NEW → ASSIGNED
Attached patch PatchSplinter Review
I had to change from bg-image to list-style-image, since bg-images didn't show on high-contrast themes.
Attachment #8519471 - Flags: review?(jaws)
Attachment #8519471 - Flags: review?(jaws) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/68a30a046bc5
Status: ASSIGNED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
Iteration: --- → 36.3
Verified fixed on Windows 7 64bit, Windows 8.1 64 bit and Windows 8 32bit using latest Nightly 36.0a1 (buildID: 20141127030208).
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.