Closed
Bug 1022604
Opened 11 years ago
Closed 8 years ago
Customize Mode's exit button should be more legible in High Contrast mode
Categories
(Firefox :: Theme, defect, P4)
Tracking
()
VERIFIED
FIXED
Firefox 51
Tracking | Status | |
---|---|---|
firefox51 | --- | verified |
People
(Reporter: Unfocused, Assigned: dao)
References
(Blocks 1 open bug)
Details
Attachments
(2 files, 1 obsolete file)
294.97 KB,
image/png
|
Details | |
2.89 KB,
patch
|
shorlander
:
review+
|
Details | Diff | Splinter Review |
Customize Mode's exit button has a colored background, reducing contrast and thereby reducing legibility (and prettiness) for people needing high contrast. See attached screenshot.
Flags: firefox-backlog+
Updated•10 years ago
|
Points: --- → 2
Whiteboard: p=2
Assignee | ||
Updated•8 years ago
|
Priority: -- → P4
Assignee | ||
Comment 1•8 years ago
|
||
This makes the green darker too meet WCAG 2.0 level AAA. Alternatively, we could keep the current green and make the text black, but this somehow looked weird to me.
Assignee | ||
Updated•8 years ago
|
Component: Toolbars and Customization → Theme
Comment 2•8 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #1)
> Created attachment 8780794 [details] [diff] [review]
> patch
>
> This makes the green darker too meet WCAG 2.0 level AAA. Alternatively, we
> could keep the current green and make the text black, but this somehow
> looked weird to me.
This looks good, but I would like to bikeshed on the colors a bit :)
We have been (slowly) doing an inventory on colors and trying to make them consistent. I put together an overview here: https://mozilla.invisionapp.com/share/BZ4692P6D#/screens/101883045
Can we please use #fff on #2f811a for the normal state and #fff on #276e17 for the hover state?
These should pass meet the contrast recommendation:
http://leaverou.github.io/contrast-ratio/#%23fff-on-%232f811a
http://leaverou.github.io/contrast-ratio/#%23fff-on-%23276e17
#2f811a in different formats:
rgba(47, 129, 26, 1)
hsla(108, 66%, 30%, 1)
#276e17 in different formats:
rgba(39, 110, 23, 1)
hsla(109, 65%, 26%, 1)
Assignee | ||
Comment 3•8 years ago
|
||
Attachment #8780794 -
Attachment is obsolete: true
Attachment #8780794 -
Flags: review?(shorlander)
Attachment #8790802 -
Flags: review?(shorlander)
Comment 4•8 years ago
|
||
Comment on attachment 8790802 [details] [diff] [review]
patch v2
Review of attachment 8790802 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, thank you!
Attachment #8790802 -
Flags: review?(shorlander) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/16c9625e4fa1
Tweak customize mode's exit button colors to provide more contrast. r=shorlander
Comment 6•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Comment 7•8 years ago
|
||
I have reproduced this bug with Firefox nightly 32.0a1 (2014-06-09) on Windows 10, 64 Bit.
The Bug's fix is now verified on latest 51.0a1 (2016-09-15).
Build ID 20160915030417
User Agent Mozilla/5.0 (Windows NT 10.0; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0
[bugday-20160914]
You need to log in
before you can comment on or make changes to this bug.
Description
•