Fix and re-enable hg publisher

RESOLVED WONTFIX

Status

P2
normal
RESOLVED WONTFIX
5 years ago
2 years ago

People

(Reporter: mcote, Unassigned)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

5 years ago
In a thread on mozilla.tools.pulse, Axel Hecht said, concerning the hg publisher,

"As I observed that back in the days, the notifier crashed on various occasions, in particular file additions/removals/renames and merges made it go funky."

"That might have been because it tried to include everything and the sun in the message. IIRC, if it had reduced itself to 'repo, changesets, pusher, pushdate', things would have been OK."

We should reduce the scope of the publisher to what he suggested and then get it re-enabled.

Note that the publisher and consumer code was removed from mozillapulse in bug 1021542 since it was unsupported.  It should be re-enabled when the shim is fixed up (which is in the pulseshims repo, hg_shim.py).

Testing could be done with a local hg server and the vagrant box in the mozillapulse/tests directory.
(Reporter)

Comment 1

5 years ago
Adding existing hg-related bugs as blockers.  They may or may not still be relevant if the amount of data being sent is drastically reduced, but they need to be addressed and resolved one way or another before this bug is.
Depends on: 665123, 665118
Whiteboard: [lang=python][mcote=mcote] → [lang=python][mentor=mcote]
(Assignee)

Updated

5 years ago
Mentor: mcote
Whiteboard: [lang=python][mentor=mcote] → [lang=python]

Comment 2

4 years ago
Hi, where should I start?
(Reporter)

Comment 3

4 years ago
Hi, so just to be clear, I didn't mark this as a [good first bug] because it will take a fair bit of setup time.  The first step would be getting a local pulse setup working.  The easiest way would be to use the vagrant box in the mozillapulse Python package (https://hg.mozilla.org/automation/mozillapulse/).  Then it would be setting up an hg server and adding a hook that would write messages to pulse using something like http://hg.mozilla.org/build/tools/file/67cca6c691a6/buildbot-helpers/pulse_publisher.py, which is a way to separate the hg hook from the message-sending part (since we don't want that to block hg transactions).  It's interesting work, but it's a bit involved.

Updated

4 years ago
Blocks: 1017724
Blocks: 1049530

Updated

4 years ago
No longer blocks: 1017724
Blocks: 1048043

Updated

4 years ago
Blocks: 1065567

Updated

4 years ago
No longer blocks: 1048043
(Reporter)

Comment 4

4 years ago
Unmentoring this--this is really an advanced bug.
Priority: -- → P2
Whiteboard: [lang=python]
(Reporter)

Updated

4 years ago
Mentor: mcote

Updated

4 years ago
Blocks: 1084493

Comment 5

3 years ago
I presume this is redundant now (or else a dupe) given the solution in bug 1196915?

Updated

2 years ago
No longer blocks: 1065567

Updated

2 years ago
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WONTFIX

Updated

2 years ago
No longer blocks: 1049530

Updated

2 years ago
No longer blocks: 1084493

Comment 6

2 years ago
(In reply to Ed Morley [:emorley] from comment #5)
> I presume this is redundant now (or else a dupe) given the solution in bug
> 1196915?

Yes. If you need more from hg.mozilla.org's notification, file a hg.mozilla.org bug.
You need to log in before you can comment on or make changes to this bug.