1022701 - Fix and re-enable hg publisher

Status: RESOLVED WONTFIX

(Webtools :: Pulse, defect, P2)

Description

[Mark Côté [:mcote]]

In a thread on mozilla.tools.pulse, Axel Hecht said, concerning the hg publisher,

"As I observed that back in the days, the notifier crashed on various occasions, in particular file additions/removals/renames and merges made it go funky."

"That might have been because it tried to include everything and the sun in the message. IIRC, if it had reduced itself to 'repo, changesets, pusher, pushdate', things would have been OK."

We should reduce the scope of the publisher to what he suggested and then get it re-enabled.

Note that the publisher and consumer code was removed from mozillapulse in bug 1021542 since it was unsupported.  It should be re-enabled when the shim is fixed up (which is in the pulseshims repo, hg_shim.py).

Testing could be done with a local hg server and the vagrant box in the mozillapulse/tests directory.

Comment 1

[Mark Côté [:mcote]]

Adding existing hg-related bugs as blockers.  They may or may not still be relevant if the amount of data being sent is drastically reduced, but they need to be addressed and resolved one way or another before this bug is.

Comment 2

[farukuzun]

Hi, where should I start?

Comment 3

[Mark Côté [:mcote]]

Hi, so just to be clear, I didn't mark this as a [good first bug] because it will take a fair bit of setup time.  The first step would be getting a local pulse setup working.  The easiest way would be to use the vagrant box in the mozillapulse Python package (https://hg.mozilla.org/automation/mozillapulse/).  Then it would be setting up an hg server and adding a hook that would write messages to pulse using something like http://hg.mozilla.org/build/tools/file/67cca6c691a6/buildbot-helpers/pulse_publisher.py, which is a way to separate the hg hook from the message-sending part (since we don't want that to block hg transactions).  It's interesting work, but it's a bit involved.

Comment 4

[Mark Côté [:mcote]]

Unmentoring this--this is really an advanced bug.

Comment 5

[Ed Morley [:emorley]]

I presume this is redundant now (or else a dupe) given the solution in bug 1196915?

Comment 6

[Gregory Szorc [:gps]]

(In reply to Ed Morley [:emorley] from comment #5)
> I presume this is redundant now (or else a dupe) given the solution in bug
> 1196915?

Yes. If you need more from hg.mozilla.org's notification, file a hg.mozilla.org bug.