102276 - [ps] Need better error handling when lp not defined

Status: RESOLVED FIXED

(Core :: Printing: Output, defect, P2)

Description

[sujay]

from bug 92344

In 4.x if lp is not definted, it throws up an error panel with something
like this:  "lpr: lp: unknown printer". 

we need to do something like this for 6.x

Comment 1

[Roland Mainz]

mozilla/gfx/public/nsIDeviceContext.h has some error codes for this purpose.
NS_ERROR_GFX_PRINTER_CMD_NOT_FOUND may be the one you're looking for...

Comment 2

[rods (gone)]

taking

Comment 3

[rods (gone)]

Is this still a problem?

Comment 4

[sujay]

yes this should still be a problem. see how we handle it 
for 4.x...

Comment 5

[Pete Zha]

Who have idea on how to get error when lp/lpr not defined?
I checked these code:
pipe = popen(mPrintSetup->print_cmd, "w");
The popen will always return no-NULL even command not found. And errno is always 0.
Shall I check the file exists for lp/lpr? I don't think it's a good idea since
it make things more complex...

Comment 6

[Pete Zha]

Attachment: patch

Based on Roland([e-mail])'s patch(attachment
83527 [details] [diff] [review]) in bug 143109, but use errno to determine error.

Comment 7

[Pete Zha]

*** Bug 143109 has been marked as a duplicate of this bug. ***

Comment 8

[Pete Zha]

=>

Comment 9

[Pete Zha]

Roland, dcone,
Could you give r=? Thanks

Comment 10

[Roland Mainz]

Comment on attachment 92355 [details] [diff] [review]
patch

r=[e-mail]

Comment 11

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 92355 [details] [diff] [review]
patch

sr=bzbarsky

Comment 12

[Pete Zha]

checked in trunk

Comment 13

[Roland Mainz]

Requesting a{1.0.2}= ...