1022781 - Unnecessary plural form in Conference Call header

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Francesco Lodolo [:flod]]

See bug 977054
https://github.com/mozilla-b2g/gaia/commit/6e7a17b0c93f90ad7cc25db957f948472ab436dc

+conference={[ plural(n) ]}
+conference[one]   = Conference ({{ n }})
+conference[two]   = Conference ({{ n }})
+conference[few]   = Conference ({{ n }})
+conference[many]  = Conference ({{ n }})
+conference[other] = Conference ({{ n }})

This is not a plural form: conference doesn't change based on the number of participants, so the plural form is unnecessary.

This should be replace by one string with a placeholder

# LOCALIZATION NOTE(conferencecall): {{n}} represents the number of
# participants in the group call.
conferencecall = Conference ({{n}})

Comment 1

[Doug Sherk (:drs) (inactive)]

Are you sure that this is true for all languages/locales?

Comment 2

[Francesco Lodolo [:flod]]

{{n}} refers to participants, not conferences. 

If there are different translations, I assume it happens because people thought the number was related to "call" (previous string was "Group call"), not participants.

Also, partially unrelated: as a general rule, always add all 6 plural cases, even if they don't make any sense (zero), because it makes tools happy.

Comment 3

[Anthony Ricaud (:rik)]

Happy to take a patch for this Flod. ;)

Comment 4

[Francesco Lodolo [:flod]]

Attachment: Pull request on Github

Tests run fine locally, problem is that I can't test this patch on a real phone.

I call 1 number, add a second one, then touch the icon to merge calls but I get "Unable to merge call". I tried several combinations (2 SIMs same company + landline, 3 SIMs from 2 different operators) but I always get the same message.

Comment 5

[Francesco Lodolo [:flod]]

Attachment: Patched Keon

OK, I discovered that conference call needs to be enabled with my operator.

Comment 6

[Anthony Ricaud (:rik)]

Comment on attachment 8439050 [details] [review]
Pull request on Github

Thanks! Once it lands, we should ask for 2.0 approval I guess.

Comment 7

[Francesco Lodolo [:flod]]

The current strings don't prevent to have a correct localization, you simply need to repeat the same translation multiple times. So it's better to not break string freeze on 2.0 for this and let it ride the trains.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/d4d31ceea43a72ac318347d5b22a5e31e5e750bb