1022923 - Add index to bug_user_last_visit.last_visit_ts

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Comment 1

[Dylan Hardison [:dylan] (he/him)]

Attachment: bugzilla-upstream-add-index.patch

For Bug 1017117

Comment 2

[:glob ✱]

Comment on attachment 8437228 [details] [diff] [review]
bugzilla-upstream-add-index.patch

Review of attachment 8437228 [details] [diff] [review]:
-----------------------------------------------------------------

you also need to update the table's definition in Bugzilla/DB/Schema.pm

::: Bugzilla/Install/DB.pm
@@ +714,5 @@
>      # 2013-08-26 [e-mail] - Bug 903895
>      _fix_components_primary_key();
>  
> +    # 2014-06-09 [e-mail] - Bug 1022923
> +    $dbh->bz_add_index('bug_user_last_visit', 'bug_user_last_visit_last_visit_ts_idx', ['last_visit_ts']);

this line's a bit on the long side, please wrap

Comment 3

[Dylan Hardison [:dylan] (he/him)]

Attachment: bugzilla-upstream-add-index-v2.patch

Patch was authored in my bmo directory (and then ported to upstream) so it had the bmo line length limit instead of the bugzilla one. Fixed.

Comment 4

[:glob ✱]

Comment on attachment 8437674 [details] [diff] [review]
bugzilla-upstream-add-index-v2.patch

Review of attachment 8437674 [details] [diff] [review]:
-----------------------------------------------------------------

you also need to update the table's definition in Bugzilla/DB/Schema.pm, as that's the canonical schema definition.

Comment 5

[Dylan Hardison [:dylan] (he/him)]

Attachment: bugzilla-upstream-add-index-v2.1.patch

Missed the schema definition, included here.

Comment 6

[:glob ✱]

Comment on attachment 8438115 [details] [diff] [review]
bugzilla-upstream-add-index-v2.1.patch

Review of attachment 8438115 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob

Comment 7

[Dylan Hardison [:dylan] (he/him)]

To [e-mail]:bugzilla/bugzilla.git
   6f1a5f0..eb13c38  master -> master

Should I also commit this to bmo?

Comment 8

[Dylan Hardison [:dylan] (he/him)]

To [e-mail]:webtools/bmo/bugzilla.git
   9d30ede..9916f57  master -> master