903895 - Allow more than 32k components

Status: RESOLVED FIXED

(Bugzilla :: Database, enhancement)

Description

[Simon Green]

The component.id column and its foreign keys are defined as INT2. This means the maximum allowed value (signed) is 32767 (source https://dev.mysql.com/doc/refman/5.1/en/integer-types.html )

This patch is to change the values to INT3, allowing up to 8.3 million components.

Comment 1

[Simon Green]

Attachment: v1 patch

Comment 2

[Gervase Markham [:gerv]]

Comment on attachment 795272 [details] [diff] [review]
v1 patch

r=gerv. I'm still thinking about whether supporting >32K components in the base code is a good idea in general (i.e. what to do about 909203), but this change is harmless, and helps you guys.

Gerv

Comment 3

[Frédéric Buclin]

Has this patch been tested on Pg and Oracle? I remember Oracle did some stupidities when playing with auto-incremented columns in the past.

Comment 4

[Simon Green]

(In reply to Frédéric Buclin from comment #3)
> Has this patch been tested on Pg and Oracle? I remember Oracle did some
> stupidities when playing with auto-incremented columns in the past.

No, but it is the same change as in bug 776972 and 776982, and I don't recall anyone reporting issues with that. Both changes went out in Bugzilla 4.4

Comment 5

[Frédéric Buclin]

DB schema changes are not allowed on stable branches. So you cannot take it for 4.4.x.

Comment 6

[Simon Green]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                       
modified Bugzilla/DB/Schema.pm
modified Bugzilla/Install/DB.pm
Committed revision 8719.